From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: [PATCH for-4.10 1/2] tools/libxc: Fix precopy_policy() to not pass a structure by value Date: Fri, 13 Oct 2017 18:32:18 +0100 Message-ID: <1507915939-30424-1-git-send-email-andrew.cooper3@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Xen-devel Cc: Andrew Cooper , Julien Grall , Ian Jackson , Wei Liu List-Id: xen-devel@lists.xenproject.org Yy9zIDRkNjliMzQ5NSAiSW50cm9kdWNlIG1pZ3JhdGlvbiBwcmVjb3B5IHBvbGljeSIgdXNlcyBi b2d1cyByZWFzb25pbmcgdG8KanVzdGlmeSBwYXNzaW5nIHByZWNvcHlfc3RhdHMgYnkgdmFsdWUu CgpVbmRlciBubyBjaXJjdW1zdGFuY2VzIGNhbiB0aGUgcHJlY29weSBjYWxsYmFjayBldmVyIGJl IGV4ZWN1dGluZyBpbiBhCnNlcGFyYXRlIGFkZHJlc3Mgc3BhY2UuCgpTd2l0Y2ggdGhlIGNhbGxi YWNrIHRvIHBhc3NpbmcgYnkgcG9pbnRlciB3aGljaCBpcyBmYXIgbW9yZSBlZmZpY2llbnQsIGFu ZApkcm9wIHRoZSB0eXBlZGVmIChiZWNhdXNlIG5vbmUgb2YgdGhlIG90aGVyIGNhbGxiYWNrIGhh dmUgdGhpcyBvZGRpdHkpLgoKVGhpcyBpcyBubyBmdW5jdGlvbmFsIGNoYW5nZSwgYXMgdGhlcmUg YXJlIG5vIHVzZXJzIG9mIHRoaXMgaW50ZXJmYWNlIHlldC4KClNpZ25lZC1vZmYtYnk6IEFuZHJl dyBDb29wZXIgPGFuZHJldy5jb29wZXIzQGNpdHJpeC5jb20+Ci0tLQpDQzogSWFuIEphY2tzb24g PElhbi5KYWNrc29uQGV1LmNpdHJpeC5jb20+CkNDOiBXZWkgTGl1IDx3ZWkubGl1MkBjaXRyaXgu Y29tPgpDQzogSnVsaWVuIEdyYWxsIDxqdWxpZW4uZ3JhbGxAYXJtLmNvbT4KCkFwcG9sb2dpZXMg Zm9yIHRoaXMgYmVpbmcgbGF0ZS4gIEkgZGlkIGludGVuZCB0byBnZXQgaXQgc29ydGVkIGJlZm9y ZSBjb2RlCmZyZWV6ZSwgYnV0IEkgd2FzIG90aGVyd2lzZSBidXN5LgotLS0KIHRvb2xzL2xpYnhj L2luY2x1ZGUveGVuZ3Vlc3QuaCB8ICA4ICstLS0tLS0tCiB0b29scy9saWJ4Yy94Y19zcl9zYXZl LmMgICAgICAgfCAxOSArKysrKysrKystLS0tLS0tLS0tCiAyIGZpbGVzIGNoYW5nZWQsIDEwIGlu c2VydGlvbnMoKyksIDE3IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL3Rvb2xzL2xpYnhjL2lu Y2x1ZGUveGVuZ3Vlc3QuaCBiL3Rvb2xzL2xpYnhjL2luY2x1ZGUveGVuZ3Vlc3QuaAppbmRleCBi NGIyZTE5Li5mNmE2MWFiIDEwMDY0NAotLS0gYS90b29scy9saWJ4Yy9pbmNsdWRlL3hlbmd1ZXN0 LmgKKysrIGIvdG9vbHMvbGlieGMvaW5jbHVkZS94ZW5ndWVzdC5oCkBAIC00NywxMiArNDcsNiBA QCBzdHJ1Y3QgcHJlY29weV9zdGF0cwogICAgIGxvbmcgZGlydHlfY291bnQ7IC8qIC0xIGlmIHVu a25vd24gKi8KIH07CiAKLS8qCi0gKiBBIHByZWNvcHlfcG9saWN5IGNhbGxiYWNrIG1heSBub3Qg YmUgcnVubmluZyBpbiB0aGUgc2FtZSBhZGRyZXNzCi0gKiBzcGFjZSBhcyBsaWJ4YyBhbiBzbyBw cmVjb3B5X3N0YXRzIGlzIHBhc3NlZCBieSB2YWx1ZS4KLSAqLwotdHlwZWRlZiBpbnQgKCpwcmVj b3B5X3BvbGljeV90KShzdHJ1Y3QgcHJlY29weV9zdGF0cywgdm9pZCAqKTsKLQogLyogY2FsbGJh Y2tzIHByb3ZpZGVkIGJ5IHhjX2RvbWFpbl9zYXZlICovCiBzdHJ1Y3Qgc2F2ZV9jYWxsYmFja3Mg ewogICAgIC8qIENhbGxlZCBhZnRlciBleHBpcmF0aW9uIG9mIGNoZWNrcG9pbnQgaW50ZXJ2YWws CkBAIC03Miw3ICs2Niw3IEBAIHN0cnVjdCBzYXZlX2NhbGxiYWNrcyB7CiAjZGVmaW5lIFhHU19Q T0xJQ1lfQ09OVElOVUVfUFJFQ09QWSAwICAvKiBSZW1haW4gaW4gdGhlIHByZWNvcHkgcGhhc2Uu ICovCiAjZGVmaW5lIFhHU19QT0xJQ1lfU1RPUF9BTkRfQ09QWSAgICAxICAvKiBJbW1lZGlhdGVs eSBzdXNwZW5kIGFuZCB0cmFuc21pdCB0aGUKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAqIHJlbWFpbmluZyBkaXJ0eSBwYWdlcy4gKi8KLSAgICBwcmVjb3B5X3BvbGlj eV90IHByZWNvcHlfcG9saWN5OworICAgIGludCAoKnByZWNvcHlfcG9saWN5KShzdHJ1Y3QgcHJl Y29weV9zdGF0cyAqLCB2b2lkICopOwogCiAgICAgLyoKICAgICAgKiBDYWxsZWQgYWZ0ZXIgdGhl IGd1ZXN0J3MgZGlydHkgcGFnZXMgaGF2ZSBiZWVuCmRpZmYgLS1naXQgYS90b29scy9saWJ4Yy94 Y19zcl9zYXZlLmMgYi90b29scy9saWJ4Yy94Y19zcl9zYXZlLmMKaW5kZXggNWE0MGU1OC4uYmVj ZWI2YSAxMDA2NDQKLS0tIGEvdG9vbHMvbGlieGMveGNfc3Jfc2F2ZS5jCisrKyBiL3Rvb2xzL2xp YnhjL3hjX3NyX3NhdmUuYwpAQCAtNDc4LDExICs0NzgsMTEgQEAgc3RhdGljIGludCB1cGRhdGVf cHJvZ3Jlc3Nfc3RyaW5nKHN0cnVjdCB4Y19zcl9jb250ZXh0ICpjdHgsIGNoYXIgKipzdHIpCiAj ZGVmaW5lIFNQUF9NQVhfSVRFUkFUSU9OUyAgICAgIDUKICNkZWZpbmUgU1BQX1RBUkdFVF9ESVJU WV9DT1VOVCA1MAogCi1zdGF0aWMgaW50IHNpbXBsZV9wcmVjb3B5X3BvbGljeShzdHJ1Y3QgcHJl Y29weV9zdGF0cyBzdGF0cywgdm9pZCAqdXNlcikKK3N0YXRpYyBpbnQgc2ltcGxlX3ByZWNvcHlf cG9saWN5KHN0cnVjdCBwcmVjb3B5X3N0YXRzICpzdGF0cywgdm9pZCAqdXNlcikKIHsKLSAgICBy ZXR1cm4gKChzdGF0cy5kaXJ0eV9jb3VudCA+PSAwICYmCi0gICAgICAgICAgICBzdGF0cy5kaXJ0 eV9jb3VudCA8IFNQUF9UQVJHRVRfRElSVFlfQ09VTlQpIHx8Ci0gICAgICAgICAgICBzdGF0cy5p dGVyYXRpb24gPj0gU1BQX01BWF9JVEVSQVRJT05TKQorICAgIHJldHVybiAoKHN0YXRzLT5kaXJ0 eV9jb3VudCA+PSAwICYmCisgICAgICAgICAgICAgc3RhdHMtPmRpcnR5X2NvdW50IDwgU1BQX1RB UkdFVF9ESVJUWV9DT1VOVCkgfHwKKyAgICAgICAgICAgIHN0YXRzLT5pdGVyYXRpb24gPj0gU1BQ X01BWF9JVEVSQVRJT05TKQogICAgICAgICA/IFhHU19QT0xJQ1lfU1RPUF9BTkRfQ09QWQogICAg ICAgICA6IFhHU19QT0xJQ1lfQ09OVElOVUVfUFJFQ09QWTsKIH0KQEAgLTUwMiw3ICs1MDIsOSBA QCBzdGF0aWMgaW50IHNlbmRfbWVtb3J5X2xpdmUoc3RydWN0IHhjX3NyX2NvbnRleHQgKmN0eCkK ICAgICBERUNMQVJFX0hZUEVSQ0FMTF9CVUZGRVJfU0hBRE9XKHVuc2lnbmVkIGxvbmcsIGRpcnR5 X2JpdG1hcCwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICZjdHgtPnNhdmUu ZGlydHlfYml0bWFwX2hidWYpOwogCi0gICAgcHJlY29weV9wb2xpY3lfdCBwcmVjb3B5X3BvbGlj eSA9IGN0eC0+c2F2ZS5jYWxsYmFja3MtPnByZWNvcHlfcG9saWN5OworICAgIHR5cGVvZihjdHgt PnNhdmUuY2FsbGJhY2tzLT5wcmVjb3B5X3BvbGljeSkgcHJlY29weV9wb2xpY3kgPQorICAgICAg ICBjdHgtPnNhdmUuY2FsbGJhY2tzLT5wcmVjb3B5X3BvbGljeSA/OiBzaW1wbGVfcHJlY29weV9w b2xpY3k7CisKICAgICB2b2lkICpkYXRhID0gY3R4LT5zYXZlLmNhbGxiYWNrcy0+ZGF0YTsKIAog ICAgIHN0cnVjdCBwcmVjb3B5X3N0YXRzICpwb2xpY3lfc3RhdHM7CkBAIC01MTUsMTQgKzUxNywx MSBAQCBzdGF0aWMgaW50IHNlbmRfbWVtb3J5X2xpdmUoc3RydWN0IHhjX3NyX2NvbnRleHQgKmN0 eCkKICAgICAgICAgeyAuZGlydHlfY291bnQgICA9IGN0eC0+c2F2ZS5wMm1fc2l6ZSB9OwogICAg IHBvbGljeV9zdGF0cyA9ICZjdHgtPnNhdmUuc3RhdHM7CiAKLSAgICBpZiAoIHByZWNvcHlfcG9s aWN5ID09IE5VTEwgKQotICAgICAgICAgcHJlY29weV9wb2xpY3kgPSBzaW1wbGVfcHJlY29weV9w b2xpY3k7Ci0KICAgICBiaXRtYXBfc2V0KGRpcnR5X2JpdG1hcCwgY3R4LT5zYXZlLnAybV9zaXpl KTsKIAogICAgIGZvciAoIDsgOyApCiAgICAgewotICAgICAgICBwb2xpY3lfZGVjaXNpb24gPSBw cmVjb3B5X3BvbGljeSgqcG9saWN5X3N0YXRzLCBkYXRhKTsKKyAgICAgICAgcG9saWN5X2RlY2lz aW9uID0gcHJlY29weV9wb2xpY3kocG9saWN5X3N0YXRzLCBkYXRhKTsKICAgICAgICAgeCsrOwog CiAgICAgICAgIGlmICggc3RhdHMuZGlydHlfY291bnQgPiAwICYmIHBvbGljeV9kZWNpc2lvbiAh PSBYR1NfUE9MSUNZX0FCT1JUICkKQEAgLTU0Myw3ICs1NDIsNyBAQCBzdGF0aWMgaW50IHNlbmRf bWVtb3J5X2xpdmUoc3RydWN0IHhjX3NyX2NvbnRleHQgKmN0eCkKICAgICAgICAgcG9saWN5X3N0 YXRzLT50b3RhbF93cml0dGVuICs9IHBvbGljeV9zdGF0cy0+ZGlydHlfY291bnQ7CiAgICAgICAg IHBvbGljeV9zdGF0cy0+ZGlydHlfY291bnQgICA9IC0xOwogCi0gICAgICAgIHBvbGljeV9kZWNp c2lvbiA9IHByZWNvcHlfcG9saWN5KCpwb2xpY3lfc3RhdHMsIGRhdGEpOworICAgICAgICBwb2xp Y3lfZGVjaXNpb24gPSBwcmVjb3B5X3BvbGljeShwb2xpY3lfc3RhdHMsIGRhdGEpOwogCiAgICAg ICAgIGlmICggcG9saWN5X2RlY2lzaW9uICE9IFhHU19QT0xJQ1lfQ09OVElOVUVfUFJFQ09QWSAp CiAgICAgICAgICAgIGJyZWFrOwotLSAKMi4xLjQKCgpfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwpYZW4tZGV2ZWwgbWFpbGluZyBsaXN0Clhlbi1kZXZlbEBs aXN0cy54ZW4ub3JnCmh0dHBzOi8vbGlzdHMueGVuLm9yZy94ZW4tZGV2ZWwK