From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: [PATCH for-4.10 2/2] tools/libxc: Fix various code
	smells in send_memory_live()
Date: Fri, 13 Oct 2017 18:32:19 +0100
Message-ID: <1507915939-30424-2-git-send-email-andrew.cooper3@citrix.com>
References: <1507915939-30424-1-git-send-email-andrew.cooper3@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1507915939-30424-1-git-send-email-andrew.cooper3@citrix.com>
List-Unsubscribe: <https://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <https://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xen.org
Sender: "Xen-devel" <xen-devel-bounces@lists.xen.org>
To: Xen-devel <xen-devel@lists.xen.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Julien Grall <julien.grall@arm.com>, Ian Jackson <Ian.Jackson@eu.citrix.com>, Wei Liu <wei.liu2@citrix.com>
List-Id: xen-devel@lists.xenproject.org

ICogRG9uJ3QgemVybyBjdHgtPnNhdmUuc3RhdHM7IGl0IGlzIGFscmVhZHkgemVyb2VkCiAqIE5v
IG5lZWQgZm9yIHggYXMgaXQgZHVwbGljYXRlcyBjdHgtPnNhdmUuc3RhdHMuaXRlcmF0aW9uCiAq
IERlZmVyIHNldHRpbmcgZGlydHlfY291bnQgdW50aWwgdGhlIGJpdG1hcCBoYXMgYmVlbiBmaWxs
ZWQgdG8gbWF0Y2ggdGhlCiAgIGJlaGF2aW91ciBvZiBYRU5fRE9NQ1RMX1NIQURPV19PUF9DTEVB
TgogKiBEcm9wIHNwdXJpb3VzIGJsYW5rIGxpbmUKClNpZ25lZC1vZmYtYnk6IEFuZHJldyBDb29w
ZXIgPGFuZHJldy5jb29wZXIzQGNpdHJpeC5jb20+Ci0tLQpDQzogSWFuIEphY2tzb24gPElhbi5K
YWNrc29uQGV1LmNpdHJpeC5jb20+CkNDOiBXZWkgTGl1IDx3ZWkubGl1MkBjaXRyaXguY29tPgpD
QzogSnVsaWVuIEdyYWxsIDxqdWxpZW4uZ3JhbGxAYXJtLmNvbT4KLS0tCiB0b29scy9saWJ4Yy94
Y19zcl9zYXZlLmMgfCAxMyArKystLS0tLS0tLS0tCiAxIGZpbGUgY2hhbmdlZCwgMyBpbnNlcnRp
b25zKCspLCAxMCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS90b29scy9saWJ4Yy94Y19zcl9z
YXZlLmMgYi90b29scy9saWJ4Yy94Y19zcl9zYXZlLmMKaW5kZXggYmVjZWI2YS4uYWZjNWNiOSAx
MDA2NDQKLS0tIGEvdG9vbHMvbGlieGMveGNfc3Jfc2F2ZS5jCisrKyBiL3Rvb2xzL2xpYnhjL3hj
X3NyX3NhdmUuYwpAQCAtNDk1LDcgKzQ5NSw2IEBAIHN0YXRpYyBpbnQgc2VuZF9tZW1vcnlfbGl2
ZShzdHJ1Y3QgeGNfc3JfY29udGV4dCAqY3R4KQogICAgIHhjX2ludGVyZmFjZSAqeGNoID0gY3R4
LT54Y2g7CiAgICAgeGNfc2hhZG93X29wX3N0YXRzX3Qgc3RhdHMgPSB7IDAsIGN0eC0+c2F2ZS5w
Mm1fc2l6ZSB9OwogICAgIGNoYXIgKnByb2dyZXNzX3N0ciA9IE5VTEw7Ci0gICAgdW5zaWduZWQg
aW50IHggPSAwOwogICAgIGludCByYzsKICAgICBpbnQgcG9saWN5X2RlY2lzaW9uOwogCkBAIC01
MDYsMjMgKzUwNSwxOCBAQCBzdGF0aWMgaW50IHNlbmRfbWVtb3J5X2xpdmUoc3RydWN0IHhjX3Ny
X2NvbnRleHQgKmN0eCkKICAgICAgICAgY3R4LT5zYXZlLmNhbGxiYWNrcy0+cHJlY29weV9wb2xp
Y3kgPzogc2ltcGxlX3ByZWNvcHlfcG9saWN5OwogCiAgICAgdm9pZCAqZGF0YSA9IGN0eC0+c2F2
ZS5jYWxsYmFja3MtPmRhdGE7Ci0KLSAgICBzdHJ1Y3QgcHJlY29weV9zdGF0cyAqcG9saWN5X3N0
YXRzOworICAgIHN0cnVjdCBwcmVjb3B5X3N0YXRzICpwb2xpY3lfc3RhdHMgPSAmY3R4LT5zYXZl
LnN0YXRzOwogCiAgICAgcmMgPSB1cGRhdGVfcHJvZ3Jlc3Nfc3RyaW5nKGN0eCwgJnByb2dyZXNz
X3N0cik7CiAgICAgaWYgKCByYyApCiAgICAgICAgIGdvdG8gb3V0OwogCi0gICAgY3R4LT5zYXZl
LnN0YXRzID0gKHN0cnVjdCBwcmVjb3B5X3N0YXRzKQotICAgICAgICB7IC5kaXJ0eV9jb3VudCAg
ID0gY3R4LT5zYXZlLnAybV9zaXplIH07Ci0gICAgcG9saWN5X3N0YXRzID0gJmN0eC0+c2F2ZS5z
dGF0czsKLQogICAgIGJpdG1hcF9zZXQoZGlydHlfYml0bWFwLCBjdHgtPnNhdmUucDJtX3NpemUp
OworICAgIHBvbGljeV9zdGF0cy0+ZGlydHlfY291bnQgPSBjdHgtPnNhdmUucDJtX3NpemU7CiAK
ICAgICBmb3IgKCA7IDsgKQogICAgIHsKICAgICAgICAgcG9saWN5X2RlY2lzaW9uID0gcHJlY29w
eV9wb2xpY3kocG9saWN5X3N0YXRzLCBkYXRhKTsKLSAgICAgICAgeCsrOwogCiAgICAgICAgIGlm
ICggc3RhdHMuZGlydHlfY291bnQgPiAwICYmIHBvbGljeV9kZWNpc2lvbiAhPSBYR1NfUE9MSUNZ
X0FCT1JUICkKICAgICAgICAgewpAQCAtNTM4LDcgKzUzMiw3IEBAIHN0YXRpYyBpbnQgc2VuZF9t
ZW1vcnlfbGl2ZShzdHJ1Y3QgeGNfc3JfY29udGV4dCAqY3R4KQogICAgICAgICBpZiAoIHBvbGlj
eV9kZWNpc2lvbiAhPSBYR1NfUE9MSUNZX0NPTlRJTlVFX1BSRUNPUFkgKQogICAgICAgICAgICAg
YnJlYWs7CiAKLSAgICAgICAgcG9saWN5X3N0YXRzLT5pdGVyYXRpb24gICAgID0geDsKKyAgICAg
ICAgcG9saWN5X3N0YXRzLT5pdGVyYXRpb24rKzsKICAgICAgICAgcG9saWN5X3N0YXRzLT50b3Rh
bF93cml0dGVuICs9IHBvbGljeV9zdGF0cy0+ZGlydHlfY291bnQ7CiAgICAgICAgIHBvbGljeV9z
dGF0cy0+ZGlydHlfY291bnQgICA9IC0xOwogCkBAIC01NTgsNyArNTUyLDYgQEAgc3RhdGljIGlu
dCBzZW5kX21lbW9yeV9saXZlKHN0cnVjdCB4Y19zcl9jb250ZXh0ICpjdHgpCiAgICAgICAgIH0K
IAogICAgICAgICBwb2xpY3lfc3RhdHMtPmRpcnR5X2NvdW50ID0gc3RhdHMuZGlydHlfY291bnQ7
Ci0KICAgICB9CiAKICBvdXQ6Ci0tIAoyLjEuNAoKCl9fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fClhlbi1kZXZlbCBtYWlsaW5nIGxpc3QKWGVuLWRldmVsQGxp
c3RzLnhlbi5vcmcKaHR0cHM6Ly9saXN0cy54ZW4ub3JnL3hlbi1kZXZlbAo=