From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH v4 4/5] xentrace: enable per-VCPU extratime flag for RTDS Date: Tue, 17 Oct 2017 10:10:51 +0200 Message-ID: <1508227851.6552.135.camel@linux.it> References: <1507744926-3950-1-git-send-email-mengxu@cis.upenn.edu> <1507744926-3950-5-git-send-email-mengxu@cis.upenn.edu> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0180266264207899904==" Return-path: In-Reply-To: <1507744926-3950-5-git-send-email-mengxu@cis.upenn.edu> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Meng Xu , xen-devel@lists.xen.org Cc: george.dunlap@eu.citrix.com, ian.jackson@eu.citrix.com, xumengpanda@gmail.com, wei.liu2@citrix.com List-Id: xen-devel@lists.xenproject.org --===============0180266264207899904== Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-UmSrs2179xZCCbXR8MWZ" --=-UmSrs2179xZCCbXR8MWZ Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, 2017-10-11 at 14:02 -0400, Meng Xu wrote: > Change repl_budget event output for xentrace formats and xenalyze >=20 > Signed-off-by: Meng Xu >=20 I'd say: Reviewed-by: Dario Faggioli However... > diff --git a/tools/xentrace/xenalyze.c b/tools/xentrace/xenalyze.c > index 79bdba7..19e050f 100644 > --- a/tools/xentrace/xenalyze.c > +++ b/tools/xentrace/xenalyze.c > @@ -7935,23 +7935,29 @@ void sched_process(struct pcpu_info *p) > unsigned int vcpuid:16, domid:16; > uint64_t cur_bg; > int delta; > + unsigned priority_level; > + unsigned has_extratime; > ...this last field is 'bool' in Xen. I appreciate that xenalyze does not build if you just make this bool as well. But it does build for me, if you do that, and also include stdbool.h, which I think is a fine thing to do. Anyway, I'll leave this to George and tools' maintainers. Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli --=-UmSrs2179xZCCbXR8MWZ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEES5ssOj3Vhr0WPnOLFkJ4iaW4c+4FAlnluwwACgkQFkJ4iaW4 c+5EORAApPjZc2IBhRrdm9eyeAXm9RjZddMohg2nSqxEIkju8o+lc+TIrpspIr/b AMHMzGV7SNH/a+Bbk2E8pe3M0WCDiyYu2XvxdiUMMGZ+C6AM4mHwkU/XZkkt0Ifg H1mphdp85caXP4hkQ5qx7X3jsUVAp4c3F24xp4xoLFvdZ99IwOj4d2zXfS4m42mx Ds1N1RIBvJZ5fOefSOCBKO7mGO63axlsl/MBWNA4462ZfS4bN8oNVnEdUY2kxqrL EP+PgW2vJaA0jhBjIQ0mUJFXaY9Gi0+/yNOKfKevNvRhMvXVoO4PFU/SSiqaIRYW ZRVrAJLeFaOicP7UTrig223y60lQQhRmyDBJqPeSYjPfk/31h8CkG6GnhPzXHT/t /uenWznefQo5Nmmyq3UzYFXXHnNHi9Ra5HtOz7P5Dk1yuZkvYTAGl8DiY3gsyoR1 laCgBvi2AOOrfR3AJe2vDRmCM8RdCugl+dl0FOOljjhsS57lMEqzIExbCVQQpaoM aH/EmNHMbhIdHCLyQaGhUVObvhOeLuuHfFNuA+gbpIWnxIMz4aylGdrwvQ9LPnN3 v7z/55Ct+gMO6V3sDGb979hgRqUMsETmY56wvSGI27dOg/s9Tup4p9sMmqUf95X2 vMLD4V9iBejUS7+Z+bwLtK0mcV6F5nYQ1Zyb0FHPEUnqNmUZNRY= =GtGu -----END PGP SIGNATURE----- --=-UmSrs2179xZCCbXR8MWZ-- --===============0180266264207899904== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5v cmcveGVuLWRldmVsCg== --===============0180266264207899904==--