From: Euan Harris <euan.harris@citrix.com>
To: xen-devel@lists.xenproject.org
Cc: andrew.cooper3@citrix.com, kevin.tian@intel.com,
Euan Harris <euan.harris@citrix.com>,
jun.nakajima@intel.com, jbeulich@suse.com
Subject: [PATCH 1/9] x86/vvmx: Remove enum vmx_regs_enc
Date: Thu, 26 Oct 2017 18:03:11 +0100 [thread overview]
Message-ID: <1509037399-48926-2-git-send-email-euan.harris@citrix.com> (raw)
In-Reply-To: <1509037399-48926-1-git-send-email-euan.harris@citrix.com>
This is the standard register encoding, is not VVMX-specific and is only
used in a couple of places.
Signed-off-by: Euan Harris <euan.harris@citrix.com>
---
xen/arch/x86/hvm/vmx/vvmx.c | 8 ++++----
xen/include/asm-x86/hvm/vmx/vvmx.h | 22 ----------------------
2 files changed, 4 insertions(+), 26 deletions(-)
diff --git a/xen/arch/x86/hvm/vmx/vvmx.c b/xen/arch/x86/hvm/vmx/vvmx.c
index dde02c076b..9d87786894 100644
--- a/xen/arch/x86/hvm/vmx/vvmx.c
+++ b/xen/arch/x86/hvm/vmx/vvmx.c
@@ -201,10 +201,10 @@ struct vmx_inst_decoded {
unsigned long mem;
unsigned int len;
};
- enum vmx_regs_enc reg1;
+ unsigned int reg1;
};
- enum vmx_regs_enc reg2;
+ unsigned int reg2;
};
enum vmx_ops_result {
@@ -345,7 +345,7 @@ enum vmx_insn_errno set_vvmcs_real_safe(const struct vcpu *v, u32 encoding,
}
static unsigned long reg_read(struct cpu_user_regs *regs,
- enum vmx_regs_enc index)
+ unsigned int index)
{
unsigned long *pval = decode_register(index, regs, 0);
@@ -353,7 +353,7 @@ static unsigned long reg_read(struct cpu_user_regs *regs,
}
static void reg_write(struct cpu_user_regs *regs,
- enum vmx_regs_enc index,
+ unsigned int index,
unsigned long value)
{
unsigned long *pval = decode_register(index, regs, 0);
diff --git a/xen/include/asm-x86/hvm/vmx/vvmx.h b/xen/include/asm-x86/hvm/vmx/vvmx.h
index 3285b03bbb..9ea35eb795 100644
--- a/xen/include/asm-x86/hvm/vmx/vvmx.h
+++ b/xen/include/asm-x86/hvm/vmx/vvmx.h
@@ -64,28 +64,6 @@ struct nestedvmx {
/* bit 0-8, and 12 must be 1 */
#define VMX_ENTRY_CTLS_DEFAULT1 0x11ff
-/*
- * Encode of VMX instructions base on Table 24-11 & 24-12 of SDM 3B
- */
-
-enum vmx_regs_enc {
- VMX_REG_RAX,
- VMX_REG_RCX,
- VMX_REG_RDX,
- VMX_REG_RBX,
- VMX_REG_RSP,
- VMX_REG_RBP,
- VMX_REG_RSI,
- VMX_REG_RDI,
- VMX_REG_R8,
- VMX_REG_R9,
- VMX_REG_R10,
- VMX_REG_R11,
- VMX_REG_R12,
- VMX_REG_R13,
- VMX_REG_R14,
- VMX_REG_R15,
-};
union vmx_inst_info {
struct {
--
2.13.6
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-10-26 17:04 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-26 17:03 [PATCH 0/9] x86/vvmx: Read instruction operands correctly on VM exit Euan Harris
2017-10-26 17:03 ` Euan Harris [this message]
2017-10-26 17:03 ` [PATCH 2/9] x86/vvmx: Unify operands in struct vmx_inst_decoded Euan Harris
2017-10-26 17:03 ` [PATCH 3/9] x86/vvmx: Extract operand reading logic into operand_read() Euan Harris
2017-11-27 17:01 ` Jan Beulich
2017-11-27 18:08 ` Andrew Cooper
2017-11-28 8:40 ` Jan Beulich
2017-11-28 8:14 ` Jan Beulich
2017-10-26 17:03 ` [PATCH 4/9] x86/vvmx: Remove unnecessary VMX operand reads Euan Harris
2017-11-02 7:07 ` Tian, Kevin
2017-11-27 17:03 ` Jan Beulich
2017-10-26 17:03 ` [PATCH 5/9] x86/vvmx: Replace direct calls to reg_read() with operand_read() Euan Harris
2017-10-26 17:03 ` [PATCH 6/9] x86/vvmx: Remove operand reading from decode_vmx_inst() Euan Harris
2017-10-26 17:03 ` [PATCH 7/9] x86/vvmx: Use correct sizes when reading operands Euan Harris
2017-11-28 8:32 ` Jan Beulich
2017-12-01 18:45 ` Andrew Cooper
2017-12-04 8:55 ` Jan Beulich
2017-10-26 17:03 ` [PATCH 8/9] x86/hvm: Add hvm_copy_{to, from}_guest_virt() helpers Euan Harris
2017-11-28 8:38 ` Jan Beulich
2017-10-26 17:03 ` [PATCH 9/9] x86/vvmx: Use hvm_copy_{to, from}_guest_virt() to read operands Euan Harris
2017-11-28 8:49 ` Jan Beulich
2017-10-26 17:59 ` [PATCH 0/9] x86/vvmx: Read instruction operands correctly on VM exit Andrew Cooper
2017-11-02 7:23 ` Tian, Kevin
2017-11-02 18:39 ` Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1509037399-48926-2-git-send-email-euan.harris@citrix.com \
--to=euan.harris@citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=jbeulich@suse.com \
--cc=jun.nakajima@intel.com \
--cc=kevin.tian@intel.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).