From: Quan Xu <quan.xu03@gmail.com>
To: kvm@vger.kernel.org, linux-doc@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org, x86@kernel.org,
xen-devel@lists.xenproject.org
Cc: Yang Zhang <yang.zhang.wz@gmail.com>,
Len Brown <len.brown@intel.com>, Quan Xu <quan.xu0@gmail.com>,
Tom Lendacky <thomas.lendacky@amd.com>,
Peter Zijlstra <peterz@infradead.org>,
Kyle Huey <me@kylehuey.com>, Ingo Molnar <mingo@redhat.com>,
Borislav Petkov <bp@alien8.de>, Andy Lutomirski <luto@kernel.org>,
"H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
Tobias Klauser <tklauser@distanz.ch>
Subject: [PATCH RFC v3 3/6] sched/idle: Add a generic poll before enter real idle path
Date: Mon, 13 Nov 2017 18:06:02 +0800 [thread overview]
Message-ID: <1510567565-5118-4-git-send-email-quan.xu0@gmail.com> (raw)
In-Reply-To: <1510567565-5118-1-git-send-email-quan.xu0@gmail.com>
From: Yang Zhang <yang.zhang.wz@gmail.com>
Implement a generic idle poll which resembles the functionality
found in arch/. Provide weak arch_cpu_idle_poll function which
can be overridden by the architecture code if needed.
Interrupts arrive which may not cause a reschedule in idle loops.
In KVM guest, this costs several VM-exit/VM-entry cycles, VM-entry
for interrupts and VM-exit immediately. Also this becomes more
expensive than bare metal. Add a generic idle poll before enter
real idle path. When a reschedule event is pending, we can bypass
the real idle path.
Signed-off-by: Quan Xu <quan.xu0@gmail.com>
Signed-off-by: Yang Zhang <yang.zhang.wz@gmail.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: x86@kernel.org
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Kyle Huey <me@kylehuey.com>
Cc: Len Brown <len.brown@intel.com>
Cc: Andy Lutomirski <luto@kernel.org>
Cc: Tom Lendacky <thomas.lendacky@amd.com>
Cc: Tobias Klauser <tklauser@distanz.ch>
Cc: linux-kernel@vger.kernel.org
---
arch/x86/kernel/process.c | 7 +++++++
kernel/sched/idle.c | 2 ++
2 files changed, 9 insertions(+), 0 deletions(-)
diff --git a/arch/x86/kernel/process.c b/arch/x86/kernel/process.c
index c676853..f7db8b5 100644
--- a/arch/x86/kernel/process.c
+++ b/arch/x86/kernel/process.c
@@ -333,6 +333,13 @@ void arch_cpu_idle(void)
x86_idle();
}
+#ifdef CONFIG_PARAVIRT
+void arch_cpu_idle_poll(void)
+{
+ paravirt_idle_poll();
+}
+#endif
+
/*
* We use this if we don't have any better idle routine..
*/
diff --git a/kernel/sched/idle.c b/kernel/sched/idle.c
index 257f4f0..df7c422 100644
--- a/kernel/sched/idle.c
+++ b/kernel/sched/idle.c
@@ -74,6 +74,7 @@ static noinline int __cpuidle cpu_idle_poll(void)
}
/* Weak implementations for optional arch specific functions */
+void __weak arch_cpu_idle_poll(void) { }
void __weak arch_cpu_idle_prepare(void) { }
void __weak arch_cpu_idle_enter(void) { }
void __weak arch_cpu_idle_exit(void) { }
@@ -219,6 +220,7 @@ static void do_idle(void)
*/
__current_set_polling();
+ arch_cpu_idle_poll();
quiet_vmstat();
tick_nohz_idle_enter();
--
1.7.1
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-11-13 10:06 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-13 10:05 [PATCH RFC v3 0/6] x86/idle: add halt poll support Quan Xu
2017-11-13 10:06 ` [PATCH RFC v3 1/6] x86/paravirt: Add pv_idle_ops to paravirt ops Quan Xu
2017-11-13 10:53 ` Juergen Gross
[not found] ` <07fac696-e3d4-8f35-8f3d-764d7ab41204@suse.com>
2017-11-13 11:09 ` Wanpeng Li
2017-11-14 7:02 ` Quan Xu
[not found] ` <902da704-1e4f-583b-91c3-1a62ccd6e73d@gmail.com>
2017-11-14 7:12 ` Wanpeng Li
2017-11-14 7:30 ` Juergen Gross
[not found] ` <CANRm+CxirO0aSAQnOfPG0+KPCOnXf3SEASwBiprLmtncZE53pA@mail.gmail.com>
2017-11-14 8:15 ` Quan Xu
[not found] ` <d233b179-9815-0134-ef04-c492f9523121@gmail.com>
2017-11-14 8:22 ` Wanpeng Li
[not found] ` <CANRm+Cycx3ewegOXR7c70kpdsaJA-=M5QztDt4J2L=VqpeCsfQ@mail.gmail.com>
2017-11-14 10:23 ` Quan Xu
[not found] ` <fe6eeed1-4eee-eaaa-df3b-8979af8a3891@suse.com>
2017-11-14 9:38 ` Quan Xu
[not found] ` <79dad15c-2d26-bcf3-7283-293e42a161ea@gmail.com>
2017-11-14 10:27 ` Juergen Gross
[not found] ` <9a4f53f3-225f-0e99-d9b2-d89656b8fb31@suse.com>
2017-11-14 11:43 ` Quan Xu
[not found] ` <41403bbb-bfa9-0618-abf7-dd871a7b783a@gmail.com>
2017-11-14 11:58 ` Juergen Gross
2017-11-13 10:06 ` [PATCH RFC v3 2/6] KVM guest: register kvm_idle_poll for pv_idle_ops Quan Xu
2017-11-13 10:06 ` Quan Xu [this message]
2017-11-15 12:11 ` [PATCH RFC v3 3/6] sched/idle: Add a generic poll before enter real idle path Peter Zijlstra
[not found] ` <20171115121152.gqug5wzerlo3eimd@hirez.programming.kicks-ass.net>
2017-11-15 22:03 ` Thomas Gleixner
[not found] ` <alpine.DEB.2.20.1711152240010.2146@nanos>
2017-11-16 8:45 ` Peter Zijlstra
[not found] ` <20171116084555.it2hqajxxd6ld5tq@hirez.programming.kicks-ass.net>
2017-11-16 8:58 ` Thomas Gleixner
2017-11-16 9:29 ` Quan Xu
[not found] ` <13a3a5c5-ec14-131f-fe6a-01700783de81@gmail.com>
2017-11-16 9:47 ` Thomas Gleixner
2017-11-16 9:12 ` Quan Xu
[not found] ` <46086489-5a01-16e1-9314-70ae53c01952@gmail.com>
2017-11-16 9:45 ` Daniel Lezcano
2017-11-16 9:53 ` Thomas Gleixner
[not found] ` <alpine.DEB.2.20.1711161048000.2191@nanos>
2017-11-17 11:23 ` Quan Xu
[not found] ` <564b8a6e-8ddd-4e3d-c670-10f1697e6c06@gmail.com>
2017-11-17 11:36 ` Thomas Gleixner
[not found] ` <alpine.DEB.2.20.1711171229100.7700@nanos>
2017-11-17 12:21 ` Quan Xu
[not found] ` <93a26005-aa37-82e1-5c04-a82c9027bac8@linaro.org>
2017-11-20 7:05 ` Quan Xu
[not found] ` <5deab1e9-cef2-0511-09d8-cef8e4323f02@gmail.com>
2017-11-20 18:01 ` Daniel Lezcano
2017-11-15 21:31 ` [PATCH RFC v3 0/6] x86/idle: add halt poll support Konrad Rzeszutek Wilk
[not found] ` <20171115213131.GB21113@char.us.oracle.com>
2017-11-20 7:18 ` Quan Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1510567565-5118-4-git-send-email-quan.xu0@gmail.com \
--to=quan.xu03@gmail.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=kvm@vger.kernel.org \
--cc=len.brown@intel.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=me@kylehuey.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=quan.xu0@gmail.com \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=tklauser@distanz.ch \
--cc=virtualization@lists.linux-foundation.org \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
--cc=yang.zhang.wz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).