* [PATCH 21/30] xen: deprecate pci_get_bus_and_slot()
[not found] <1511328675-21981-1-git-send-email-okaya@codeaurora.org>
@ 2017-11-22 5:31 ` Sinan Kaya
2017-11-22 12:53 ` Juergen Gross
0 siblings, 1 reply; 2+ messages in thread
From: Sinan Kaya @ 2017-11-22 5:31 UTC (permalink / raw)
To: linux-pci, timur
Cc: Juergen Gross, Konrad Rzeszutek Wilk, linux-arm-msm, open list,
Sinan Kaya, Bjorn Helgaas, moderated list:XEN PCI SUBSYSTEM,
Boris Ostrovsky, linux-arm-kernel
pci_get_bus_and_slot() is restrictive such that it assumes domain=0 as
where a PCI device is present. This restricts the device drivers to be
reused for other domain numbers.
Use pci_get_domain_bus_and_slot() with a domain number of 0 where we can't
extract the domain number. Other places, use the actual domain number from
the device.
Signed-off-by: Sinan Kaya <okaya@codeaurora.org>
---
drivers/pci/xen-pcifront.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/pci/xen-pcifront.c b/drivers/pci/xen-pcifront.c
index 8fc2e95..94b25b5 100644
--- a/drivers/pci/xen-pcifront.c
+++ b/drivers/pci/xen-pcifront.c
@@ -595,6 +595,7 @@ static pci_ers_result_t pcifront_common_process(int cmd,
struct pci_driver *pdrv;
int bus = pdev->sh_info->aer_op.bus;
int devfn = pdev->sh_info->aer_op.devfn;
+ int domain = pdev->sh_info->aer_op.domain;
struct pci_dev *pcidev;
int flag = 0;
@@ -603,7 +604,7 @@ static pci_ers_result_t pcifront_common_process(int cmd,
cmd, bus, devfn);
result = PCI_ERS_RESULT_NONE;
- pcidev = pci_get_bus_and_slot(bus, devfn);
+ pcidev = pci_get_domain_bus_and_slot(domain, bus, devfn);
if (!pcidev || !pcidev->driver) {
dev_err(&pdev->xdev->dev, "device or AER driver is NULL\n");
pci_dev_put(pcidev);
--
1.9.1
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 21/30] xen: deprecate pci_get_bus_and_slot()
2017-11-22 5:31 ` [PATCH 21/30] xen: deprecate pci_get_bus_and_slot() Sinan Kaya
@ 2017-11-22 12:53 ` Juergen Gross
0 siblings, 0 replies; 2+ messages in thread
From: Juergen Gross @ 2017-11-22 12:53 UTC (permalink / raw)
To: Sinan Kaya, linux-pci, timur
Cc: Konrad Rzeszutek Wilk, linux-arm-msm, open list, Bjorn Helgaas,
moderated list:XEN PCI SUBSYSTEM, Boris Ostrovsky,
linux-arm-kernel
On 22/11/17 06:31, Sinan Kaya wrote:
> pci_get_bus_and_slot() is restrictive such that it assumes domain=0 as
> where a PCI device is present. This restricts the device drivers to be
> reused for other domain numbers.
>
> Use pci_get_domain_bus_and_slot() with a domain number of 0 where we can't
> extract the domain number. Other places, use the actual domain number from
> the device.
>
> Signed-off-by: Sinan Kaya <okaya@codeaurora.org>
Reviewed-by: Juergen Gross <jgross@suse.com>
Juergen
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-11-22 12:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1511328675-21981-1-git-send-email-okaya@codeaurora.org>
2017-11-22 5:31 ` [PATCH 21/30] xen: deprecate pci_get_bus_and_slot() Sinan Kaya
2017-11-22 12:53 ` Juergen Gross
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).