xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] fixup! libxl: pvshim: Provide first-class config settings to enable shim mode
@ 2018-01-12 14:36 Ian Jackson
  0 siblings, 0 replies; 2+ messages in thread
From: Ian Jackson @ 2018-01-12 14:36 UTC (permalink / raw)
  To: xen-devel; +Cc: Wei Liu, Ian Jackson

Earlier versions of this patch have an erroneous hunk which will stop
PV guests from working at all!

Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
CC: Wei Liu <wei.liu2@citrix.com>
---
 tools/libxl/libxl_create.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/tools/libxl/libxl_create.c b/tools/libxl/libxl_create.c
index 278ad6a..1fa1d3a 100644
--- a/tools/libxl/libxl_create.c
+++ b/tools/libxl/libxl_create.c
@@ -488,6 +488,10 @@ int libxl__domain_build(libxl__gc *gc,
 
         break;
     case LIBXL_DOMAIN_TYPE_PV:
+        ret = libxl__build_pv(gc, domid, info, state);
+        if (ret)
+            goto out;
+
         vments = libxl__calloc(gc, 11, sizeof(char *));
         i = 0;
         vments[i++] = "image/ostype";
-- 
2.1.4


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [PATCH] fixup! libxl: pvshim: Provide first-class config settings to enable shim mode
  2018-01-12 11:29 [PATCH v2 59/62] " Wei Liu
@ 2018-01-12 14:45 ` Ian Jackson
  0 siblings, 0 replies; 2+ messages in thread
From: Ian Jackson @ 2018-01-12 14:45 UTC (permalink / raw)
  To: xen-devel; +Cc: Wei Liu, Ian Jackson

Earlier versions of this patch have an erroneous hunk which will stop
PV guests from working at all!

Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
CC: Wei Liu <wei.liu2@citrix.com>
---
 tools/libxl/libxl_create.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/tools/libxl/libxl_create.c b/tools/libxl/libxl_create.c
index 278ad6a..1fa1d3a 100644
--- a/tools/libxl/libxl_create.c
+++ b/tools/libxl/libxl_create.c
@@ -488,6 +488,10 @@ int libxl__domain_build(libxl__gc *gc,
 
         break;
     case LIBXL_DOMAIN_TYPE_PV:
+        ret = libxl__build_pv(gc, domid, info, state);
+        if (ret)
+            goto out;
+
         vments = libxl__calloc(gc, 11, sizeof(char *));
         i = 0;
         vments[i++] = "image/ostype";
-- 
2.1.4


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-01-12 14:46 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-12 14:36 [PATCH] fixup! libxl: pvshim: Provide first-class config settings to enable shim mode Ian Jackson
  -- strict thread matches above, loose matches on Subject: below --
2018-01-12 11:29 [PATCH v2 59/62] " Wei Liu
2018-01-12 14:45 ` [PATCH] fixup! " Ian Jackson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).