From: Luwei Kang <luwei.kang@intel.com>
To: xen-devel@lists.xen.org
Cc: kevin.tian@intel.com, sstabellini@kernel.org,
wei.liu2@citrix.com, jbeulich@suse.com,
George.Dunlap@eu.citrix.com, andrew.cooper3@citrix.com,
tim@xen.org, jun.nakajima@intel.com,
Luwei Kang <luwei.kang@intel.com>
Subject: [PATCH RESEND v1 6/7] x86: Implement Intel Processor Trace MSRs read/write
Date: Tue, 16 Jan 2018 02:12:32 +0800 [thread overview]
Message-ID: <1516039953-2988-7-git-send-email-luwei.kang@intel.com> (raw)
In-Reply-To: <1516039953-2988-1-git-send-email-luwei.kang@intel.com>
Intel PT MSRs read/write will not be intercepted when guest enabled
Intel PT. IA32_RTIT_CTL read/write will always cause a VM-Exit.
Signed-off-by: Luwei Kang <luwei.kang@intel.com>
---
xen/arch/x86/cpu/intel_pt.c | 101 +++++++++++++++++++++++++++++++++++++++++
xen/arch/x86/hvm/vmx/vmx.c | 18 ++++++++
xen/include/asm-x86/intel_pt.h | 4 ++
3 files changed, 123 insertions(+)
diff --git a/xen/arch/x86/cpu/intel_pt.c b/xen/arch/x86/cpu/intel_pt.c
index c0e9e68..d530e57 100644
--- a/xen/arch/x86/cpu/intel_pt.c
+++ b/xen/arch/x86/cpu/intel_pt.c
@@ -28,6 +28,107 @@
bool_t __read_mostly opt_intel_pt = 1;
boolean_param("intel_pt", opt_intel_pt);
+
+static void intel_pt_disable_intercept_for_msr(u32 addr_num)
+{
+ struct vcpu *v = current;
+ int i;
+
+ vmx_clear_msr_intercept(v, MSR_IA32_RTIT_STATUS, VMX_MSR_RW);
+ vmx_clear_msr_intercept(v, MSR_IA32_RTIT_OUTPUT_BASE, VMX_MSR_RW);
+ vmx_clear_msr_intercept(v, MSR_IA32_RTIT_OUTPUT_MASK, VMX_MSR_RW);
+ vmx_clear_msr_intercept(v, MSR_IA32_RTIT_CR3_MATCH, VMX_MSR_RW);
+ for ( i = 0; i < addr_num; i++ )
+ vmx_clear_msr_intercept(v, MSR_IA32_RTIT_ADDR0_A + i, VMX_MSR_RW);
+}
+
+static void intel_pt_enable_intercept_for_msr(u32 addr_num)
+{
+ struct vcpu *v = current;
+ int i;
+
+ vmx_set_msr_intercept(v, MSR_IA32_RTIT_STATUS, VMX_MSR_RW);
+ vmx_set_msr_intercept(v, MSR_IA32_RTIT_OUTPUT_BASE, VMX_MSR_RW);
+ vmx_set_msr_intercept(v, MSR_IA32_RTIT_OUTPUT_MASK, VMX_MSR_RW);
+ vmx_set_msr_intercept(v, MSR_IA32_RTIT_CR3_MATCH, VMX_MSR_RW);
+ for ( i = 0; i < addr_num; i++ )
+ vmx_set_msr_intercept(v, MSR_IA32_RTIT_ADDR0_A + i, VMX_MSR_RW);
+}
+
+void pt_set_rtit_ctl(struct pt_desc *pt_desc, uint64_t msr_content)
+{
+ if (msr_content & MSR_IA32_RTIT_CTL_TRACEEN)
+ intel_pt_disable_intercept_for_msr(pt_desc->addr_num);
+ else
+ intel_pt_enable_intercept_for_msr(pt_desc->addr_num);
+
+ pt_desc->guest_pt_ctx.ctl = msr_content;
+
+ vmx_vmcs_enter(current);
+ __vmwrite(GUEST_IA32_RTIT_CTL, msr_content);
+ vmx_vmcs_exit(current);
+}
+
+int pt_do_rdmsr(unsigned int msr, uint64_t *msr_content)
+{
+ struct pt_desc *pt_desc = ¤t->arch.hvm_vmx.pt_desc;
+
+ if ( !opt_intel_pt )
+ return 1;
+
+ switch ( msr ) {
+ case MSR_IA32_RTIT_CTL:
+ *msr_content = pt_desc->guest_pt_ctx.ctl;
+ break;
+ case MSR_IA32_RTIT_STATUS:
+ *msr_content = pt_desc->guest_pt_ctx.status;
+ break;
+ case MSR_IA32_RTIT_OUTPUT_BASE:
+ *msr_content = pt_desc->guest_pt_ctx.output_base;
+ break;
+ case MSR_IA32_RTIT_OUTPUT_MASK:
+ *msr_content = pt_desc->guest_pt_ctx.output_mask;
+ break;
+ case MSR_IA32_RTIT_CR3_MATCH:
+ *msr_content = pt_desc->guest_pt_ctx.cr3_match;
+ break;
+ default:
+ *msr_content = pt_desc->guest_pt_ctx.addr[msr - MSR_IA32_RTIT_ADDR0_A];
+ }
+
+ return 0;
+}
+
+int pt_do_wrmsr(unsigned int msr, uint64_t msr_content)
+{
+ struct pt_desc *pt_desc = ¤t->arch.hvm_vmx.pt_desc;
+
+ if ( !opt_intel_pt )
+ return 1;
+
+ switch ( msr ) {
+ case MSR_IA32_RTIT_CTL:
+ pt_set_rtit_ctl(pt_desc, msr_content);
+ break;
+ case MSR_IA32_RTIT_STATUS:
+ pt_desc->guest_pt_ctx.status = msr_content;
+ break;
+ case MSR_IA32_RTIT_OUTPUT_BASE:
+ pt_desc->guest_pt_ctx.output_base = msr_content;
+ break;
+ case MSR_IA32_RTIT_OUTPUT_MASK:
+ pt_desc->guest_pt_ctx.output_mask = msr_content | 0x7F;
+ break;
+ case MSR_IA32_RTIT_CR3_MATCH:
+ pt_desc->guest_pt_ctx.cr3_match = msr_content;
+ break;
+ default:
+ pt_desc->guest_pt_ctx.addr[msr - MSR_IA32_RTIT_ADDR0_A] = msr_content;
+ }
+
+ return 0;
+}
+
static inline void pt_load_msr(struct pt_ctx *ctx, u32 addr_num)
{
u32 i;
diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c
index f386933..e6713fd 100644
--- a/xen/arch/x86/hvm/vmx/vmx.c
+++ b/xen/arch/x86/hvm/vmx/vmx.c
@@ -2929,6 +2929,15 @@ static int vmx_msr_read_intercept(unsigned int msr, uint64_t *msr_content)
if ( vpmu_do_rdmsr(msr, msr_content) )
goto gp_fault;
break;
+ case MSR_IA32_RTIT_CTL:
+ case MSR_IA32_RTIT_STATUS:
+ case MSR_IA32_RTIT_OUTPUT_BASE:
+ case MSR_IA32_RTIT_OUTPUT_MASK:
+ case MSR_IA32_RTIT_CR3_MATCH:
+ case MSR_IA32_RTIT_ADDR0_A ... MSR_IA32_RTIT_ADDR3_B:
+ if ( pt_do_rdmsr(msr, msr_content) )
+ goto gp_fault;
+ break;
default:
if ( passive_domain_do_rdmsr(msr, msr_content) )
@@ -3149,6 +3158,15 @@ static int vmx_msr_write_intercept(unsigned int msr, uint64_t msr_content)
if ( vpmu_do_wrmsr(msr, msr_content, 0) )
goto gp_fault;
break;
+ case MSR_IA32_RTIT_CTL:
+ case MSR_IA32_RTIT_STATUS:
+ case MSR_IA32_RTIT_OUTPUT_BASE:
+ case MSR_IA32_RTIT_OUTPUT_MASK:
+ case MSR_IA32_RTIT_CR3_MATCH:
+ case MSR_IA32_RTIT_ADDR0_A ... MSR_IA32_RTIT_ADDR3_B:
+ if ( pt_do_wrmsr(msr, msr_content) )
+ goto gp_fault;
+ break;
default:
if ( passive_domain_do_wrmsr(msr, msr_content) )
diff --git a/xen/include/asm-x86/intel_pt.h b/xen/include/asm-x86/intel_pt.h
index 9505c8f..5d51a12 100644
--- a/xen/include/asm-x86/intel_pt.h
+++ b/xen/include/asm-x86/intel_pt.h
@@ -40,6 +40,10 @@ struct pt_desc {
extern bool_t opt_intel_pt;
+int pt_do_rdmsr(unsigned int msr, uint64_t *pdata);
+int pt_do_wrmsr(unsigned int msr, uint64_t data);
+void pt_set_rtit_ctl(struct pt_desc *pt_desc, uint64_t msr_content);
+
void pt_vcpu_init(struct vcpu *v);
void pt_guest_enter(struct vcpu *v);
void pt_guest_exit(struct vcpu *v);
--
1.8.3.1
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-01-15 18:12 UTC|newest]
Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-15 18:12 [PATCH RESEND v1 0/7] Intel Processor Trace virtulization enabling Luwei Kang
2018-01-15 18:12 ` [PATCH RESEND v1 1/7] x86: add a flag to enable Intel processor trace Luwei Kang
2018-03-09 16:53 ` Wei Liu
2018-03-12 9:25 ` Kang, Luwei
2018-04-26 12:09 ` Wei Liu
2018-04-27 8:22 ` Kang, Luwei
2018-04-27 8:32 ` Wei Liu
2018-04-27 13:03 ` Jan Beulich
2018-04-27 23:16 ` Kang, Luwei
2018-04-26 12:29 ` Jan Beulich
2018-04-27 9:01 ` Kang, Luwei
2018-04-27 12:15 ` Jan Beulich
2018-04-27 23:18 ` Kang, Luwei
2018-01-15 18:12 ` [PATCH RESEND v1 2/7] x86: configure vmcs for Intel processor trace virtualization Luwei Kang
2018-04-26 12:34 ` Jan Beulich
2018-04-28 1:07 ` Kang, Luwei
2018-04-30 7:42 ` Jan Beulich
2018-05-02 7:22 ` Kang, Luwei
2018-05-02 9:09 ` Jan Beulich
2018-05-02 9:22 ` Kang, Luwei
2018-01-15 18:12 ` [PATCH RESEND v1 3/7] x86: add intel proecessor trace support for cpuid Luwei Kang
2018-04-30 15:43 ` Konrad Rzeszutek Wilk
2018-05-02 7:32 ` Kang, Luwei
2018-01-15 18:12 ` [PATCH RESEND v1 4/7] x86: add intel processor trace context Luwei Kang
2018-04-26 12:11 ` Wei Liu
2018-04-26 12:59 ` Jan Beulich
2018-04-28 1:26 ` Kang, Luwei
2018-01-15 18:12 ` [PATCH RESEND v1 5/7] x86: Implement Intel Processor Trace context switch Luwei Kang
2018-04-26 12:11 ` Wei Liu
2018-04-27 8:53 ` Kang, Luwei
2018-05-02 15:19 ` Wei Liu
2018-05-02 15:43 ` Jan Beulich
2018-05-02 16:15 ` Wei Liu
2018-05-02 16:51 ` Andrew Cooper
2018-05-03 7:27 ` Jan Beulich
2018-05-03 7:26 ` Jan Beulich
2018-05-03 7:51 ` Wei Liu
2018-04-26 13:12 ` Jan Beulich
2018-04-28 2:56 ` Kang, Luwei
2018-01-15 18:12 ` Luwei Kang [this message]
2018-04-26 13:20 ` [PATCH RESEND v1 6/7] x86: Implement Intel Processor Trace MSRs read/write Jan Beulich
2018-04-27 12:26 ` Jan Beulich
2018-05-03 5:22 ` Kang, Luwei
2018-05-03 7:33 ` Jan Beulich
2018-05-03 9:40 ` Kang, Luwei
2018-05-03 11:36 ` Jan Beulich
2018-05-04 3:53 ` Kang, Luwei
2018-05-04 12:06 ` Jan Beulich
2018-05-10 9:06 ` Kang, Luwei
2018-01-15 18:12 ` [PATCH RESEND v1 7/7] x86: Disable Intel Processor Trace when VMXON in L1 guest Luwei Kang
2018-01-16 8:41 ` [PATCH RESEND v1 0/7] Intel Processor Trace virtulization enabling Jan Beulich
2018-01-16 9:02 ` Kang, Luwei
2018-01-16 9:30 ` Jan Beulich
2018-01-16 9:45 ` Kang, Luwei
2018-04-26 12:12 ` Wei Liu
2018-05-03 4:06 ` Kang, Luwei
2018-05-03 5:55 ` Razvan Cojocaru
2018-05-03 8:06 ` Wei Liu
2018-05-04 4:10 ` Kang, Luwei
2018-05-03 9:49 ` Kang, Luwei
2018-05-03 10:01 ` Andrew Cooper
2018-05-04 3:08 ` Kang, Luwei
2018-05-10 9:26 ` Kang, Luwei
2018-05-10 9:56 ` Andrew Cooper
2018-05-15 2:50 ` Kang, Luwei
2018-04-30 15:42 ` Konrad Rzeszutek Wilk
2018-05-02 7:27 ` Kang, Luwei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1516039953-2988-7-git-send-email-luwei.kang@intel.com \
--to=luwei.kang@intel.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=jbeulich@suse.com \
--cc=jun.nakajima@intel.com \
--cc=kevin.tian@intel.com \
--cc=sstabellini@kernel.org \
--cc=tim@xen.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).