xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Luwei Kang <luwei.kang@intel.com>
To: xen-devel@lists.xen.org
Cc: kevin.tian@intel.com, sstabellini@kernel.org,
	wei.liu2@citrix.com, jbeulich@suse.com,
	George.Dunlap@eu.citrix.com, andrew.cooper3@citrix.com,
	tim@xen.org, jun.nakajima@intel.com,
	Luwei Kang <luwei.kang@intel.com>
Subject: [PATCH RESEND v1 7/7] x86: Disable Intel Processor Trace when VMXON in L1 guest
Date: Tue, 16 Jan 2018 02:12:33 +0800	[thread overview]
Message-ID: <1516039953-2988-8-git-send-email-luwei.kang@intel.com> (raw)
In-Reply-To: <1516039953-2988-1-git-send-email-luwei.kang@intel.com>

Disable intel Processor Trace VMX operation(IA32_VMX_MISC[bit 14] is 0)
in L1 guest. As mentioned in SDM, on these type of processors, execution
of the VMXON instruction will  clears IA32_RTIT_CTL.TraceEn and any
attempt to write IA32_RTIT_CTL causes a general-protection xception (#GP).

Signed-off-by: Luwei Kang <luwei.kang@intel.com>
---
 xen/arch/x86/hvm/vmx/vvmx.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/xen/arch/x86/hvm/vmx/vvmx.c b/xen/arch/x86/hvm/vmx/vvmx.c
index 885eab3..86ccfda 100644
--- a/xen/arch/x86/hvm/vmx/vvmx.c
+++ b/xen/arch/x86/hvm/vmx/vvmx.c
@@ -1516,6 +1516,9 @@ int nvmx_handle_vmxon(struct cpu_user_regs *regs)
     v->arch.hvm_vmx.launched = 0;
     vmsucceed(regs);
 
+    if ( v->arch.hvm_vmx.pt_desc.intel_pt_enabled )
+        pt_set_rtit_ctl(&v->arch.hvm_vmx.pt_desc, 0);
+
     return X86EMUL_OKAY;
 }
 
@@ -2140,8 +2143,8 @@ int nvmx_msr_read_intercept(unsigned int msr, u64 *msr_content)
         data = hvm_cr4_guest_valid_bits(v, 0);
         break;
     case MSR_IA32_VMX_MISC:
-        /* Do not support CR3-target feature now */
-        data = host_data & ~VMX_MISC_CR3_TARGET;
+        /* Do not support CR3-target and PT VMX feature now */
+        data = host_data & ~(VMX_MISC_CR3_TARGET | VMX_MISC_PT_ENABLE);
         break;
     case MSR_IA32_VMX_EPT_VPID_CAP:
         data = nept_get_ept_vpid_cap();
-- 
1.8.3.1


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

  parent reply	other threads:[~2018-01-15 18:12 UTC|newest]

Thread overview: 67+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-15 18:12 [PATCH RESEND v1 0/7] Intel Processor Trace virtulization enabling Luwei Kang
2018-01-15 18:12 ` [PATCH RESEND v1 1/7] x86: add a flag to enable Intel processor trace Luwei Kang
2018-03-09 16:53   ` Wei Liu
2018-03-12  9:25     ` Kang, Luwei
2018-04-26 12:09   ` Wei Liu
2018-04-27  8:22     ` Kang, Luwei
2018-04-27  8:32       ` Wei Liu
2018-04-27 13:03       ` Jan Beulich
2018-04-27 23:16         ` Kang, Luwei
2018-04-26 12:29   ` Jan Beulich
2018-04-27  9:01     ` Kang, Luwei
2018-04-27 12:15       ` Jan Beulich
2018-04-27 23:18         ` Kang, Luwei
2018-01-15 18:12 ` [PATCH RESEND v1 2/7] x86: configure vmcs for Intel processor trace virtualization Luwei Kang
2018-04-26 12:34   ` Jan Beulich
2018-04-28  1:07     ` Kang, Luwei
2018-04-30  7:42       ` Jan Beulich
2018-05-02  7:22         ` Kang, Luwei
2018-05-02  9:09           ` Jan Beulich
2018-05-02  9:22             ` Kang, Luwei
2018-01-15 18:12 ` [PATCH RESEND v1 3/7] x86: add intel proecessor trace support for cpuid Luwei Kang
2018-04-30 15:43   ` Konrad Rzeszutek Wilk
2018-05-02  7:32     ` Kang, Luwei
2018-01-15 18:12 ` [PATCH RESEND v1 4/7] x86: add intel processor trace context Luwei Kang
2018-04-26 12:11   ` Wei Liu
2018-04-26 12:59   ` Jan Beulich
2018-04-28  1:26     ` Kang, Luwei
2018-01-15 18:12 ` [PATCH RESEND v1 5/7] x86: Implement Intel Processor Trace context switch Luwei Kang
2018-04-26 12:11   ` Wei Liu
2018-04-27  8:53     ` Kang, Luwei
2018-05-02 15:19       ` Wei Liu
2018-05-02 15:43         ` Jan Beulich
2018-05-02 16:15           ` Wei Liu
2018-05-02 16:51             ` Andrew Cooper
2018-05-03  7:27               ` Jan Beulich
2018-05-03  7:26             ` Jan Beulich
2018-05-03  7:51               ` Wei Liu
2018-04-26 13:12   ` Jan Beulich
2018-04-28  2:56     ` Kang, Luwei
2018-01-15 18:12 ` [PATCH RESEND v1 6/7] x86: Implement Intel Processor Trace MSRs read/write Luwei Kang
2018-04-26 13:20   ` Jan Beulich
2018-04-27 12:26   ` Jan Beulich
2018-05-03  5:22     ` Kang, Luwei
2018-05-03  7:33       ` Jan Beulich
2018-05-03  9:40         ` Kang, Luwei
2018-05-03 11:36           ` Jan Beulich
2018-05-04  3:53             ` Kang, Luwei
2018-05-04 12:06               ` Jan Beulich
2018-05-10  9:06                 ` Kang, Luwei
2018-01-15 18:12 ` Luwei Kang [this message]
2018-01-16  8:41 ` [PATCH RESEND v1 0/7] Intel Processor Trace virtulization enabling Jan Beulich
2018-01-16  9:02   ` Kang, Luwei
2018-01-16  9:30     ` Jan Beulich
2018-01-16  9:45       ` Kang, Luwei
2018-04-26 12:12 ` Wei Liu
2018-05-03  4:06   ` Kang, Luwei
2018-05-03  5:55     ` Razvan Cojocaru
2018-05-03  8:06     ` Wei Liu
2018-05-04  4:10       ` Kang, Luwei
2018-05-03  9:49   ` Kang, Luwei
2018-05-03 10:01     ` Andrew Cooper
2018-05-04  3:08       ` Kang, Luwei
2018-05-10  9:26       ` Kang, Luwei
2018-05-10  9:56         ` Andrew Cooper
2018-05-15  2:50           ` Kang, Luwei
2018-04-30 15:42 ` Konrad Rzeszutek Wilk
2018-05-02  7:27   ` Kang, Luwei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1516039953-2988-8-git-send-email-luwei.kang@intel.com \
    --to=luwei.kang@intel.com \
    --cc=George.Dunlap@eu.citrix.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=jbeulich@suse.com \
    --cc=jun.nakajima@intel.com \
    --cc=kevin.tian@intel.com \
    --cc=sstabellini@kernel.org \
    --cc=tim@xen.org \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).