xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Ian Jackson <ian.jackson@eu.citrix.com>
To: xen-devel@lists.xenproject.org
Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>
Subject: [OSSTEST PATCH 2/2] mg-hosts: Call db_readonly_report inside, not outside, db_retry
Date: Mon, 29 Jan 2018 17:29:07 +0000	[thread overview]
Message-ID: <1517246947-24154-2-git-send-email-ian.jackson@eu.citrix.com> (raw)
In-Reply-To: <1517246947-24154-1-git-send-email-ian.jackson@eu.citrix.com>

Newer postgresql prints:
  WARNING:  SET TRANSACTION can only be used in transaction blocks
and it is right.

Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
---
 mg-force-push | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mg-force-push b/mg-force-push
index 09c1894..1066a30 100755
--- a/mg-force-push
+++ b/mg-force-push
@@ -62,8 +62,8 @@ END
     my %revuses;
     printf "checking revisions used in %s...\n", $flight;
 
-    db_readonly_report();
     db_retry($dbh_tests, [], sub {
+        db_readonly_report();
         $flt_q->execute($flight);
         my $flt_row = $flt_q->fetchrow_hashref();
         $flt_row->{blessing} eq 'real' or die "$flt_row->{blessing} ?";
-- 
2.1.4


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

      reply	other threads:[~2018-01-29 17:29 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-29 17:29 [OSSTEST PATCH 1/2] mg-force-push: unshift . onto @INC Ian Jackson
2018-01-29 17:29 ` Ian Jackson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1517246947-24154-2-git-send-email-ian.jackson@eu.citrix.com \
    --to=ian.jackson@eu.citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).