From: Sergey Dyasli <sergey.dyasli@citrix.com>
To: Roger Pau Monne <roger.pau@citrix.com>
Cc: Sergey Dyasli <sergey.dyasli@citrix.com>,
Andrew Cooper <Andrew.Cooper3@citrix.com>,
"jbeulich@suse.com" <jbeulich@suse.com>,
"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: [PATCH v1] x86/msr: add Raw and Host domain policies
Date: Thu, 8 Feb 2018 11:29:48 +0000 [thread overview]
Message-ID: <1518089388.3287.1.camel@citrix.com> (raw)
In-Reply-To: <20180208112131.yq6ls6diw7azwrj5@MacBook-Pro-de-Roger.local>
On Thu, 2018-02-08 at 11:21 +0000, Roger Pau Monné wrote:
> On Thu, Feb 08, 2018 at 10:23:21AM +0000, Sergey Dyasli wrote:
> > +static void __init calculate_host_policy(void)
> > +{
> > + struct msr_domain_policy *dp = &host_msr_domain_policy;
> > +
> > + *dp = raw_msr_domain_policy;
>
> host_msr_domain_policy = raw_msr_domain_policy;
>
> Should work AFAICT.
This is a template for the future. The code with *dp is much shorter
than with host_msr_domain_policy.
>
> > diff --git a/xen/include/asm-x86/msr.h b/xen/include/asm-x86/msr.h
> > index 928f1cc454..8401d376c3 100644
> > --- a/xen/include/asm-x86/msr.h
> > +++ b/xen/include/asm-x86/msr.h
> > @@ -220,6 +220,14 @@ struct msr_domain_policy
> > } plaform_info;
> > };
> >
> > +/* RAW msr domain policy: contains the actual values from H/W MSRs */
> > +extern msr_domain_policy raw_msr_domain_policy;
> > +/*
> > + * HOST msr domain policy: features that Xen actually decided to use,
> > + * a subset of RAW policy.
> > + */
> > +extern msr_domain_policy host_msr_domain_policy;
>
> Aren't you missing a 'struct' here? I don't see any typedef for struct
> msr_domain_policy.
I don't know how I missed this. You are right, 'struct' is mandatory.
--
Thanks,
Sergey
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-02-08 11:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-08 10:23 [PATCH v1] x86/msr: add Raw and Host domain policies Sergey Dyasli
2018-02-08 11:08 ` Andrew Cooper
2018-02-08 11:21 ` Roger Pau Monné
2018-02-08 11:29 ` Sergey Dyasli [this message]
2018-02-15 13:33 ` Jan Beulich
2018-02-16 10:33 ` Sergey Dyasli
2018-02-16 11:06 ` Jan Beulich
2018-02-16 11:31 ` Sergey Dyasli
2018-02-16 11:37 ` Jan Beulich
2018-02-16 11:38 ` Andrew Cooper
2018-02-16 16:00 ` Sergey Dyasli
2018-02-16 16:02 ` Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1518089388.3287.1.camel@citrix.com \
--to=sergey.dyasli@citrix.com \
--cc=Andrew.Cooper3@citrix.com \
--cc=jbeulich@suse.com \
--cc=roger.pau@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).