From: Dario Faggioli <dfaggioli@suse.com>
To: Michael Young <m.a.young@durham.ac.uk>, xen-devel@lists.xenproject.org
Cc: Marcello Seri <marcello.seri@citrix.com>,
Wei Liu <wei.liu2@citrix.com>,
Christian Lindig <christian.lindig@citrix.com>,
John Thomson <git@johnthomson.fastmail.com.au>,
David Scott <dave@recoil.org>
Subject: Re: [PATCH 1/2] make xen ocaml safe-strings compliant
Date: Thu, 08 Feb 2018 18:49:58 +0100 [thread overview]
Message-ID: <1518112198.5629.68.camel@suse.com> (raw)
In-Reply-To: <alpine.LFD.2.21.1801302254440.2952@austen3.home>
[-- Attachment #1.1: Type: text/plain, Size: 1576 bytes --]
On Tue, 2018-01-30 at 22:55 +0000, Michael Young wrote:
> Xen built with ocaml 4.06 gives errors such as
> Error: This expression has type bytes but an expression was
> expected of type string
> as Byte and safe-strings which were introduced in 4.02 are the
> default in 4.06.
> This patch which is partly by Richard W.M. Jones of Red Hat
> from https://bugzilla.redhat.com/show_bug.cgi?id=1526703
> fixes these issues.
>
> Signed-off-by: Michael Young <m.a.young@durham.ac.uk>
> Reviewed-by: Christian Lindig <christian.lindig@citrix.com>
>
So, with this patch, oxenstord does not start for me.
Systemd says this (sorry, it's not the full output.. I don't have it
right now, but can produce it):
systemctl status xenstored
...
Active: failed (Result: protocol) since Thu 2018-02-08 17:47:56 CET; 12min ago
...
Feb 08 17:47:56 Zhaman systemd[1]: xenstored.service: Failed with result 'protocol'.
Just running oxenstored from command line seems to exits with 0, but
there's not an oxenstored process running.
Getting rid of what is now commit "make xen ocaml safe-strings
compliant" (df1e4c6e7f8892e950433ff33c215df0cd7b30f7), things work
again for me.
Regards,
Dario
PS. There has been a v2 of this patch, I think, but I don't have in my
emails any longer, so I'm replying to this one.
--
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Software Engineer @ SUSE https://www.suse.com/
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 157 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-02-08 17:50 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-30 22:55 [PATCH 1/2] make xen ocaml safe-strings compliant Michael Young
2018-02-06 16:49 ` Wei Liu
2018-02-06 21:56 ` Michael Young
2018-02-07 10:31 ` Wei Liu
2018-02-08 17:49 ` Dario Faggioli [this message]
2018-02-08 18:03 ` Wei Liu
2018-02-08 18:24 ` Wei Liu
2018-02-09 9:20 ` Christian Lindig
2018-02-09 10:06 ` Dario Faggioli
2018-02-12 14:55 ` Wei Liu
2018-03-09 22:57 ` Michael Young
2018-03-09 23:47 ` Christian Lindig
2018-03-10 0:36 ` Michael Young
2018-03-12 11:29 ` Christian Lindig
2018-03-12 19:35 ` Michael Young
2018-03-13 9:29 ` Christian Lindig
2018-03-13 14:49 ` Wei Liu
2018-02-13 0:35 ` Michael Young
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1518112198.5629.68.camel@suse.com \
--to=dfaggioli@suse.com \
--cc=christian.lindig@citrix.com \
--cc=dave@recoil.org \
--cc=git@johnthomson.fastmail.com.au \
--cc=m.a.young@durham.ac.uk \
--cc=marcello.seri@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).