From: Alexandru Stefan ISAILA <aisaila@bitdefender.com>
To: "dunlapg@umich.edu" <dunlapg@umich.edu>
Cc: "tamas@tklengyel.com" <tamas@tklengyel.com>,
"suravee.suthikulpanit@amd.com" <suravee.suthikulpanit@amd.com>,
"rcojocaru@bitdefender.com" <rcojocaru@bitdefender.com>,
"andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>,
"jbeulich@suse.com" <jbeulich@suse.com>,
"boris.ostrovsky@oracle.com" <boris.ostrovsky@oracle.com>
Subject: Re: [PATCH v2 3/4] hvm/svm: Enable MSR events
Date: Fri, 9 Feb 2018 11:03:24 +0000 [thread overview]
Message-ID: <1518174204.4963.2.camel@bitdefender.com> (raw)
In-Reply-To: <CAFLBxZYrbn4E_8YW8JZT9XfgD28B=wf9xAG-O0zHPTCUHp6jog@mail.gmail.com>
On Vi, 2018-02-09 at 10:37 +0000, George Dunlap wrote:
> On Thu, Feb 8, 2018 at 3:25 PM, Alexandru Isaila
> <aisaila@bitdefender.com> wrote:
> >
> > This commit enables MSR events for svm.
> I'd probably say 'implement' here as well.
>
> Also, you don't need to repeat the title in the commit message. If
> there's nothing more to put into the commit message than is said in
> the title, you can just include your SoB. (Contrariwise, if you feel
> like you need something in the commit message, it should be more than
> just repeating the title of the patch.)
>
> -George
>
Thanks for the heads up. I will remember this for future
contributions.
Alex
________________________
This email was scanned by Bitdefender
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-02-09 11:03 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-08 15:25 [PATCH v2 0/4] hvm/svm: Enable vm events for SVM Alexandru Isaila
2018-02-08 15:25 ` [PATCH v2 1/4] asm-x86/monitor: Enable svm monitor events Alexandru Isaila
2018-02-08 18:00 ` Tamas K Lengyel
2018-02-09 10:28 ` George Dunlap
2018-02-09 10:54 ` George Dunlap
2018-02-09 16:21 ` Tamas K Lengyel
2018-02-21 11:50 ` George Dunlap
2018-02-10 16:30 ` Boris Ostrovsky
2018-02-10 19:51 ` Boris Ostrovsky
2018-02-08 15:25 ` [PATCH v2 2/4] hvm/svm: Enable Breakpoint events Alexandru Isaila
2018-02-08 18:03 ` Tamas K Lengyel
2018-02-09 10:31 ` George Dunlap
2018-02-10 16:31 ` Boris Ostrovsky
2018-02-08 15:25 ` [PATCH v2 3/4] hvm/svm: Enable MSR events Alexandru Isaila
2018-02-08 18:04 ` Tamas K Lengyel
2018-02-09 10:37 ` George Dunlap
2018-02-09 11:03 ` Alexandru Stefan ISAILA [this message]
2018-02-10 16:33 ` Boris Ostrovsky
2018-02-10 20:26 ` Boris Ostrovsky
2018-02-08 15:25 ` [PATCH v2 4/4] hvm/svm: Enable CR events Alexandru Isaila
2018-02-08 18:06 ` Tamas K Lengyel
2018-02-09 13:10 ` Alexandru Stefan ISAILA
2018-02-09 16:24 ` Tamas K Lengyel
2018-02-09 16:41 ` George Dunlap
2018-02-09 16:25 ` Tamas K Lengyel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1518174204.4963.2.camel@bitdefender.com \
--to=aisaila@bitdefender.com \
--cc=andrew.cooper3@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=dunlapg@umich.edu \
--cc=jbeulich@suse.com \
--cc=rcojocaru@bitdefender.com \
--cc=suravee.suthikulpanit@amd.com \
--cc=tamas@tklengyel.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).