From: Bruno Alvisio <bruno.alvisio@gmail.com>
To: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org
Cc: jgross@suse.com, samuel.thibault@ens-lyon.org, wei.liu2@citrix.com
Subject: [PATCH v2 01/17] Save/Restore Support: Refactor HYPERVISOR_suspend hypercall
Date: Tue, 13 Feb 2018 18:25:45 -0800 [thread overview]
Message-ID: <1518575161-70717-2-git-send-email-bruno.alvisio@gmail.com> (raw)
In-Reply-To: <1518575161-70717-1-git-send-email-bruno.alvisio@gmail.com>
Directly using the SHUTDOWN_suspend macro as a parameter for the schedop
hypercall causes an error in the Xen hypercall handler. Also for consistency,
the SHUTDOWN_suspend param is wrapped in the sched_shutdown struct.
Signed-off-by: Bruno Alvisio <bruno.alvisio@gmail.com>
Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
---
include/x86/x86_32/hypercall-x86_32.h | 4 ++--
include/x86/x86_64/hypercall-x86_64.h | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/include/x86/x86_32/hypercall-x86_32.h b/include/x86/x86_32/hypercall-x86_32.h
index 5c93464..70505a4 100644
--- a/include/x86/x86_32/hypercall-x86_32.h
+++ b/include/x86/x86_32/hypercall-x86_32.h
@@ -298,8 +298,8 @@ static inline int
HYPERVISOR_suspend(
unsigned long srec)
{
- return _hypercall3(int, sched_op, SCHEDOP_shutdown,
- SHUTDOWN_suspend, srec);
+ struct sched_shutdown shutdown = { .reason = SHUTDOWN_suspend };
+ return _hypercall3(int, sched_op, SCHEDOP_shutdown, &shutdown, srec);
}
static inline int
diff --git a/include/x86/x86_64/hypercall-x86_64.h b/include/x86/x86_64/hypercall-x86_64.h
index 6171812..95f8ade 100644
--- a/include/x86/x86_64/hypercall-x86_64.h
+++ b/include/x86/x86_64/hypercall-x86_64.h
@@ -305,8 +305,8 @@ static inline int
HYPERVISOR_suspend(
unsigned long srec)
{
- return _hypercall3(int, sched_op, SCHEDOP_shutdown,
- SHUTDOWN_suspend, srec);
+ struct sched_shutdown shutdown = { .reason = SHUTDOWN_suspend };
+ return _hypercall3(int, sched_op, SCHEDOP_shutdown, &shutdown, srec);
}
static inline int
--
2.3.2 (Apple Git-55)
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-02-14 2:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-14 2:25 [PATCH v2 00/16] Save/Restore Support for mini-OS PVH Bruno Alvisio
2018-02-14 2:25 ` Bruno Alvisio [this message]
2018-02-14 2:25 ` [PATCH v2 02/17] Save/Restore Support: Refactor trap_init() and setup vector callbacks Bruno Alvisio
2018-02-14 2:25 ` [PATCH v2 03/17] Save/Restore Support: Declare kernel and arch pre/post suspend functions Bruno Alvisio
2018-02-14 2:25 ` [PATCH v2 04/17] Save/Restore Support: Add xenbus_release_wait_for_watch Bruno Alvisio
2018-02-14 2:25 ` [PATCH v2 05/17] Save/Restore Support: Add kernel shutdown logic to shutdown.c Bruno Alvisio
2018-02-14 2:25 ` [PATCH v2 06/17] Save/Restore Support: Moved shutdown thread " Bruno Alvisio
2018-02-14 2:25 ` [PATCH v2 07/17] Save/Restore Support: Add unmap_shared_info Bruno Alvisio
2018-02-14 2:25 ` [PATCH v2 08/17] Save/Restore Support: Add arch_mm_pre|post_suspend Bruno Alvisio
2018-02-14 2:25 ` [PATCH v2 09/17] Save/Restore Support: Disable/enable IRQs during suspend/restore Bruno Alvisio
2018-02-14 2:25 ` [PATCH v2 10/17] Save/Restore Support: Add suspend/resume support for timers Bruno Alvisio
2018-02-14 2:25 ` [PATCH v2 11/17] Save/Restore Support: Add suspend/restore support for console Bruno Alvisio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1518575161-70717-2-git-send-email-bruno.alvisio@gmail.com \
--to=bruno.alvisio@gmail.com \
--cc=jgross@suse.com \
--cc=minios-devel@lists.xenproject.org \
--cc=samuel.thibault@ens-lyon.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).