From: Dario Faggioli <dfaggioli@suse.com>
To: xen-devel@lists.xenproject.org
Cc: Juergen Gross <jgross@suse.com>,
Stefano Stabellini <sstabellini@kernel.org>,
Wei Liu <wei.liu2@citrix.com>,
George Dunlap <george.dunlap@eu.citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>, Tim Deegan <tim@xen.org>,
Jan Beulich <jbeulich@suse.com>
Subject: [PATCH 0/5] xen/tools: sched: Credit1: improve handling of vCPU migration delay
Date: Thu, 22 Feb 2018 17:54:55 +0100 [thread overview]
Message-ID: <151931759370.5408.3600378338263227885.stgit@Solace.fritz.box> (raw)
Hi,
vCPU migration delay is a parameter of the Credit1 scheduler specifying for how
long, after a vCPU stopped running on a particular pCPU, the cache(s) should be
considered "hot" for the vCPU's working set. Basically, if less than the value
set for such parameter (in microseconds) passed, the vCPU is not considered a
candidate for migration on another pCPU.
Right now, the parameter is set at boot, or through the PMOPS sysctl (!!!)
used, e.g., by xenpm. The value, once set, is effective for *all* the instances
of the Credit1 scheduler, in any cpupool that exists already, or that will ever
be created. But the really bad thing is that building Xen without Credit1
support (CONFIG_SCHED_CREDIT=n, it can happen, e.g., when doing randconfig),
currently, fails.
Instead of "just" fixing the build breakage (e.g., with #ifdef-s), this series
does the following:
- makes the migration delay a per-scheduler (== per-cpupool) parameter,
- makes it possible to get/set the parameter via the SCHEDOP sysctl, where it
belongs (it's a _scheduling_ parameter, not a power management one).
Note that, with the series applied, `xenpm {get,set}-vcpu-migration-delay'
commands continue to work, for backward compatibility. In fact, they are
re-implemented via SCHEDOP, and a deprecation warning message is added.
The series is available as a branch here:
git://xenbits.xen.org/people/dariof/xen.git rel/sched/credit/vcpu_migr_delay_percpool
or here:
https://github.com/fdario/xen/tree/rel/sched/credit/vcpu_migr_delay_percpool
Travis is red, but that seems to me to be related to ARM infra issues, rather
than to problem with the series itself:
https://travis-ci.org/fdario/xen/builds/344835704
Regards,
Dario
---
Dario Faggioli (5):
xen: sched/credit: convert scheduling parameter to s_time_t when set
xen: sched/credit1: make vcpu_migration_delay per-cpupool
tools: libxl/xl: allow to get/set Credit1's vcpu_migration_delay
tools: xenpm: continue to support {set,get}-vcpu-migration-delay
xen/libxc: suppress direct access to Credit1's migration delay
docs/man/xl.pod.1.in | 11 ++++
tools/libxc/include/xenctrl.h | 2 -
tools/libxc/xc_pm.c | 30 ------------
tools/libxl/libxl.h | 7 +++
tools/libxl/libxl_sched.c | 10 ++++
tools/libxl/libxl_types.idl | 1
tools/misc/xenpm.c | 22 +++++++--
tools/xl/xl_cmdtable.c | 1
tools/xl/xl_sched.c | 22 ++++++---
xen/common/sched_credit.c | 102 +++++++++++++++++++++--------------------
xen/drivers/acpi/pmstat.c | 12 -----
xen/include/public/sysctl.h | 5 +-
xen/include/xen/sched.h | 3 -
13 files changed, 119 insertions(+), 109 deletions(-)
--
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Software Engineer @ SUSE https://www.suse.com/
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next reply other threads:[~2018-02-22 16:55 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-22 16:54 Dario Faggioli [this message]
2018-02-22 16:55 ` [PATCH 1/5] xen: sched/credit: convert scheduling parameter to s_time_t when set Dario Faggioli
2018-02-22 16:55 ` [PATCH 2/5] xen: sched/credit1: make vcpu_migration_delay per-cpupool Dario Faggioli
2018-02-22 16:55 ` [PATCH 3/5] tools: libxl/xl: allow to get/set Credit1's vcpu_migration_delay Dario Faggioli
2018-02-22 17:52 ` Wei Liu
2018-02-23 14:26 ` Dario Faggioli
2018-02-22 16:55 ` [PATCH 4/5] tools: xenpm: continue to support {set, get}-vcpu-migration-delay Dario Faggioli
2018-02-22 17:52 ` Wei Liu
2018-02-22 16:55 ` [PATCH 5/5] xen/libxc: suppress direct access to Credit1's migration delay Dario Faggioli
2018-02-22 17:30 ` Wei Liu
2018-02-22 17:33 ` Wei Liu
2018-02-22 17:39 ` Dario Faggioli
2018-02-22 17:52 ` Wei Liu
2018-02-23 9:11 ` Jan Beulich
2018-02-23 9:25 ` Dario Faggioli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=151931759370.5408.3600378338263227885.stgit@Solace.fritz.box \
--to=dfaggioli@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=george.dunlap@eu.citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=jgross@suse.com \
--cc=sstabellini@kernel.org \
--cc=tim@xen.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).