From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: [PATCH v2 1/5] x86/entry: Correct comparisons against boolean variables Date: Tue, 27 Feb 2018 14:50:32 +0000 Message-ID: <1519743036-11600-2-git-send-email-andrew.cooper3@citrix.com> References: <1519743036-11600-1-git-send-email-andrew.cooper3@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1519743036-11600-1-git-send-email-andrew.cooper3@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Xen-devel Cc: Andrew Cooper , Wei Liu , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= List-Id: xen-devel@lists.xenproject.org VGhlIGNvcnJlY3Qgd2F5IHRvIGNoZWNrIGEgYm9vbGVhbiBpcyBgY21wYiAkMGAgb3IgYHRlc3Ri ICQweGZmYCwgd2hlcmVhcyBhCmxvdCBvZiBvdXIgZW50cnkgY29kZSB1c2VzIGB0ZXN0YiAkMWAu ICBUaGlzIHdpbGwgd29yayBpbiBwcmluY2lwbGUgZm9yIHZhbHVlcwp3aGljaCBhcmUgcmVhbGx5 IEMgX0Jvb2wgdHlwZXMsIGJ1dCB3b24ndCB3b3JrIGZvciBvdGhlciBpbnRlZ2VyIHR5cGVzIHdo aWNoCmFyZSBpbnRlbmRlZCB0byBoYXZlIGJvb2xlYW4gcHJvcGVydGllcy4KCmNtcCBpcyB0aGUg bW9yZSBsb2dpY2FsIHdheSBvZiB0aGlua2luZyBhYm91dCB0aGUgb3BlcmF0aW9uLCBzbyBhZGp1 c3QgYWxsCm91dHN0YW5kaW5nIHVzZXMgb2YgYHRlc3RiICQxYCBhZ2FpbnN0IGJvb2xlYW4gdmFs dWVzLiAgQ2hhbmdpbmcgdGVzdCB0byBjbXAKY2hhbmdlcyB0aGUgbG9naWNhbCBtbmVtb25pYyBv ZiB0aGUgZm9sbG93aW5nIGNvbmRpdGlvbiBmcm9tICd6ZXJvJyB0bwonZXF1YWwnLCBidXQgdGhl IGFjdHVhbCBlbmNvZGluZyByZW1haW5zIHRoZSBzYW1lLgoKTm8gZnVuY3Rpb25hbCBjaGFuZ2Us IGFzIGFsbCB1c2VzIGFyZSByZWFsIEMgX0Jvb2wgdHlwZXMsIGFuZCBjb25maXJtZWQgYnkKZGlm ZmluZyB0aGUgZGlzYXNzZW1ibHkuCgpTaWduZWQtb2ZmLWJ5OiBBbmRyZXcgQ29vcGVyIDxhbmRy ZXcuY29vcGVyM0BjaXRyaXguY29tPgotLS0KQ0M6IEphbiBCZXVsaWNoIDxKQmV1bGljaEBzdXNl LmNvbT4KQ0M6IFdlaSBMaXUgPHdlaS5saXUyQGNpdHJpeC5jb20+CkNDOiBSb2dlciBQYXUgTW9u bsOpIDxyb2dlci5wYXVAY2l0cml4LmNvbT4KCk5ldyBpbiB2MgotLS0KIHhlbi9hcmNoL3g4Ni94 ODZfNjQvY29tcGF0L2VudHJ5LlMgfCAgOCArKysrLS0tLQogeGVuL2FyY2gveDg2L3g4Nl82NC9l bnRyeS5TICAgICAgICB8IDI4ICsrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0KIDIgZmlsZXMg Y2hhbmdlZCwgMTggaW5zZXJ0aW9ucygrKSwgMTggZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEv eGVuL2FyY2gveDg2L3g4Nl82NC9jb21wYXQvZW50cnkuUyBiL3hlbi9hcmNoL3g4Ni94ODZfNjQv Y29tcGF0L2VudHJ5LlMKaW5kZXggNDU4ZDgxMC4uM2U4YjZjMSAxMDA2NDQKLS0tIGEveGVuL2Fy Y2gveDg2L3g4Nl82NC9jb21wYXQvZW50cnkuUworKysgYi94ZW4vYXJjaC94ODYveDg2XzY0L2Nv bXBhdC9lbnRyeS5TCkBAIC00MSwxMSArNDEsMTEgQEAgRU5UUlkoY29tcGF0X3Rlc3RfYWxsX2V2 ZW50cykKICAgICAgICAgbGVhcSAgaXJxX3N0YXQrSVJRU1RBVF9zb2Z0aXJxX3BlbmRpbmcoJXJp cCksJXJjeAogICAgICAgICBjbXBsICAkMCwoJXJjeCwlcmF4LDEpCiAgICAgICAgIGpuZSAgIGNv bXBhdF9wcm9jZXNzX3NvZnRpcnFzCi0gICAgICAgIHRlc3RiICQxLFZDUFVfbWNlX3BlbmRpbmco JXJieCkKLSAgICAgICAgam56ICAgY29tcGF0X3Byb2Nlc3NfbWNlCisgICAgICAgIGNtcGIgICQw LCBWQ1BVX21jZV9wZW5kaW5nKCVyYngpCisgICAgICAgIGpuZSAgIGNvbXBhdF9wcm9jZXNzX21j ZQogLkxjb21wYXRfdGVzdF9ndWVzdF9ubWk6Ci0gICAgICAgIHRlc3RiICQxLFZDUFVfbm1pX3Bl bmRpbmcoJXJieCkKLSAgICAgICAgam56ICAgY29tcGF0X3Byb2Nlc3Nfbm1pCisgICAgICAgIGNt cGIgICQwLCBWQ1BVX25taV9wZW5kaW5nKCVyYngpCisgICAgICAgIGpuZSAgIGNvbXBhdF9wcm9j ZXNzX25taQogY29tcGF0X3Rlc3RfZ3Vlc3RfZXZlbnRzOgogICAgICAgICBtb3ZxICBWQ1BVX3Zj cHVfaW5mbyglcmJ4KSwlcmF4CiAgICAgICAgIG1vdnp3bCBDT01QQVRfVkNQVUlORk9fdXBjYWxs X3BlbmRpbmcoJXJheCksJWVheApkaWZmIC0tZ2l0IGEveGVuL2FyY2gveDg2L3g4Nl82NC9lbnRy eS5TIGIveGVuL2FyY2gveDg2L3g4Nl82NC9lbnRyeS5TCmluZGV4IDk0MWYwNmYuLjYyNDllZmUg MTAwNjQ0Ci0tLSBhL3hlbi9hcmNoL3g4Ni94ODZfNjQvZW50cnkuUworKysgYi94ZW4vYXJjaC94 ODYveDg2XzY0L2VudHJ5LlMKQEAgLTE5MCwxMSArMTkwLDExIEBAIHRlc3RfYWxsX2V2ZW50czoK ICAgICAgICAgbGVhcSAgaXJxX3N0YXQrSVJRU1RBVF9zb2Z0aXJxX3BlbmRpbmcoJXJpcCksJXJj eAogICAgICAgICBjbXBsICAkMCwoJXJjeCwlcmF4LDEpCiAgICAgICAgIGpuZSAgIHByb2Nlc3Nf c29mdGlycXMKLSAgICAgICAgdGVzdGIgJDEsVkNQVV9tY2VfcGVuZGluZyglcmJ4KQotICAgICAg ICBqbnogICBwcm9jZXNzX21jZQorICAgICAgICBjbXBiICAkMCwgVkNQVV9tY2VfcGVuZGluZygl cmJ4KQorICAgICAgICBqbmUgICBwcm9jZXNzX21jZQogLkx0ZXN0X2d1ZXN0X25taToKLSAgICAg ICAgdGVzdGIgJDEsVkNQVV9ubWlfcGVuZGluZyglcmJ4KQotICAgICAgICBqbnogICBwcm9jZXNz X25taQorICAgICAgICBjbXBiICAkMCwgVkNQVV9ubWlfcGVuZGluZyglcmJ4KQorICAgICAgICBq bmUgICBwcm9jZXNzX25taQogdGVzdF9ndWVzdF9ldmVudHM6CiAgICAgICAgIG1vdnEgIFZDUFVf dmNwdV9pbmZvKCVyYngpLCVyYXgKICAgICAgICAgbW92endsIFZDUFVJTkZPX3VwY2FsbF9wZW5k aW5nKCVyYXgpLCVlYXgKQEAgLTMwNSw4ICszMDUsOCBAQCBVTkxJS0VMWV9FTkQoc3lzZW50ZXJf Z3BmKQogICAgICAgICBtb3ZxICBWQ1BVX2RvbWFpbiglcmJ4KSwlcmRpCiAgICAgICAgIG1vdnEg ICVyYXgsVFJBUEJPVU5DRV9laXAoJXJkeCkKICAgICAgICAgbW92YiAgJWNsLFRSQVBCT1VOQ0Vf ZmxhZ3MoJXJkeCkKLSAgICAgICAgdGVzdGIgJDEsRE9NQUlOX2lzXzMyYml0X3B2KCVyZGkpCi0g ICAgICAgIGpueiAgIGNvbXBhdF9zeXNlbnRlcgorICAgICAgICBjbXBiICAkMCwgRE9NQUlOX2lz XzMyYml0X3B2KCVyZGkpCisgICAgICAgIGpuZSAgIGNvbXBhdF9zeXNlbnRlcgogICAgICAgICBq bXAgICAuTGJvdW5jZV9leGNlcHRpb24KIAogRU5UUlkoaW50ODBfZGlyZWN0X3RyYXApCkBAIC0z NDIsOCArMzQyLDggQEAgVU5MSUtFTFlfRU5EKG1zaV9jaGVjaykKICAgICAgICAganogICAgaW50 ODBfc2xvd19wYXRoCiAKICAgICAgICAgbW92cSAgVkNQVV9kb21haW4oJXJieCksJXJheAotICAg ICAgICB0ZXN0YiAkMSxET01BSU5faXNfMzJiaXRfcHYoJXJheCkKLSAgICAgICAgam56ICAgY29t cGF0X2ludDgwX2RpcmVjdF90cmFwCisgICAgICAgIGNtcGIgICQwLCBET01BSU5faXNfMzJiaXRf cHYoJXJheCkKKyAgICAgICAgam5lICAgY29tcGF0X2ludDgwX2RpcmVjdF90cmFwCiAKICAgICAg ICAgY2FsbCAgY3JlYXRlX2JvdW5jZV9mcmFtZQogICAgICAgICBqbXAgICB0ZXN0X2FsbF9ldmVu dHMKQEAgLTQ4NCw4ICs0ODQsOCBAQCBFTlRSWShkb21fY3Jhc2hfc3luY19leHRhYmxlKQogICAg ICAgICAjIGNyZWF0ZV9ib3VuY2VfZnJhbWUoKSB0ZW1wb3JhcmlseSBjbG9iYmVycyBDUy5SUEwu IEZpeCB1cC4KICAgICAgICAgbW92cSAgU1RBQ0tfQ1BVSU5GT19GSUVMRChjdXJyZW50X3ZjcHUp KCVyYXgpLCAlcmF4CiAgICAgICAgIG1vdnEgIFZDUFVfZG9tYWluKCVyYXgpLCVyYXgKLSAgICAg ICAgdGVzdGIgJDEsRE9NQUlOX2lzXzMyYml0X3B2KCVyYXgpCi0gICAgICAgIHNldHogICVhbAor ICAgICAgICBjbXBiICAkMCwgRE9NQUlOX2lzXzMyYml0X3B2KCVyYXgpCisgICAgICAgIHNldGUg ICVhbAogICAgICAgICBsZWFsICAoJXJheCwlcmF4LDIpLCVlYXgKICAgICAgICAgb3JiICAgJWFs LFVSRUdTX2NzKCVyc3ApCiAgICAgICAgIHhvcmwgICVlZGksJWVkaQpAQCAtNTI5LDggKzUyOSw4 IEBAIEVOVFJZKHJldF9mcm9tX2ludHIpCiAgICAgICAgIHRlc3RiICQzLFVSRUdTX2NzKCVyc3Ap CiAgICAgICAgIGp6ICAgIHJlc3RvcmVfYWxsX3hlbgogICAgICAgICBtb3ZxICBWQ1BVX2RvbWFp biglcmJ4KSwlcmF4Ci0gICAgICAgIHRlc3RiICQxLERPTUFJTl9pc18zMmJpdF9wdiglcmF4KQot ICAgICAgICBqeiAgICB0ZXN0X2FsbF9ldmVudHMKKyAgICAgICAgY21wYiAgJDAsIERPTUFJTl9p c18zMmJpdF9wdiglcmF4KQorICAgICAgICBqZSAgICB0ZXN0X2FsbF9ldmVudHMKICAgICAgICAg am1wICAgY29tcGF0X3Rlc3RfYWxsX2V2ZW50cwogCiBFTlRSWShwYWdlX2ZhdWx0KQpAQCAtNjI5 LDggKzYyOSw4IEBAIGhhbmRsZV9leGNlcHRpb25fc2F2ZWQ6CiAgICAgICAgIGp6ICAgIHJlc3Rv cmVfYWxsX3hlbgogICAgICAgICBsZWFxICBWQ1BVX3RyYXBfYm91bmNlKCVyYngpLCVyZHgKICAg ICAgICAgbW92cSAgVkNQVV9kb21haW4oJXJieCksJXJheAotICAgICAgICB0ZXN0YiAkMSxET01B SU5faXNfMzJiaXRfcHYoJXJheCkKLSAgICAgICAgam56ICAgY29tcGF0X3Bvc3RfaGFuZGxlX2V4 Y2VwdGlvbgorICAgICAgICBjbXBiICAkMCwgRE9NQUlOX2lzXzMyYml0X3B2KCVyYXgpCisgICAg ICAgIGpuZSAgIGNvbXBhdF9wb3N0X2hhbmRsZV9leGNlcHRpb24KICAgICAgICAgdGVzdGIgJFRC Rl9FWENFUFRJT04sVFJBUEJPVU5DRV9mbGFncyglcmR4KQogICAgICAgICBqeiAgICB0ZXN0X2Fs bF9ldmVudHMKIC5MYm91bmNlX2V4Y2VwdGlvbjoKLS0gCjIuMS40CgoKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVsIG1haWxpbmcgbGlzdApY ZW4tZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKaHR0cHM6Ly9saXN0cy54ZW5wcm9qZWN0Lm9y Zy9tYWlsbWFuL2xpc3RpbmZvL3hlbi1kZXZlbA==