xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Anoob Soman <anoob.soman@citrix.com>
To: xen-devel@lists.xen.org
Cc: wei.liu2@citrix.com, Anoob Soman <anoob.soman@citrix.com>,
	ian.jackson@eu.citrix.com, jbeulich@suse.com,
	andrew.cooper3@citrix.com
Subject: [PATCH 4/5] libxl: Load iPXE ROM from a file
Date: Thu, 15 Mar 2018 17:31:52 +0000	[thread overview]
Message-ID: <1521135113-3764-5-git-send-email-anoob.soman@citrix.com> (raw)
In-Reply-To: <1521135113-3764-1-git-send-email-anoob.soman@citrix.com>

Load iPXE ROM from a file pointed to by IPXE_PATH. If --with-system-ipxe
is not specified default Xen firmware directory is picked up as
IPXE_PATH

Signed-off-by: Anoob Soman <anoob.soman@citrix.com>
---
 tools/libxl/libxl_dom.c      | 12 ++++++++++++
 tools/libxl/libxl_internal.h |  1 +
 tools/libxl/libxl_paths.c    |  9 +++++++++
 3 files changed, 22 insertions(+)

diff --git a/tools/libxl/libxl_dom.c b/tools/libxl/libxl_dom.c
index 2e29b52..104d6a0 100644
--- a/tools/libxl/libxl_dom.c
+++ b/tools/libxl/libxl_dom.c
@@ -1003,6 +1003,7 @@ static int libxl__domain_firmware(libxl__gc *gc,
     int datalen = 0;
     void *data;
     const char *bios_filename = NULL;
+    const char *ipxe_filename = NULL;
 
     if (info->type == LIBXL_DOMAIN_TYPE_HVM) {
         if (info->u.hvm.firmware) {
@@ -1094,6 +1095,17 @@ static int libxl__domain_firmware(libxl__gc *gc,
         assert(info->type == LIBXL_DOMAIN_TYPE_HVM);
         rc = xc_dom_kernel_file(dom, libxl__abs_path(gc, firmware,
                                                  libxl__xenfirmwaredir_path()));
+        if (rc) {
+            LOGE(ERROR, "xc_dom_kernel_file failed");
+            goto out;
+        }
+        if ((ipxe_filename = libxl__ipxe_path())) {
+            rc = xc_dom_module_file(dom, ipxe_filename, "ipxe");
+            if (rc) {
+                LOGE(ERROR, "xc_dom_ipxe_module_file failed");
+                goto out;
+            }
+       }
     }
 
     if (rc != 0) {
diff --git a/tools/libxl/libxl_internal.h b/tools/libxl/libxl_internal.h
index 506687f..f649696 100644
--- a/tools/libxl/libxl_internal.h
+++ b/tools/libxl/libxl_internal.h
@@ -2359,6 +2359,7 @@ _hidden const char *libxl__lock_dir_path(void);
 _hidden const char *libxl__run_dir_path(void);
 _hidden const char *libxl__seabios_path(void);
 _hidden const char *libxl__ovmf_path(void);
+_hidden const char *libxl__ipxe_path(void);
 
 /*----- subprocess execution with timeout -----*/
 
diff --git a/tools/libxl/libxl_paths.c b/tools/libxl/libxl_paths.c
index 0643c1b..3f6a336 100644
--- a/tools/libxl/libxl_paths.c
+++ b/tools/libxl/libxl_paths.c
@@ -53,6 +53,15 @@ const char *libxl__ovmf_path(void)
 #endif
 }
 
+const char *libxl__ipxe_path(void)
+{
+#ifdef IPXE_PATH
+    return IPXE_PATH;
+#else
+    return NULL;
+#endif
+}
+
 /*
  * Local variables:
  * mode: C
-- 
1.8.3.1


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

  parent reply	other threads:[~2018-03-15 17:31 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-15 17:31 Make iPXE a standalone ROM Anoob Soman
2018-03-15 17:31 ` [PATCH 1/5] tools/firmware: Build ipxe as " Anoob Soman
2018-03-16 11:18   ` Jan Beulich
2018-03-16 11:21     ` Andrew Cooper
2018-03-18  1:30     ` Doug Goldstein
2018-03-19  7:48       ` Jan Beulich
2018-03-19 13:52         ` Doug Goldstein
2018-03-15 17:31 ` [PATCH 2/5] tools/firmware: #define IPXE_PATH Anoob Soman
2018-03-21 15:18   ` Wei Liu
2018-03-26 15:53     ` Anoob Soman
2018-03-15 17:31 ` [PATCH 3/5] libxc: Allow loading of firmware modules for HVM guest Anoob Soman
2018-03-18  1:32   ` Doug Goldstein
2018-03-19 14:31     ` Anoob Soman
2018-03-21 15:17   ` Wei Liu
2018-03-26 15:51     ` Anoob Soman
2018-03-15 17:31 ` Anoob Soman [this message]
2018-03-18  1:34   ` [PATCH 4/5] libxl: Load iPXE ROM from a file Doug Goldstein
2018-03-21 15:25   ` Wei Liu
2018-03-26 15:51     ` Anoob Soman
2018-03-15 17:31 ` [PATCH 5/5] hvmloader: Use iPXE ROM loaded from a standalone file Anoob Soman
2018-03-16 11:26   ` Jan Beulich
2018-03-16 11:44     ` Andrew Cooper
2018-03-17 16:54       ` Doug Goldstein
2018-03-19 14:24     ` Anoob Soman
2018-03-19 15:21       ` Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1521135113-3764-5-git-send-email-anoob.soman@citrix.com \
    --to=anoob.soman@citrix.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=jbeulich@suse.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).