From: Maran Wilson <maran.wilson@oracle.com>
To: xen-devel@lists.xen.org
Cc: wei.liu2@citrix.com, boris.ostrovsky@oracle.com,
roger.pau@citrix.com, ian.jackson@eu.citrix.com,
maran.wilson@oracle.com
Subject: [PATCH v3 4/4] libxc: Pass e820 map to PVH guest via hvm_start_info
Date: Thu, 15 Mar 2018 14:35:18 -0700 [thread overview]
Message-ID: <1521149718-21290-3-git-send-email-maran.wilson@oracle.com> (raw)
In-Reply-To: <1521149589-21200-1-git-send-email-maran.wilson@oracle.com>
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Signed-off-by: Maran Wilson <maran.wilson@oracle.com>
---
tools/libxc/xc_dom_x86.c | 30 +++++++++++++++++++++++++++++-
1 file changed, 29 insertions(+), 1 deletion(-)
diff --git a/tools/libxc/xc_dom_x86.c b/tools/libxc/xc_dom_x86.c
index 0b65dab..b46bd1d 100644
--- a/tools/libxc/xc_dom_x86.c
+++ b/tools/libxc/xc_dom_x86.c
@@ -35,6 +35,8 @@
#include <xen/arch-x86/hvm/start_info.h>
#include <xen/io/protocols.h>
+#include <xen-tools/libs.h>
+
#include "xg_private.h"
#include "xc_dom.h"
#include "xenctrl.h"
@@ -640,6 +642,8 @@ static int alloc_magic_pages_hvm(struct xc_dom_image *dom)
dom->cmdline_size = ROUNDUP(strlen(dom->cmdline) + 1, 8);
start_info_size += dom->cmdline_size;
}
+
+ start_info_size += dom->e820_entries * sizeof(*(dom->e820));
}
else
{
@@ -1666,7 +1670,7 @@ static int bootlate_hvm(struct xc_dom_image *dom)
uint32_t domid = dom->guest_domid;
xc_interface *xch = dom->xch;
struct hvm_start_info *start_info;
- size_t start_info_size;
+ size_t start_info_size, modsize;
struct hvm_modlist_entry *modlist;
unsigned int i;
@@ -1693,6 +1697,8 @@ static int bootlate_hvm(struct xc_dom_image *dom)
if ( !dom->device_model )
{
+ struct hvm_memmap_table_entry *memmap;
+
if ( dom->cmdline )
{
char *cmdline = (void*)(start_info + 1);
@@ -1718,6 +1724,27 @@ static int bootlate_hvm(struct xc_dom_image *dom)
/* ACPI module 0 is the RSDP */
start_info->rsdp_paddr = dom->acpi_modules[0].guest_addr_out ? : 0;
+
+ /*
+ * Check a couple of XEN_HVM_MEMMAP_TYPEs to verify consistency with
+ * their corresponding e820 numerical values.
+ */
+ BUILD_BUG_ON(XEN_HVM_MEMMAP_TYPE_RAM != E820_RAM);
+ BUILD_BUG_ON(XEN_HVM_MEMMAP_TYPE_ACPI != E820_ACPI);
+
+ modsize = HVMLOADER_MODULE_MAX_COUNT *
+ (sizeof(*modlist) + HVMLOADER_MODULE_CMDLINE_SIZE);
+ memmap = (void*)modlist + modsize;
+
+ start_info->memmap_paddr = (dom->start_info_seg.pfn << PAGE_SHIFT) +
+ ((uintptr_t)modlist - (uintptr_t)start_info) + modsize;
+ start_info->memmap_entries = dom->e820_entries;
+ for ( i = 0; i < dom->e820_entries; i++ )
+ {
+ memmap[i].addr = dom->e820[i].addr;
+ memmap[i].size = dom->e820[i].size;
+ memmap[i].type = dom->e820[i].type;
+ }
}
else
{
@@ -1732,6 +1759,7 @@ static int bootlate_hvm(struct xc_dom_image *dom)
}
start_info->magic = XEN_HVM_START_MAGIC_VALUE;
+ start_info->version = 1;
munmap(start_info, start_info_size);
--
1.8.3.1
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-03-15 21:35 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-15 21:33 [PATCH v3 0/4] x86/PVHv2: Add memory map pointer to hvm_start_info struct Maran Wilson
2018-03-15 21:33 ` [PATCH v3 1/4] " Maran Wilson
2018-03-16 11:02 ` Jan Beulich
2018-03-16 11:11 ` Roger Pau Monné
2018-03-16 11:29 ` Jan Beulich
2018-03-16 11:37 ` Roger Pau Monné
2018-03-16 11:48 ` Jan Beulich
2018-03-16 11:58 ` Roger Pau Monné
2018-03-16 12:05 ` Juergen Gross
2018-03-16 12:25 ` Jan Beulich
2018-03-16 17:00 ` Maran Wilson
2018-03-16 17:59 ` Roger Pau Monné
2018-03-20 16:05 ` Konrad Rzeszutek Wilk
2018-03-15 21:35 ` [PATCH v3 2/4] libxl: Move libxl__arch_domain_construct_memmap() earlier Maran Wilson
2018-03-16 18:12 ` Roger Pau Monné
2018-03-16 18:34 ` Boris Ostrovsky
2018-03-15 21:35 ` [PATCH v3 3/4] libxl: Store PVH guest's e820 map in xc_dom_image Maran Wilson
2018-03-16 18:20 ` Roger Pau Monné
2018-03-16 18:44 ` Boris Ostrovsky
2018-03-15 21:35 ` Maran Wilson [this message]
2018-03-16 18:29 ` [PATCH v3 4/4] libxc: Pass e820 map to PVH guest via hvm_start_info Roger Pau Monné
2018-03-21 16:00 ` Wei Liu
2018-03-20 16:48 ` [PATCH v4 0/4] x86/PVHv2: Add memory map pointer to hvm_start_info struct Maran Wilson
2018-03-20 16:48 ` [PATCH v4 1/4] " Maran Wilson
2018-03-20 17:03 ` Jan Beulich
2018-03-21 9:28 ` Roger Pau Monné
2018-03-21 9:40 ` Juergen Gross
2018-03-21 16:46 ` Maran Wilson
2018-03-21 16:48 ` Juergen Gross
2018-03-21 16:58 ` Roger Pau Monné
2018-03-20 16:50 ` [PATCH v4 2/4] libxl/x86: Build e820 map earlier for HVM/PVH guests Maran Wilson
2018-03-21 9:37 ` Roger Pau Monné
2018-03-21 17:49 ` Wei Liu
2018-03-21 17:56 ` Boris Ostrovsky
2018-03-20 16:50 ` [PATCH v4 3/4] libxl: Store e820 map in xc_dom_image Maran Wilson
2018-03-21 9:42 ` Roger Pau Monné
2018-03-21 13:26 ` Boris Ostrovsky
2018-03-20 16:50 ` [PATCH v4 4/4] libxc: Pass e820 map to HVM/PVH guests via hvm_start_info Maran Wilson
2018-03-21 10:07 ` Roger Pau Monné
2018-03-21 13:37 ` Boris Ostrovsky
2018-03-21 14:18 ` Roger Pau Monné
2018-03-21 17:53 ` Boris Ostrovsky
2018-03-22 9:15 ` Roger Pau Monné
2018-03-28 11:05 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1521149718-21290-3-git-send-email-maran.wilson@oracle.com \
--to=maran.wilson@oracle.com \
--cc=boris.ostrovsky@oracle.com \
--cc=ian.jackson@eu.citrix.com \
--cc=roger.pau@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).