From: Ian Jackson <ian.jackson@eu.citrix.com>
To: xen-devel@lists.xenproject.org
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
Ian Jackson <Ian.Jackson@eu.citrix.com>
Subject: [OSSTEST PATCH] ts-xen-build: run `make all' before `make', by default
Date: Wed, 9 May 2018 16:58:18 +0100 [thread overview]
Message-ID: <1525881498-31581-1-git-send-email-ian.jackson@eu.citrix.com> (raw)
The Xen build system has some quirks. One of them is that `make' is a
version of `make dist' which is a version of `make install', which
runs `make install' in each subdir - but there are subdirs where `make
install' is a no-op which does not depend on `make all'. Perhaps the
latter is a mistake, but it's not one we can correct in stable
branches.
The result is that we might miss bugs where `make all' fails. Eg, the
recently discovered build failures in the emulator tests, due to
backported changes.
Detect these by running `make all' before `make' (unless our caller
has specified some other build arguments). In the future perhaps we
should do tools and hypervisor builds entirely separately.
Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
---
ts-xen-build | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/ts-xen-build b/ts-xen-build
index c5d2a1d..018bc6a 100755
--- a/ts-xen-build
+++ b/ts-xen-build
@@ -160,6 +160,12 @@ END
fi
END
+ if (!@make_args) {
+ buildcmd_stamped_logged(9000, 'xen', 'all', '',<<END,'');
+ $make_prefix make $makeflags all
+END
+ }
+
buildcmd_stamped_logged(9000, 'xen', 'build', '',<<END,'');
$make_prefix make $makeflags @make_args
END
--
2.1.4
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
reply other threads:[~2018-05-09 15:58 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1525881498-31581-1-git-send-email-ian.jackson@eu.citrix.com \
--to=ian.jackson@eu.citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).