From: Ian Jackson <ian.jackson@eu.citrix.com>
To: xen-devel@lists.xenproject.org
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
Ian Jackson <Ian.Jackson@eu.citrix.com>
Subject: [OSSTEST PATCH] ts-xen-build: run `make build' before `make', by default
Date: Fri, 11 May 2018 15:51:32 +0100 [thread overview]
Message-ID: <1526050292-4075-1-git-send-email-ian.jackson@eu.citrix.com> (raw)
The Xen build system has some quirks. One of them is that `make' is a
version of `make dist' which is a version of `make install', which
runs `make install' in each subdir - but there are subdirs where `make
install' is a no-op which does not depend on `make build'. Also,
`make all' does not do `make build'. Additionally, the default target
differs in the toplevel, compared to subdirectories. Perhaps this is
all mistaken, but it's not something we can correct in stable
branches.
The result is that we might miss bugs where `make build' fails; and in
particular, bugs where simply `make' may fail in a subdirectory. Eg,
the recently discovered build failures in the emulator tests, due to
backported changes, which occur with `make -C tools' but not with
`make all' or `make tools'.
Detect these by running `make build' before `make' (unless our caller
has specified some other build arguments). In the future perhaps we
should do tools and hypervisor builds entirely separately.
Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
---
v2: Use `make build' instead of `make all' since the former actually
detects the bug in a buggy unpatched Xen 4.8. Fix a syntax
error. Improve the commit message.
---
ts-xen-build | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/ts-xen-build b/ts-xen-build
index c5d2a1d..4bf2428 100755
--- a/ts-xen-build
+++ b/ts-xen-build
@@ -160,7 +160,13 @@ END
fi
END
- buildcmd_stamped_logged(9000, 'xen', 'build', '',<<END,'');
+ if (!@make_args) {
+ buildcmd_stamped_logged(9000, 'xen', 'build', '',<<END,'');
+ $make_prefix make $makeflags build
+END
+ }
+
+ buildcmd_stamped_logged(9000, 'xen', 'all', '',<<END,'');
$make_prefix make $makeflags @make_args
END
--
2.1.4
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
reply other threads:[~2018-05-11 14:51 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1526050292-4075-1-git-send-email-ian.jackson@eu.citrix.com \
--to=ian.jackson@eu.citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).