* Re: [PATCH] xen: fix pv domain on amd in 4.9 stable branch [not found] <20180529131136.15624-1-jgross@suse.com> @ 2018-05-30 8:33 ` Greg KH [not found] ` <20180530083336.GC9685@kroah.com> 1 sibling, 0 replies; 5+ messages in thread From: Greg KH @ 2018-05-30 8:33 UTC (permalink / raw) To: Juergen Gross; +Cc: xen-devel, Boris Ostrovsky, David Woodhouse, stable On Tue, May 29, 2018 at 03:11:36PM +0200, Juergen Gross wrote: > Commit 944e0fc51a89c9827b98813d65dc083274777c7f ("x86/amd: don't set > X86_BUG_SYSRET_SS_ATTRS when running under Xen") breaks Xen pv-domains > on AMD processors, as a prerequisite patch from upstream wasn't added > to 4.9. What is the prerequsite patch's git id in Linus's tree? > Fix that by adding the prerequisite setting of X86_FEATURE_XENPV to the > Xen pv early boot path. > > Cc: David Woodhouse <dwmw@amazon.co.uk> > Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com> > Signed-off-by: Juergen Gross <jgross@suse.com> > --- > arch/x86/xen/enlighten.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/x86/xen/enlighten.c b/arch/x86/xen/enlighten.c > index 081437b5f381..674656cdb68c 100644 > --- a/arch/x86/xen/enlighten.c > +++ b/arch/x86/xen/enlighten.c > @@ -1632,6 +1632,9 @@ asmlinkage __visible void __init xen_start_kernel(void) > xen_init_irq_ops(); > xen_init_cpuid_mask(); > > + /* Needed for init_amd(). */ > + setup_force_cpu_cap(X86_FEATURE_XENPV); > + > #ifdef CONFIG_X86_LOCAL_APIC > /* > * set up the basic apic ops. > -- > 2.13.6 I'd prefer to take whatever is in Linus's tree if at all possible. thanks, greg k-h _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel ^ permalink raw reply [flat|nested] 5+ messages in thread
[parent not found: <20180530083336.GC9685@kroah.com>]
* Re: [PATCH] xen: fix pv domain on amd in 4.9 stable branch [not found] ` <20180530083336.GC9685@kroah.com> @ 2018-05-30 9:33 ` Juergen Gross [not found] ` <a0a245e4-8704-c572-d101-c54675c104e1@suse.com> 1 sibling, 0 replies; 5+ messages in thread From: Juergen Gross @ 2018-05-30 9:33 UTC (permalink / raw) To: Greg KH; +Cc: xen-devel, Boris Ostrovsky, David Woodhouse, stable On 30/05/18 10:33, Greg KH wrote: > On Tue, May 29, 2018 at 03:11:36PM +0200, Juergen Gross wrote: >> Commit 944e0fc51a89c9827b98813d65dc083274777c7f ("x86/amd: don't set >> X86_BUG_SYSRET_SS_ATTRS when running under Xen") breaks Xen pv-domains >> on AMD processors, as a prerequisite patch from upstream wasn't added >> to 4.9. > > What is the prerequsite patch's git id in Linus's tree? Commit 0808e80cb760de2733c0527d2090ed2205a1eef8. It won't apply, backporting is rather easy, though. I thought this was a patch in the middle of a larger series, but obviously I misremembered. It was the first patch of that series. I'll send a series in case you don't object: - revert of stable-4.9 944e0fc51a89c9827b98813d65dc083274777c7f - backport of 0808e80cb760de2733c0527d2090ed2205a1eef8 - new backport of def9331a12977770cc6132d79f8e6565871e8e38 Juergen _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel ^ permalink raw reply [flat|nested] 5+ messages in thread
[parent not found: <a0a245e4-8704-c572-d101-c54675c104e1@suse.com>]
* Re: [PATCH] xen: fix pv domain on amd in 4.9 stable branch [not found] ` <a0a245e4-8704-c572-d101-c54675c104e1@suse.com> @ 2018-05-30 9:46 ` Greg KH [not found] ` <20180530094640.GC25193@kroah.com> 1 sibling, 0 replies; 5+ messages in thread From: Greg KH @ 2018-05-30 9:46 UTC (permalink / raw) To: Juergen Gross; +Cc: xen-devel, Boris Ostrovsky, David Woodhouse, stable On Wed, May 30, 2018 at 11:33:22AM +0200, Juergen Gross wrote: > On 30/05/18 10:33, Greg KH wrote: > > On Tue, May 29, 2018 at 03:11:36PM +0200, Juergen Gross wrote: > >> Commit 944e0fc51a89c9827b98813d65dc083274777c7f ("x86/amd: don't set > >> X86_BUG_SYSRET_SS_ATTRS when running under Xen") breaks Xen pv-domains > >> on AMD processors, as a prerequisite patch from upstream wasn't added > >> to 4.9. > > > > What is the prerequsite patch's git id in Linus's tree? > > Commit 0808e80cb760de2733c0527d2090ed2205a1eef8. It won't apply, > backporting is rather easy, though. > > I thought this was a patch in the middle of a larger series, but > obviously I misremembered. It was the first patch of that series. > > I'll send a series in case you don't object: > > - revert of stable-4.9 944e0fc51a89c9827b98813d65dc083274777c7f > - backport of 0808e80cb760de2733c0527d2090ed2205a1eef8 > - new backport of def9331a12977770cc6132d79f8e6565871e8e38 That would be great, I'll gladly take that, thanks. greg k-h _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel ^ permalink raw reply [flat|nested] 5+ messages in thread
[parent not found: <20180530094640.GC25193@kroah.com>]
* Re: [PATCH] xen: fix pv domain on amd in 4.9 stable branch [not found] ` <20180530094640.GC25193@kroah.com> @ 2018-05-30 10:29 ` Woodhouse, David 0 siblings, 0 replies; 5+ messages in thread From: Woodhouse, David @ 2018-05-30 10:29 UTC (permalink / raw) To: gregkh@linuxfoundation.org, jgross@suse.com Cc: xen-devel@lists.xenproject.org, boris.ostrovsky@oracle.com, stable@vger.kernel.org [-- Attachment #1.1: Type: text/plain, Size: 1222 bytes --] On Wed, 2018-05-30 at 11:46 +0200, Greg KH wrote: > On Wed, May 30, 2018 at 11:33:22AM +0200, Juergen Gross wrote: > > > > On 30/05/18 10:33, Greg KH wrote: > > > > > > On Tue, May 29, 2018 at 03:11:36PM +0200, Juergen Gross wrote: > > > > > > > > Commit 944e0fc51a89c9827b98813d65dc083274777c7f ("x86/amd: > > > > don't set > > > > X86_BUG_SYSRET_SS_ATTRS when running under Xen") breaks Xen pv- > > > > domains > > > > on AMD processors, as a prerequisite patch from upstream wasn't > > > > added > > > > to 4.9. > > > What is the prerequsite patch's git id in Linus's tree? > > Commit 0808e80cb760de2733c0527d2090ed2205a1eef8. It won't apply, > > backporting is rather easy, though. > > > > I thought this was a patch in the middle of a larger series, but > > obviously I misremembered. It was the first patch of that series. > > > > I'll send a series in case you don't object: > > > > - revert of stable-4.9 944e0fc51a89c9827b98813d65dc083274777c7f > > - backport of 0808e80cb760de2733c0527d2090ed2205a1eef8 > > - new backport of def9331a12977770cc6132d79f8e6565871e8e38 > > That would be great, I'll gladly take that, thanks. Apologies for messing that up. Thanks for fixing it. [-- Attachment #1.2: smime.p7s --] [-- Type: application/x-pkcs7-signature, Size: 5210 bytes --] [-- Attachment #2.1: Type: text/plain, Size: 215 bytes --] Amazon Development Centre (London) Ltd. Registered in England and Wales with registration number 04543232 with its registered office at 1 Principal Place, Worship Street, London EC2A 2FA, United Kingdom. [-- Attachment #2.2: Type: text/html, Size: 228 bytes --] [-- Attachment #3: Type: text/plain, Size: 157 bytes --] _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] xen: fix pv domain on amd in 4.9 stable branch
@ 2018-05-29 13:11 Juergen Gross
0 siblings, 0 replies; 5+ messages in thread
From: Juergen Gross @ 2018-05-29 13:11 UTC (permalink / raw)
To: stable, xen-devel; +Cc: Juergen Gross, Boris Ostrovsky, David Woodhouse
Commit 944e0fc51a89c9827b98813d65dc083274777c7f ("x86/amd: don't set
X86_BUG_SYSRET_SS_ATTRS when running under Xen") breaks Xen pv-domains
on AMD processors, as a prerequisite patch from upstream wasn't added
to 4.9.
Fix that by adding the prerequisite setting of X86_FEATURE_XENPV to the
Xen pv early boot path.
Cc: David Woodhouse <dwmw@amazon.co.uk>
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Signed-off-by: Juergen Gross <jgross@suse.com>
---
arch/x86/xen/enlighten.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/x86/xen/enlighten.c b/arch/x86/xen/enlighten.c
index 081437b5f381..674656cdb68c 100644
--- a/arch/x86/xen/enlighten.c
+++ b/arch/x86/xen/enlighten.c
@@ -1632,6 +1632,9 @@ asmlinkage __visible void __init xen_start_kernel(void)
xen_init_irq_ops();
xen_init_cpuid_mask();
+ /* Needed for init_amd(). */
+ setup_force_cpu_cap(X86_FEATURE_XENPV);
+
#ifdef CONFIG_X86_LOCAL_APIC
/*
* set up the basic apic ops.
--
2.13.6
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply related [flat|nested] 5+ messages in threadend of thread, other threads:[~2018-05-30 10:29 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20180529131136.15624-1-jgross@suse.com>
2018-05-30 8:33 ` [PATCH] xen: fix pv domain on amd in 4.9 stable branch Greg KH
[not found] ` <20180530083336.GC9685@kroah.com>
2018-05-30 9:33 ` Juergen Gross
[not found] ` <a0a245e4-8704-c572-d101-c54675c104e1@suse.com>
2018-05-30 9:46 ` Greg KH
[not found] ` <20180530094640.GC25193@kroah.com>
2018-05-30 10:29 ` Woodhouse, David
2018-05-29 13:11 Juergen Gross
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).