[PATCH 00/11] Fixes to debugging facilities

From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xen.org>
Cc: "Kevin Tian" <kevin.tian@intel.com>,
	"Tamas K Lengyel" <tamas@tklengyel.com>,
	"Wei Liu" <wei.liu2@citrix.com>,
	"Jan Beulich" <JBeulich@suse.com>,
	"Razvan Cojocaru" <rcojocaru@bitdefender.com>,
	"Andrew Cooper" <andrew.cooper3@citrix.com>,
	"Tim Deegan" <tim@xen.org>,
	"Jun Nakajima" <jun.nakajima@intel.com>,
	"Boris Ostrovsky" <boris.ostrovsky@oracle.com>,
	"Brian Woods" <brian.woods@amd.com>,
	"Suravee Suthikulpanit" <suravee.suthikulpanit@amd.com>,
	"Roger Pau Monné" <roger.pau@citrix.com>
Subject: [PATCH 00/11] Fixes to debugging facilities
Date: Mon, 4 Jun 2018 14:59:04 +0100	[thread overview]
Message-ID: <1528120755-17455-1-git-send-email-andrew.cooper3@citrix.com> (raw)

So this started as a small fix for the vmentry failure (penultimate patch),
and has snowballed...

I'm fairly confident that everything involving DEBUGCTL.BTF is broken, and
there are definitely bugs with configuring DEBUGCTL.RTM (which really isn't
helped by the fact that the GCC TSX intrinsics render the resulting code
un-debuggable.)  I'll defer fixing these swamps for now.

The first 4 patches probably want backporting to the stable trees, so I've
taken care to move them ahead of patch 6 for backport reasons.  While all
fixes would ideally be backported, I can't find a way of fixing %dr6 merging
(as it needs to be done precicely once) without a behavioural change in the
monitor subsystem.

Patch 8 probably breaks introspection, so can't be taken at this point.  See
that patch for discussion of the problem and my best guess at a solution.

Andrew Cooper (11):
  x86/svm Fixes and cleanup to svm_inject_event()
  x86/vmx: Don't clobber %dr6 while debugging state is lazy
  x86: Initialise debug registers correctly
  x86: Fix calculation of %dr6/7 reserved bits
  x86/emul: Unfold %cr4.de handling in x86emul_read_dr()
  x86: Reorganise and rename debug register fields in struct vcpu
  x86/emul: Add pending_dbg field to x86_event
  x86/hvm: RFC - PROBABLY BROKEN - Defer all debugging/monitor actions to {svm,vmx}_inject_event()
  x86: Fix merging of new status bits into %dr6
  x86/vmx: Work around VMEntry failure when Single Stepping in an STI shadow
  x86/dbg: Cleanup of legacy dr6 constants

 tools/libxc/xc_dom_x86.c               |  12 ++
 xen/arch/x86/acpi/suspend.c            |  14 +--
 xen/arch/x86/cpu/common.c              |  12 +-
 xen/arch/x86/domain.c                  |  32 ++++--
 xen/arch/x86/domctl.c                  |  15 +--
 xen/arch/x86/hvm/emulate.c             |   3 +-
 xen/arch/x86/hvm/hvm.c                 |  33 +++---
 xen/arch/x86/hvm/svm/svm.c             | 193 +++++++++++++++++----------------
 xen/arch/x86/hvm/vmx/vmx.c             | 161 +++++++++++++++------------
 xen/arch/x86/mm/shadow/multi.c         |   5 +-
 xen/arch/x86/pv/emul-priv-op.c         |  25 ++---
 xen/arch/x86/pv/emulate.c              |   6 +-
 xen/arch/x86/pv/ro-page-fault.c        |   3 +-
 xen/arch/x86/pv/traps.c                |  17 ++-
 xen/arch/x86/traps.c                   |  52 ++++-----
 xen/arch/x86/vm_event.c                |   2 +-
 xen/arch/x86/x86_emulate.c             |  27 +++--
 xen/arch/x86/x86_emulate/x86_emulate.h |   5 +-
 xen/include/asm-x86/debugreg.h         |  89 +++++++++++----
 xen/include/asm-x86/domain.h           |  23 +++-
 xen/include/asm-x86/hvm/hvm.h          |  15 ++-
 21 files changed, 441 insertions(+), 303 deletions(-)

-- 
2.1.4

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel