From: "Woodhouse, David" <dwmw@amazon.co.uk>
To: "roger.pau@citrix.com" <roger.pau@citrix.com>,
"Paraschiv, Andra-Irina" <andraprs@amazon.com>
Cc: "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
"sstabellini@kernel.org" <sstabellini@kernel.org>,
"ian.jackson@eu.citrix.com" <ian.jackson@eu.citrix.com>,
"jbeulich@suse.com" <jbeulich@suse.com>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH qemu-xen-traditional] xen/pt: allow QEMU to request MSI unmasking at bind time
Date: Tue, 31 Jul 2018 10:22:15 +0000 [thread overview]
Message-ID: <1533032534.16128.19.camel@amazon.co.uk> (raw)
In-Reply-To: <1529570276822.28578@amazon.com>
[-- Attachment #1.1: Type: text/plain, Size: 2636 bytes --]
Ian, any objections?
Thanks.On Thu, 2018-06-21 at 08:37 +0000, Paraschiv, Andra-Irina wrote:
> + Cc: Ian Jackson <ian.jackson@eu.citrix.com> for review.
>
> Thanks, Roger, for review and feedback.
>
> Andra
> ________________________________________
> From: Roger Pau Monné <roger.pau@citrix.com>
> Sent: Monday, June 18, 2018 2:43 PM
> To: Paraschiv, Andra-Irina
> Cc: xen-devel@lists.xenproject.org; sstabellini@kernel.org; jbeulich@
> suse.com; andrew.cooper3@citrix.com; Woodhouse, David
> Subject: Re: [PATCH qemu-xen-traditional] xen/pt: allow QEMU to
> request MSI unmasking at bind time
>
> On Mon, Jun 18, 2018 at 09:35:20AM +0000, Andra Paraschiv wrote:
> >
> > When a MSI interrupt is bound to a guest using
> > xc_domain_update_msi_irq (XEN_DOMCTL_bind_pt_irq) the interrupt is
> > left masked by default.
> >
> > This causes problems with guests that first configure interrupts
> > and
> > clean the per-entry MSIX table mask bit and afterwards enable MSIX
> > globally. In such scenario the Xen internal msixtbl handlers would
> > not
> > detect the unmasking of MSIX entries because vectors are not yet
> > registered since MSIX is not enabled, and vectors would be left
> > masked.
> >
> > Introduce a new flag in the gflags field to signal Xen whether a
> > MSI
> > interrupt should be unmasked after being bound.
> >
> > This also requires to track the mask register for MSI interrupts,
> > so
> > QEMU can also notify to Xen whether the MSI interrupt should be
> > bound
> > masked or unmasked
> >
> > Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> > Reviewed-by: Jan Beulich <jbeulich@suse.com>
> > Reported-by: Andreas Kinzler <hfp@posteo.de>
> > Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
> > Signed-off-by: Stefano Stabellini <sstabellini@kernel.org>
> >
> > [Backported from commit a8036336609d2e184fc3543a4c439c0ba7d7f3a2
> > https://git.qemu.org/?p=qemu.git;a=commit;h=a8036336609d2e184fc354
> > 3a4c439c0ba7d7f3a2
> > https://xenbits.xen.org/gitweb/?p=qemu-xen.git;a=commit;h=a8036336
> > 609d2e184fc3543a4c439c0ba7d7f3a2]
> >
> > Signed-off-by: Andra Paraschiv <andraprs@amazon.com>
> Thanks for doing the backport, LGTM.
>
>
>
> Amazon Development Center (Romania) S.R.L. registered office: 27A Sf.
> Lazar Street, UBC5, floor 2, Iasi, Iasi County, 700045, Romania.
> Registered in Romania. Registration number J22/2621/2005.
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xenproject.org
> https://lists.xenproject.org/mailman/listinfo/xen-devel
[-- Attachment #1.2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 5210 bytes --]
[-- Attachment #2.1: Type: text/plain, Size: 215 bytes --]
Amazon Development Centre (London) Ltd. Registered in England and Wales with registration number 04543232 with its registered office at 1 Principal Place, Worship Street, London EC2A 2FA, United Kingdom.
[-- Attachment #2.2: Type: text/html, Size: 228 bytes --]
[-- Attachment #3: Type: text/plain, Size: 157 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-07-31 10:22 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-26 1:34 [PATCH] xen vtd : set msi guest_masked 0 by default Jianzhong,Chang
2016-01-26 12:56 ` Jan Beulich
2016-01-26 22:24 ` Tian, Kevin
2016-03-07 8:12 ` jzh Chang
2016-03-07 10:57 ` Jan Beulich
2018-05-21 11:46 ` David Woodhouse
2018-05-21 12:10 ` Roger Pau Monné
2018-05-23 7:01 ` David Woodhouse
2018-06-18 9:35 ` [PATCH qemu-xen-traditional] xen/pt: allow QEMU to request MSI unmasking at bind time Andra Paraschiv
2018-06-18 11:43 ` Roger Pau Monné
2018-06-21 8:37 ` Paraschiv, Andra-Irina
2018-07-31 10:22 ` Woodhouse, David [this message]
2018-09-17 8:40 ` Paraschiv, Andra-Irina
2018-10-09 13:55 ` Ian Jackson
2018-10-09 15:23 ` Paraschiv, Andra-Irina
2018-10-10 14:56 ` Ian Jackson
2018-10-10 19:06 ` Paraschiv, Andra-Irina
2018-06-18 10:31 ` xen vtd : set msi guest_masked 0 by default Paraschiv, Andra-Irina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1533032534.16128.19.camel@amazon.co.uk \
--to=dwmw@amazon.co.uk \
--cc=andraprs@amazon.com \
--cc=andrew.cooper3@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=roger.pau@citrix.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).