xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Isaila Alexandru <aisaila@bitdefender.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
	Paul Durrant <paul.durrant@citrix.com>,
	Wei Liu <wei.liu2@citrix.com>,
	Ian Jackson <Ian.Jackson@eu.citrix.com>,
	xen-devel@lists.xen.org
Subject: Re: [PATCH v14 09/11] x86/domctl: Don't pause the whole domain if only getting vcpu state
Date: Wed, 01 Aug 2018 17:50:46 +0300	[thread overview]
Message-ID: <1533135046.21125.36.camel@bitdefender.com> (raw)
In-Reply-To: <5B605F4702000078001D9759@prv1-mh.provo.novell.com>

On Ma, 2018-07-31 at 07:08 -0600, Jan Beulich wrote:
> > 
> > > 
> > > > 
> > > > On 25.07.18 at 14:14, <aisaila@bitdefender.com> wrote:
> > This patch is focused on moving the for loop to the caller so
> > now we can save info for a single vcpu instance with the save_one
> > handlers.
> > 
> > Signed-off-by: Alexandru Isaila <aisaila@bitdefender.com>
> First of all I'd appreciate if this patch was last in the series,
> after all
> infrastructure changes have been done.
> 
If this patch will be the last one in the series then between the one
that removes the save functions (and with that the for) and this one
the code will not run as expected because there will be no for. 

This patch has to be followed by the "Remove redundant save functions"
and not the other way around.

Please clarify this if I did not understood correctly. 

Thanks, 
Alex

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

  reply	other threads:[~2018-08-01 14:50 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-25 12:14 [PATCH v14 00/11] x86/domctl: Save info for one vcpu instance Alexandru Isaila
2018-07-25 12:14 ` [PATCH v14 01/11] x86/cpu: Introduce vmce_save_vcpu_ctxt_one() func Alexandru Isaila
2018-07-31 11:56   ` Jan Beulich
2018-07-31 12:06     ` Jan Beulich
2018-07-25 12:14 ` [PATCH v14 02/11] x86/hvm: Introduce hvm_save_tsc_adjust_one() func Alexandru Isaila
2018-07-25 12:14 ` [PATCH v14 03/11] x86/hvm: Introduce hvm_save_cpu_ctxt_one func Alexandru Isaila
2018-07-31 12:01   ` Jan Beulich
2018-07-25 12:14 ` [PATCH v14 04/11] x86/hvm: Introduce hvm_save_cpu_xsave_states_one Alexandru Isaila
2018-07-31 12:04   ` Jan Beulich
2018-07-25 12:14 ` [PATCH v14 05/11] x86/hvm: Introduce hvm_save_cpu_msrs_one func Alexandru Isaila
2018-07-31 12:10   ` Jan Beulich
2018-07-25 12:14 ` [PATCH v14 06/11] x86/hvm: Introduce hvm_save_mtrr_msr_one func Alexandru Isaila
2018-07-31 12:16   ` Jan Beulich
2018-08-01 14:57     ` Isaila Alexandru
2018-08-01 15:03       ` Jan Beulich
2018-07-25 12:14 ` [PATCH v14 07/11] x86/hvm: Introduce viridian_save_vcpu_ctxt_one() func Alexandru Isaila
2018-07-31 12:17   ` Jan Beulich
2018-07-25 12:14 ` [PATCH v14 08/11] x86/hvm: Add handler for save_one funcs Alexandru Isaila
2018-07-31 12:34   ` Jan Beulich
2018-07-31 12:55     ` Isaila Alexandru
2018-07-31 13:32       ` Jan Beulich
2018-07-31 13:45         ` Isaila Alexandru
2018-07-31 14:22           ` Jan Beulich
2018-07-25 12:14 ` [PATCH v14 09/11] x86/domctl: Don't pause the whole domain if only getting vcpu state Alexandru Isaila
2018-07-31 13:08   ` Jan Beulich
2018-08-01 14:50     ` Isaila Alexandru [this message]
2018-08-01 15:10       ` Jan Beulich
2018-07-25 12:14 ` [PATCH v14 10/11] x86/hvm: Remove redundant save functions Alexandru Isaila
2018-07-31 13:24   ` Jan Beulich
2018-07-31 13:32     ` Isaila Alexandru
2018-07-31 14:26       ` Jan Beulich
2018-07-25 12:14 ` [PATCH v14 11/11] x86/hvm: Remove save_one handler Alexandru Isaila
2018-07-25 12:38 ` [PATCH v14 00/11] x86/domctl: Save info for one vcpu instance Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1533135046.21125.36.camel@bitdefender.com \
    --to=aisaila@bitdefender.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=JBeulich@suse.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=paul.durrant@citrix.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).