From: Isaila Alexandru <aisaila@bitdefender.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
Paul Durrant <paul.durrant@citrix.com>,
Wei Liu <wei.liu2@citrix.com>,
Ian Jackson <Ian.Jackson@eu.citrix.com>,
xen-devel@lists.xen.org
Subject: Re: [PATCH v15 06/14] x86/hvm: Introduce hvm_save_mtrr_msr_one func
Date: Tue, 07 Aug 2018 18:02:16 +0300 [thread overview]
Message-ID: <1533654136.23883.4.camel@bitdefender.com> (raw)
In-Reply-To: <5B6989DC02000078001DB863@prv1-mh.provo.novell.com>
>
> >
> > - hvm_get_guest_pat(v, &hw_mtrr.msr_pat_cr);
> > + memcpy(hw_mtrr.msr_mtrr_fixed, mtrr_state->fixed_ranges,
> > NUM_FIXED_MSR);
> You want to BUILD_BUG_ON() array sizes differing, and then use
> sizeof() in the call to memcpy().
>
In this case sizes are different:
msr_mtrr_fixed[NUM_FIXED_MSR];
fixed_ranges[NUM_FIXED_RANGES];
#define NUM_FIXED_RANGES 88
#define NUM_FIXED_MSR 11
so it will most likely assert a message.
Alex
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-08-07 15:02 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-03 13:53 [PATCH v15 00/14] x86/domctl: Save info for one vcpu instance Alexandru Isaila
2018-08-03 13:53 ` [PATCH v15 01/14] x86/cpu: Introduce vmce_save_vcpu_ctxt_one() func Alexandru Isaila
2018-08-03 13:53 ` [PATCH v15 02/14] x86/hvm: Introduce hvm_save_tsc_adjust_one() func Alexandru Isaila
2018-08-03 13:53 ` [PATCH v15 03/14] x86/hvm: Introduce hvm_save_cpu_ctxt_one func Alexandru Isaila
2018-08-03 13:53 ` [PATCH v15 04/14] x86/hvm: Introduce hvm_save_cpu_xsave_states_one Alexandru Isaila
2018-08-03 13:53 ` [PATCH v15 05/14] x86/hvm: Introduce hvm_save_cpu_msrs_one func Alexandru Isaila
2018-08-03 13:53 ` [PATCH v15 06/14] x86/hvm: Introduce hvm_save_mtrr_msr_one func Alexandru Isaila
2018-08-07 12:00 ` Jan Beulich
2018-08-07 15:02 ` Isaila Alexandru [this message]
2018-08-07 15:11 ` Jan Beulich
2018-08-03 13:53 ` [PATCH v15 07/14] x86/hvm: Introduce viridian_save_vcpu_ctxt_one() func Alexandru Isaila
2018-08-03 13:53 ` [PATCH v15 08/14] x86/hvm: Introduce lapic_save_hidden_one Alexandru Isaila
2018-08-03 13:53 ` [PATCH v15 09/14] x86/hvm: Introduce lapic_save_regs_one func Alexandru Isaila
2018-08-07 12:09 ` Jan Beulich
2018-08-07 12:37 ` Isaila Alexandru
2018-08-03 13:53 ` [PATCH v15 10/14] x86/hvm: Add handler for save_one funcs Alexandru Isaila
2018-08-03 13:53 ` [PATCH v15 11/14] x86/domctl: Use hvm_save_vcpu_handler Alexandru Isaila
2018-08-07 12:25 ` Jan Beulich
2018-08-03 13:53 ` [PATCH v15 12/14] x86/hvm: Drop the use of save functions Alexandru Isaila
2018-08-07 12:28 ` Jan Beulich
2018-08-07 12:41 ` Jan Beulich
2018-08-03 13:53 ` [PATCH v15 13/14] x86/hvm: Remove redundant " Alexandru Isaila
2018-08-07 12:47 ` Jan Beulich
2018-08-03 13:53 ` [PATCH v15 14/14] x86/domctl: Don't pause the whole domain if only getting vcpu state Alexandru Isaila
2018-08-07 12:58 ` Jan Beulich
2018-08-07 12:59 ` [PATCH v15 00/14] x86/domctl: Save info for one vcpu instance Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1533654136.23883.4.camel@bitdefender.com \
--to=aisaila@bitdefender.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=paul.durrant@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).