From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xen.org>
Cc: "Andrew Cooper" <andrew.cooper3@citrix.com>,
"Tim Deegan" <tim@xen.org>, "Wei Liu" <wei.liu2@citrix.com>,
"Jan Beulich" <JBeulich@suse.com>,
"Roger Pau Monné" <roger.pau@citrix.com>
Subject: [PATCH 3/6] x86/shadow: Switch shadow_domain.has_fast_mmio_entries to bool
Date: Wed, 15 Aug 2018 19:34:34 +0100 [thread overview]
Message-ID: <1534358077-24700-4-git-send-email-andrew.cooper3@citrix.com> (raw)
In-Reply-To: <1534358077-24700-1-git-send-email-andrew.cooper3@citrix.com>
Remove an unecessary if().
No functional change.
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Jan Beulich <JBeulich@suse.com>
CC: Tim Deegan <tim@xen.org>
CC: Wei Liu <wei.liu2@citrix.com>
CC: Roger Pau Monné <roger.pau@citrix.com>
---
xen/arch/x86/mm/shadow/common.c | 2 +-
xen/arch/x86/mm/shadow/multi.c | 3 +--
xen/include/asm-x86/domain.h | 2 +-
3 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/xen/arch/x86/mm/shadow/common.c b/xen/arch/x86/mm/shadow/common.c
index 8a7a2b0..c9640b9 100644
--- a/xen/arch/x86/mm/shadow/common.c
+++ b/xen/arch/x86/mm/shadow/common.c
@@ -3687,7 +3687,7 @@ shadow_write_p2m_entry(struct domain *d, unsigned long gfn,
if ( d->arch.paging.shadow.has_fast_mmio_entries )
{
shadow_blow_tables(d);
- d->arch.paging.shadow.has_fast_mmio_entries = 0;
+ d->arch.paging.shadow.has_fast_mmio_entries = false;
}
#endif
diff --git a/xen/arch/x86/mm/shadow/multi.c b/xen/arch/x86/mm/shadow/multi.c
index fbdbb7d..8f90c9f 100644
--- a/xen/arch/x86/mm/shadow/multi.c
+++ b/xen/arch/x86/mm/shadow/multi.c
@@ -563,8 +563,7 @@ _sh_propagate(struct vcpu *v,
{
/* Guest l1e maps emulated MMIO space */
*sp = sh_l1e_mmio(target_gfn, gflags);
- if ( !d->arch.paging.shadow.has_fast_mmio_entries )
- d->arch.paging.shadow.has_fast_mmio_entries = 1;
+ d->arch.paging.shadow.has_fast_mmio_entries = true;
goto done;
}
diff --git a/xen/include/asm-x86/domain.h b/xen/include/asm-x86/domain.h
index 09f6b3d..3da2c68 100644
--- a/xen/include/asm-x86/domain.h
+++ b/xen/include/asm-x86/domain.h
@@ -113,7 +113,7 @@ struct shadow_domain {
bool_t hash_walking; /* Some function is walking the hash table */
/* Fast MMIO path heuristic */
- bool_t has_fast_mmio_entries;
+ bool has_fast_mmio_entries;
/* OOS */
bool_t oos_active;
--
2.1.4
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-08-15 18:34 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-15 18:34 [PATCH 0/6] x86/mm: Minor non-functional cleanup Andrew Cooper
2018-08-15 18:34 ` [PATCH 1/6] x86/mm: Use mfn_eq()/mfn_add() rather than opencoded variations Andrew Cooper
2018-08-16 16:07 ` Roger Pau Monné
2018-08-17 12:54 ` Jan Beulich
2018-08-15 18:34 ` [PATCH 2/6] x86/shadow: Use more appropriate conversion functions Andrew Cooper
2018-08-16 16:08 ` Roger Pau Monné
2018-08-21 10:02 ` Wei Liu
2018-08-15 18:34 ` Andrew Cooper [this message]
2018-08-16 16:09 ` [PATCH 3/6] x86/shadow: Switch shadow_domain.has_fast_mmio_entries to bool Roger Pau Monné
2018-08-17 12:57 ` Jan Beulich
2018-08-15 18:34 ` [PATCH 4/6] x86/shadow: Use MASK_* helpers for the MMIO fastpath PTE manipulation Andrew Cooper
2018-08-16 16:12 ` Roger Pau Monné
2018-08-21 10:04 ` Wei Liu
2018-08-15 18:34 ` [PATCH 5/6] x86/shadow: Clean up the MMIO fastpath helpers Andrew Cooper
2018-08-16 16:16 ` Roger Pau Monné
2018-08-21 10:05 ` Wei Liu
2018-08-15 18:34 ` [PATCH 6/6] x86/shadow: Use mfn_t in shadow_track_dirty_vram() Andrew Cooper
2018-08-16 16:18 ` Roger Pau Monné
2018-08-21 10:05 ` Wei Liu
2018-08-16 19:00 ` [PATCH 0/6] x86/mm: Minor non-functional cleanup Tim Deegan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1534358077-24700-4-git-send-email-andrew.cooper3@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=JBeulich@suse.com \
--cc=roger.pau@citrix.com \
--cc=tim@xen.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).