xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xen.org>
Cc: "Stefano Stabellini" <sstabellini@kernel.org>,
	"Wei Liu" <wei.liu2@citrix.com>,
	"Andrew Cooper" <andrew.cooper3@citrix.com>,
	"Julien Grall" <julien.grall@arm.com>,
	"Jan Beulich" <JBeulich@suse.com>,
	"Roger Pau Monné" <roger.pau@citrix.com>
Subject: [PATCH 0/5] xen/domain: Cleanup to the domain_create() error paths
Date: Mon, 3 Sep 2018 15:46:55 +0100	[thread overview]
Message-ID: <1535986020-15906-1-git-send-email-andrew.cooper3@citrix.com> (raw)

This is the start of a large amount of cleanup work to eventually allow for
the removal of XEN_DOMCTL_max_cpus hypercall.

The work to do is:

  1) Make the domain destruction path fully idempotent, and use instead of the
     ad-hoc cleanup in each of the various create functions.
  2) Do the same for the vcpu create/destroy path (which is in a far worse
     mess).

The arch-specific ARM code is all idempotent, but the common and x86 code has
a long way to go.

With this done, we should be able to cleanly unwind from any failure at any
point during domain creation, including when moving the vcpu allocation loop
into domain_create().

Andrew Cooper (5):
  xen/domain: Prepare data for is_{pv,hvm}_domain() as early as possible
  xen/domain: Break __domain_destroy() out of domain_create() and complete_domain_destroy()
  xen/domain: Call lock_profile_deregister_struct() from common code
  xen/domain: Fold xsm_free_security_domain() paths together
  xen/domain: Make rangeset_domain_destroy() idempotent

 xen/arch/x86/domain.c |  1 -
 xen/common/domain.c   | 62 +++++++++++++++++++++++++++++++--------------------
 xen/common/rangeset.c |  3 +++
 3 files changed, 41 insertions(+), 25 deletions(-)

-- 
2.1.4


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

             reply	other threads:[~2018-09-03 14:46 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-03 14:46 Andrew Cooper [this message]
2018-09-03 14:46 ` [PATCH 1/5] xen/domain: Prepare data for is_{pv, hvm}_domain() as early as possible Andrew Cooper
2018-09-03 16:03   ` Jan Beulich
2018-09-04 12:17     ` Andrew Cooper
2018-09-04 12:53       ` Jan Beulich
2018-09-03 16:47   ` Wei Liu
2018-09-03 14:46 ` [PATCH 2/5] xen/domain: Break __domain_destroy() out of domain_create() and complete_domain_destroy() Andrew Cooper
2018-09-03 16:05   ` Jan Beulich
2018-09-03 16:54   ` Wei Liu
2018-09-03 16:58     ` Andrew Cooper
2018-09-03 17:01       ` Wei Liu
2018-09-03 17:05         ` Andrew Cooper
2018-09-03 17:07           ` Wei Liu
2018-09-03 14:46 ` [PATCH 3/5] xen/domain: Call lock_profile_deregister_struct() from common code Andrew Cooper
2018-09-03 16:05   ` Jan Beulich
2018-09-03 16:56   ` Wei Liu
2018-09-03 14:46 ` [PATCH 4/5] xen/domain: Fold xsm_free_security_domain() paths together Andrew Cooper
2018-09-03 16:08   ` Jan Beulich
2018-09-03 16:57   ` Wei Liu
2018-09-07 20:48   ` [Non-DoD Source] " DeGraaf, Daniel G
2018-09-03 14:47 ` [PATCH 5/5] xen/domain: Make rangeset_domain_destroy() idempotent Andrew Cooper
2018-09-03 16:09   ` Jan Beulich
2018-09-03 16:57   ` Wei Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1535986020-15906-1-git-send-email-andrew.cooper3@citrix.com \
    --to=andrew.cooper3@citrix.com \
    --cc=JBeulich@suse.com \
    --cc=julien.grall@arm.com \
    --cc=roger.pau@citrix.com \
    --cc=sstabellini@kernel.org \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).