From: David Woodhouse <dwmw2@infradead.org>
To: Paul Durrant <Paul.Durrant@citrix.com>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Eslam Elnikety <elnikety@amazon.de>,
Andrew Cooper <Andrew.Cooper3@citrix.com>,
Shan Haitao <haitao.shan@intel.com>,
Jan Beulich <jbeulich@suse.com>
Subject: Re: [PATCH v2] x86/hvm: re-work viridian APIC assist code
Date: Wed, 05 Sep 2018 10:40:22 +0100 [thread overview]
Message-ID: <1536140422.31549.59.camel@infradead.org> (raw)
In-Reply-To: <88abe6b0dee947ad93af543653dde12a@AMSPEX02CL03.citrite.net>
[-- Attachment #1.1: Type: text/plain, Size: 819 bytes --]
On Wed, 2018-09-05 at 09:36 +0000, Paul Durrant wrote:
>
> I see. Given that Windows has used APIC assist to circumvent its EOI
> then I wonder whether we can get away with essentially doing the
> same. I.e. for a completed APIC assist found in
> vlapic_has_pending_irq() we simply clear the APIC assist and highest
> vector in the ISR, rather than calling through to vlapic_EOI_set()
> and suffering the overhead. I'll spin up a patch and give it a whirl.
I think that's fine if you don't actually pass unmaskable MSIs through
to the guest in question, but if you *do* then you still need the EOI
to happen properly to "unmask" it.
Hence my approach which is basically doing what you said and bypassing
the expensive part of hvm_dpci_msi_eoi(), but *only* if there's no
unmaskable MSI to worry about.
[-- Attachment #1.2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 5213 bytes --]
[-- Attachment #2: Type: text/plain, Size: 157 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-09-05 9:40 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-18 15:10 [PATCH v2] x86/hvm: re-work viridian APIC assist code Paul Durrant
2018-01-18 16:21 ` Jan Beulich
2018-01-18 16:27 ` Paul Durrant
2018-08-24 23:38 ` David Woodhouse
2018-09-03 10:12 ` Paul Durrant
2018-09-04 20:31 ` David Woodhouse
2018-09-05 9:36 ` Paul Durrant
2018-09-05 9:40 ` David Woodhouse [this message]
2018-09-05 9:43 ` Paul Durrant
2018-09-05 10:40 ` Paul Durrant
2018-09-05 10:45 ` David Woodhouse
2018-09-05 10:48 ` Paul Durrant
2020-08-11 13:25 ` [Xen-devel] " David Woodhouse
2020-08-12 13:43 ` Roger Pau Monné
2020-08-13 8:10 ` Paul Durrant
2020-08-13 9:45 ` Roger Pau Monné
2020-08-14 14:13 ` David Woodhouse
2020-08-14 14:41 ` Roger Pau Monné
2020-08-19 7:12 ` Jan Beulich
2020-08-19 8:26 ` Roger Pau Monné
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1536140422.31549.59.camel@infradead.org \
--to=dwmw2@infradead.org \
--cc=Andrew.Cooper3@citrix.com \
--cc=Paul.Durrant@citrix.com \
--cc=elnikety@amazon.de \
--cc=haitao.shan@intel.com \
--cc=jbeulich@suse.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).