From: Stefano Stabellini <sstabellini@kernel.org>
To: xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <stefanos@xilinx.com>,
sstabellini@kernel.org, rcojocaru@bitdefender.com,
andrew.cooper3@citrix.com, julien.grall@arm.com,
Tamas K Lengyel <tamas@tklengyel.com>,
JBeulich@suse.com
Subject: [PATCH v3 2/4] xen/arm: initialize access
Date: Tue, 6 Nov 2018 14:05:57 -0800 [thread overview]
Message-ID: <1541541959-23140-2-git-send-email-sstabellini@kernel.org> (raw)
In-Reply-To: <alpine.DEB.2.10.1811061403440.21987@sstabellini-ThinkPad-X260>
Initialize variable *access before returning it back to the caller.
It makes the code a bit nicer and it is a safety certification
requirement.
M3CM Rule-9.1: The value of an object with automatic storage duration
shall not be read before it has been set
QAVerify: 2962
Signed-off-by: Stefano Stabellini <stefanos@xilinx.com>
Acked-by: Razvan Cojocaru <rcojocaru@bitdefender.com>
CC: rcojocaru@bitdefender.com
CC: Tamas K Lengyel <tamas@tklengyel.com>
---
Changes in v3:
- add more info to commit messagte
Changes in v2:
- improve comment
- use p2m->default_access
---
xen/arch/arm/mem_access.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/xen/arch/arm/mem_access.c b/xen/arch/arm/mem_access.c
index ba4ec78..86f0882 100644
--- a/xen/arch/arm/mem_access.c
+++ b/xen/arch/arm/mem_access.c
@@ -47,6 +47,7 @@ static int __p2m_get_mem_access(struct domain *d, gfn_t gfn,
};
ASSERT(p2m_is_locked(p2m));
+ *access = p2m->default_access;
/* If no setting was ever set, just return rwx. */
if ( !p2m->mem_access_enabled )
--
1.9.1
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-11-06 22:06 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-06 22:05 [PATCH v3 0/4] misc safety certification fixes Stefano Stabellini
2018-11-06 22:05 ` [PATCH v3 1/4] xen/arm: initialize target Stefano Stabellini
2018-11-09 11:24 ` Julien Grall
2018-11-06 22:05 ` Stefano Stabellini [this message]
2018-11-09 11:24 ` [PATCH v3 2/4] xen/arm: initialize access Julien Grall
2018-11-06 22:05 ` [PATCH v3 3/4] xen: introduce SYMBOL Stefano Stabellini
2018-11-08 14:45 ` Jan Beulich
2018-11-08 22:24 ` Stefano Stabellini
2018-11-09 11:25 ` Julien Grall
2018-11-06 22:05 ` [PATCH v3 4/4] xen: use SYMBOL everywhere Stefano Stabellini
2018-11-08 14:51 ` Jan Beulich
2018-11-08 22:27 ` Stefano Stabellini
2018-11-09 7:07 ` Jan Beulich
2018-11-12 12:25 ` Julien Grall
2018-11-12 18:05 ` Stefano Stabellini
2018-11-09 11:48 ` Julien Grall
2018-11-09 21:44 ` Stefano Stabellini
2018-11-09 11:54 ` [PATCH v3 0/4] misc safety certification fixes Julien Grall
2018-11-09 16:45 ` Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1541541959-23140-2-git-send-email-sstabellini@kernel.org \
--to=sstabellini@kernel.org \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=julien.grall@arm.com \
--cc=rcojocaru@bitdefender.com \
--cc=stefanos@xilinx.com \
--cc=tamas@tklengyel.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).