* [PATCH] x86/pv: Drop redundant CONFIG_PV ifdefary
@ 2019-04-03 18:56 Andrew Cooper
2019-04-04 8:25 ` Wei Liu
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Cooper @ 2019-04-03 18:56 UTC (permalink / raw)
To: Xen-devel; +Cc: Andrew Cooper, Wei Liu, Jan Beulich, Roger Pau Monné
These were made redundant by c/s 23058e7b3 "x86/shadow: put PV L1TF functions
under CONFIG_PV" but makes the code read as if outside of the ifdef.
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Jan Beulich <JBeulich@suse.com>
CC: Wei Liu <wei.liu2@citrix.com>
CC: Roger Pau Monné <roger.pau@citrix.com>
---
xen/include/asm-x86/shadow.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/xen/include/asm-x86/shadow.h b/xen/include/asm-x86/shadow.h
index 0d9f663..2690584 100644
--- a/xen/include/asm-x86/shadow.h
+++ b/xen/include/asm-x86/shadow.h
@@ -237,7 +237,7 @@ static inline void pv_l1tf_domain_init(struct domain *d)
d->arch.pv.check_l1tf = is_hardware_domain(d) ? opt_pv_l1tf_hwdom
: opt_pv_l1tf_domu;
-#if defined(CONFIG_SHADOW_PAGING) && defined(CONFIG_PV)
+#if defined(CONFIG_SHADOW_PAGING)
tasklet_init(&d->arch.paging.shadow.pv_l1tf_tasklet,
pv_l1tf_tasklet, (unsigned long)d);
#endif
@@ -245,7 +245,7 @@ static inline void pv_l1tf_domain_init(struct domain *d)
static inline void pv_l1tf_domain_destroy(struct domain *d)
{
-#if defined(CONFIG_SHADOW_PAGING) && defined(CONFIG_PV)
+#if defined(CONFIG_SHADOW_PAGING)
tasklet_kill(&d->arch.paging.shadow.pv_l1tf_tasklet);
#endif
}
--
2.1.4
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] x86/pv: Drop redundant CONFIG_PV ifdefary
2019-04-03 18:56 [PATCH] x86/pv: Drop redundant CONFIG_PV ifdefary Andrew Cooper
@ 2019-04-04 8:25 ` Wei Liu
2019-04-04 11:44 ` Jan Beulich
0 siblings, 1 reply; 3+ messages in thread
From: Wei Liu @ 2019-04-04 8:25 UTC (permalink / raw)
To: Andrew Cooper; +Cc: Roger Pau Monné, Wei Liu, Jan Beulich, Xen-devel
On Wed, Apr 03, 2019 at 07:56:18PM +0100, Andrew Cooper wrote:
> These were made redundant by c/s 23058e7b3 "x86/shadow: put PV L1TF functions
> under CONFIG_PV" but makes the code read as if outside of the ifdef.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Reviewed-by: Wei Liu <wei.liu2@citrix.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] x86/pv: Drop redundant CONFIG_PV ifdefary
2019-04-04 8:25 ` Wei Liu
@ 2019-04-04 11:44 ` Jan Beulich
0 siblings, 0 replies; 3+ messages in thread
From: Jan Beulich @ 2019-04-04 11:44 UTC (permalink / raw)
To: Andrew Cooper; +Cc: Xen-devel, Wei Liu, Roger Pau Monne
>>> On 04.04.19 at 10:25, <wei.liu2@citrix.com> wrote:
> On Wed, Apr 03, 2019 at 07:56:18PM +0100, Andrew Cooper wrote:
>> These were made redundant by c/s 23058e7b3 "x86/shadow: put PV L1TF functions
>> under CONFIG_PV" but makes the code read as if outside of the ifdef.
>>
>> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
>
> Reviewed-by: Wei Liu <wei.liu2@citrix.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
albeit preferably with the shorter #ifdef used.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-04-04 11:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-04-03 18:56 [PATCH] x86/pv: Drop redundant CONFIG_PV ifdefary Andrew Cooper
2019-04-04 8:25 ` Wei Liu
2019-04-04 11:44 ` Jan Beulich
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).