From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Roger Pau Monne <roger.pau@citrix.com>, xen-devel@lists.xenproject.org
Cc: boris.ostrovsky@oracle.com, konrad.wilk@oracle.com
Subject: Re: [PATCH v5 5/9] x86/hvm: add vcpu parameter to guest memory copy function
Date: Fri, 20 Jan 2017 19:45:35 +0000 [thread overview]
Message-ID: <16dbe7dc-3ae9-e14c-77db-2b3dbaf42d7a@citrix.com> (raw)
In-Reply-To: <20170119172941.65642-6-roger.pau@citrix.com>
On 19/01/17 17:29, Roger Pau Monne wrote:
> @@ -3172,9 +3173,9 @@ static enum hvm_copy_result __hvm_copy(
> {
> static unsigned long lastpage;
> if ( xchg(&lastpage, gfn) != gfn )
> - gdprintk(XENLOG_DEBUG, "guest attempted write to read-only"
> + printk(XENLOG_DEBUG, "%pv guest attempted write to read-only"
> " memory page. gfn=%#lx, mfn=%#lx\n",
> - gfn, page_to_mfn(page));
> + vcpu->domain, gfn, page_to_mfn(page));
Just vcpu here, or hitting this printk() will try to follow
d->shared_info as if it were v->domain.
With this fixed, Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-01-20 19:45 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-19 17:29 [PATCH v5 0/9] Initial PVHv2 Dom0 support Roger Pau Monne
2017-01-19 17:29 ` [PATCH v5 1/9] xen/x86: remove XENFEAT_hvm_pirqs for PVHv2 guests Roger Pau Monne
2017-01-20 18:41 ` Andrew Cooper
2017-01-23 12:28 ` Roger Pau Monne
2017-01-19 17:29 ` [PATCH v5 2/9] x86/iommu: add IOMMU entries for p2m_mmio_direct pages Roger Pau Monne
2017-01-20 6:41 ` Tian, Kevin
2017-01-20 10:28 ` Roger Pau Monne
2017-01-20 18:44 ` Andrew Cooper
2017-01-22 4:45 ` Tian, Kevin
2017-01-19 17:29 ` [PATCH v5 3/9] xen/x86: split Dom0 build into PV and PVHv2 Roger Pau Monne
2017-01-20 19:03 ` Andrew Cooper
2017-01-23 12:58 ` Roger Pau Monne
2017-01-23 12:59 ` Andrew Cooper
2017-01-20 19:13 ` Boris Ostrovsky
2017-01-20 19:27 ` Andrew Cooper
2017-01-26 11:43 ` Jan Beulich
2017-01-26 16:36 ` Roger Pau Monne
2017-01-19 17:29 ` [PATCH v5 4/9] xen/x86: populate PVHv2 Dom0 physical memory map Roger Pau Monne
2017-01-20 19:41 ` Andrew Cooper
2017-01-23 11:23 ` Jan Beulich
2017-01-23 14:11 ` Boris Ostrovsky
2017-01-23 14:43 ` Roger Pau Monne
2017-01-26 12:41 ` Jan Beulich
2017-01-27 11:14 ` Tim Deegan
2017-01-27 12:37 ` Roger Pau Monne
2017-01-27 12:51 ` Andrew Cooper
2017-01-27 13:20 ` Tim Deegan
2017-01-27 13:46 ` Andrew Cooper
2017-01-27 14:01 ` Tim Deegan
2017-01-27 14:35 ` Andrew Cooper
2017-01-27 19:43 ` Tim Deegan
2017-01-30 10:43 ` Jan Beulich
2017-01-30 11:06 ` Andrew Cooper
2017-01-27 16:40 ` Jan Beulich
2017-01-27 18:06 ` Andrew Cooper
2017-02-03 13:57 ` Jan Beulich
2017-01-27 19:48 ` Tim Deegan
2017-02-02 15:38 ` Jan Beulich
2017-01-27 12:23 ` Roger Pau Monne
2017-01-27 15:11 ` Jan Beulich
2017-01-27 16:04 ` Roger Pau Monne
2017-01-27 16:29 ` Jan Beulich
2017-01-19 17:29 ` [PATCH v5 5/9] x86/hvm: add vcpu parameter to guest memory copy function Roger Pau Monne
2017-01-20 19:45 ` Andrew Cooper [this message]
2017-01-23 13:50 ` Roger Pau Monne
2017-01-26 12:51 ` Jan Beulich
2017-01-26 13:33 ` Jan Beulich
2017-01-27 14:55 ` Roger Pau Monne
2017-01-19 17:29 ` [PATCH v5 6/9] xen/x86: parse Dom0 kernel for PVHv2 Roger Pau Monne
2017-01-26 13:37 ` Jan Beulich
2017-01-27 17:22 ` Roger Pau Monne
2017-01-27 17:28 ` Roger Pau Monne
2017-01-30 10:20 ` Jan Beulich
2017-01-27 18:03 ` Roger Pau Monne
2017-01-30 10:14 ` Jan Beulich
2017-01-19 17:29 ` [PATCH v5 7/9] x86/PVHv2: fix dom0_max_vcpus so it's capped to 128 for PVHv2 Dom0 Roger Pau Monne
2017-01-19 17:32 ` Andrew Cooper
2017-01-26 13:39 ` Jan Beulich
2017-01-19 17:29 ` [PATCH v5 8/9] xen/x86: Setup PVHv2 Dom0 CPUs Roger Pau Monne
2017-01-26 13:46 ` Jan Beulich
2017-02-08 12:48 ` Roger Pau Monne
2017-02-08 13:02 ` Jan Beulich
2017-01-19 17:29 ` [PATCH v5 9/9] xen/x86: setup PVHv2 Dom0 ACPI tables Roger Pau Monne
2017-01-26 14:16 ` Jan Beulich
2017-02-08 15:10 ` Roger Pau Monne
2017-02-08 15:50 ` Jan Beulich
2017-02-08 15:58 ` Roger Pau Monne
2017-02-08 16:03 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16dbe7dc-3ae9-e14c-77db-2b3dbaf42d7a@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=konrad.wilk@oracle.com \
--cc=roger.pau@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).