From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Martin Subject: Re: Grant access to more than one dom Date: Thu, 8 May 2014 11:47:12 -0400 Message-ID: <1746801210.20140508114712@gmail.com> References: <1005757746.20140417115849@gmail.com> <1397747022.24638.306.camel@kazak.uk.xensource.com> <197873202.20140417123854@gmail.com> <1397751294.24638.308.camel@kazak.uk.xensource.com> <582473149.20140417135713@gmail.com> <53500C5E.10904@tycho.nsa.gov> <33361074.20140417150609@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <33361074.20140417150609@gmail.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Daniel De Graaf Cc: Ian Campbell , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org Hi Daniel. > I'll carry on then. When I have it working and tested I'll send it to > you so you can have a look. Once everyone is happy I'll see about > pushing it to a kernel maintainer. After being sidetracked into other more boring projects I have now almost completed this change, however I have some questions. I'm pretty certain that I must be missing something here. For the moment I am only looking at gntalloc.c as it is the one I need. In the add_grefs function you create a couple of list structures (queue_gref and queue_file) and then splice these onto the end of the gref_list and gntalloc_file_private_data.list lists. However I'm not really sure what you are doing here. Can you explain please. The problems I see are: 1.- queue_gref and queue_file are declared on the stack, however they are then appended to the lists with no memory allocation whatsoever. What are you expecting to happen here? 2.- queue_gref and queue_file are just list structs, i.e. they have no payload, they are not part of an encapsulating struct, so again, what are you expecting to happen here? Regards. -- Best regards, Simon mailto:furryfuttock@gmail.com