From: Oleksandr Andrushchenko <andr2000@gmail.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
oleksandr_andrushchenko@epam.com, vlad.babchuk@gmail.com,
andrii.anisov@gmail.com, Stefano Stabellini <stefano@aporeto.com>,
al1img@gmail.com, xen-devel@lists.xenproject.org,
joculator@gmail.com
Subject: Re: [PATCH v3] ring.h: introduce macros to handle monodirectional rings with multiple req sizes
Date: Wed, 22 Feb 2017 09:47:50 +0200 [thread overview]
Message-ID: <17db1d9d-3675-4268-0199-efd13df0321c@gmail.com> (raw)
In-Reply-To: <58AD4E7D020000780013C942@prv-mh.provo.novell.com>
On 02/22/2017 09:40 AM, Jan Beulich wrote:
>>>> On 22.02.17 at 08:16, <andr2000@gmail.com> wrote:
>> 3. C89 - Jan, we discussed that a bit for zero-sized arrays [2]
>> and empty structures [3]. So, then we came to a conclusion that
>> breakage is not acceptable, but now I see that you have changed
>> your mind? (Please correct me if I got it wrong). The reason I am
>> bringing this back to life is that sndif and displif protocols
>> use grefs[1] construct, while originally I was about to avoid that "1".
>> So, as now Stefano introduces *grant_ref_t ref[];* I would also
>> like to change sndif/displif to use the same. Do you think it can be
>> done this time?
> I don't think so, no. Please pay close attention to the reason why I
> think an exception is fine in the case here, but not there: Someone
> including ring.h without actively using the new macro will not see a
> compile failure. Someone including sndif.h, otoh, would afaict.
fair enough, but it means that those who want to use
PV calls/9pfs will not be able to do so with C89, right?
> Jan
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-02-22 7:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-21 23:25 [PATCH v3] ring.h: introduce macros to handle monodirectional rings with multiple req sizes Stefano Stabellini
2017-02-22 7:16 ` Oleksandr Andrushchenko
2017-02-22 7:40 ` Jan Beulich
2017-02-22 7:47 ` Oleksandr Andrushchenko [this message]
2017-02-22 7:54 ` Jan Beulich
2017-02-22 17:10 ` Stefano Stabellini
2017-02-23 7:08 ` Oleksandr Andrushchenko
2017-02-23 18:45 ` Stefano Stabellini
2017-02-27 7:02 ` Oleksandr Andrushchenko
2017-02-27 22:17 ` Stefano Stabellini
2017-02-28 7:11 ` Oleksandr Andrushchenko
2017-02-28 19:46 ` Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17db1d9d-3675-4268-0199-efd13df0321c@gmail.com \
--to=andr2000@gmail.com \
--cc=JBeulich@suse.com \
--cc=al1img@gmail.com \
--cc=andrii.anisov@gmail.com \
--cc=joculator@gmail.com \
--cc=oleksandr_andrushchenko@epam.com \
--cc=sstabellini@kernel.org \
--cc=stefano@aporeto.com \
--cc=vlad.babchuk@gmail.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).