From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dan Magenheimer <dan.magenheimer@oracle.com>
Subject: RE: [PATCH]xl: Add missing start_time entry when create
	and restore VMs
Date: Fri, 14 May 2010 08:47:48 -0700 (PDT)
Message-ID: <181d8804-a9f0-4707-a2bc-514132a13c29@default>
References: <4BED3507.2010307@cn.fujitsu.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <4BED3507.2010307@cn.fujitsu.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Yang Hongyang <yanghy@cn.fujitsu.com>, xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

> + vments[5] =3D libxl_sprintf(ctx, "%lu.%d", start_time.tv_sec,(int)start=
_time.tv_usec/10000);
> + vments[i++] =3D libxl_sprintf(ctx, "%lu.%d",start_time.tv_sec,(int)star=
t_time.tv_usec/10000);

I don't think these work as intended.  For example, if
tv_usec is 10000, I think you want xxx.01 printed, not
xxx.1.  Maybe you want %lu.%02d?

And in any case, is there a reason to limit the precision
to two digits?  Why not %lu.%06d?