From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH] xen: Fix inconsistent callers of panic() Date: Fri, 7 Sep 2018 17:42:37 +0100 Message-ID: <18cd971c-d5c3-9cc0-0bfe-10a295e87665@citrix.com> References: <1535632297-29549-1-git-send-email-andrew.cooper3@citrix.com> <5B87FA3102000078001E38B7@prv1-mh.provo.novell.com> <5B88E15002000078001E3BBD@prv1-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <5B88E15002000078001E3BBD@prv1-mh.provo.novell.com> Content-Language: en-GB List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Jan Beulich Cc: Julien Grall , Stefano Stabellini , Wei Liu , Xen-devel List-Id: xen-devel@lists.xenproject.org T24gMzEvMDgvMTggMDc6MzMsIEphbiBCZXVsaWNoIHdyb3RlOgo+Pj4+IE9uIDMwLjA4LjE4IGF0 IDE5OjA4LCA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNvbT4gd3JvdGU6Cj4+IE9uIDMwLzA4LzE4 IDE1OjA3LCBKYW4gQmV1bGljaCB3cm90ZToKPj4+Pj4+IE9uIDMwLjA4LjE4IGF0IDE0OjMxLCA8 YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNvbT4gd3JvdGU6Cj4+Pj4gVGhlIG9ic2VydmFudCBhbW9u Z3N0IHlvdSBtaWdodCByZWFsaXNlIHRoYXQgdGhpcyByZXZlcnRzIHBhcnRzIG9mIGMvcwo+Pj4+ IDUxYWQ5MGFlYTIxYyAtIFdoYXQgY2FuIEkgc2F5PyAgU2V2ZXJhbCB5ZWFycyBvZiBoaW5kc2ln aHQgaXMgdmVyeSB1c2VmdWwsIGFuZAo+Pj4+IGF0IHRoZSB0aW1lIEkgZGlkIGFzayB0aGUgbWFp bnRhaW5lcnMgd2hpY2ggb3B0aW9uIHRoZXkgdGhvdWdodCB3b3VsZCBiZQo+Pj4+IGJldHRlci4u Lgo+Pj4gLi4uIEkgdGhpbmsgYm90aCB0aGUgZWFybGllciBhbmQgdGhpcyBjaGFuZ2UgYXJlIGhl YWRpbmcgaW4gdGhlCj4+PiB3cm9uZyBkaXJlY3Rpb246IEkgd291bGQgbXVjaCByYXRoZXIgc2Vl IHRoZSBuZXdsaW5lIG9taXR0ZWQKPj4+IGV2ZXJ5d2hlcmUsIF9pbmNsdWRpbmdfIGluIHBhbmlj KCkgaXRzZWxmOiBUaGlzIGNhdXNlcyBvbmUgbGluZQo+Pj4gbGVzcyB0byBzY3JvbGwgb2ZmIHRo ZSBzY3JlZW4gaW4gY2FzZSB5b3UgZG9uJ3QgaGF2ZSBhIHNlcmlhbAo+Pj4gY29uc29sZS4KPj4g SSBkb24ndCBleHBlY3QgdGhhdCBzdWdnZXN0aW9uIHdvdWxkIGdldCBhbnl3aGVyZSBpZiB5b3Ug cHV0IGl0IHRvIGEKPj4gdm90ZSB3aXRoIFRoZSBSRVNULgo+IFdlbGwsIEkgY2FuIGNlcnRhaW5s eSBsaXZlIHdpdGggYmVpbmcgdGhlIG9ubHkgb25lIGhlcmUsIHNob3VsZAo+IHRoYXQgdHVybiBv dXQgdG8gYmUgdGhlIGNhc2UuCj4KPj4gRm9yIG9uZSwgaXQgYnJlYWtzIGFueSBhYmlsaXR5IHRv IGNvbnN0cnVjdCBhIHNpbmdsZSBsaW5lIG9mIHRleHQgZnJvbQo+PiBtdWx0aXBsZSBwcmludGso KSBjYWxscyAod2hpY2ggd2UgaGF2ZSBwbGVudHkgb2YgZXhhbXBsZXMgb2YgaW4gdGhlCj4+IGNv ZGViYXNlKSwgYW5kIGl0IGZ1cnRoZXIgZGV2aWF0ZXMgZnJvbSBldmVyeW9uZeKAmXMgZXhwZWN0 YXRpb24gb2YgaG93Cj4+IHByaW50aygpIHdvcmtzICh3aGljaCBpcyB0aGUgdmVyeSByZWFzb24g d2UndmUgcGlja2VkIHVwIGFsbCB0aGVzZQo+PiBpbmNvbnNpc3RlbmNpZXMgc2luY2UgSSBsYXN0 IG1hZGUgdGhlbSBjb25zaXN0ZW50KS4KPiBMZXQgbWUgdW5kZXJzdGFuZCB0aGlzOiBBcmUgeW91 IHN1Z2dlc3RpbmcgdHdvIChieSB0aGVpciBuYW1lcwo+IGFuZCBwdXJwb3NlcykgY29tcGxldGVs eSBkaWZmZXJlbnQgZnVuY3Rpb25zCgpJJ20gZ29pbmcgdG8gc3RvcCB5b3UgbWlkIHNlbnRlbmNl IGFuZCBvYmplY3QgdG8gcHJpbnRrKCkgYW5kIHBhbmljKCkKYmVpbmcgY2xhc3NpZmllZCBhcyAi Y29tcGxldGVseSBkaWZmZXJlbnQiLgoKVGhlIGFyZSBib3RoLCBmaXJzdCBhbmQgZm9yZW1vc3Qs IHVzZWQgZm9yIGdldHRpbmcgaW5mb3JtYXRpb24gb3V0IG9udG8KdGhlIGNvbnNvbGUuwqAgcGFu aWMoKSBqdXN0IGhhcyBhbiBleHRyYSBzaWRlIGVmZmVjdCBvZiBjcmFzaGluZyB0aGUgbWFjaGlu ZS4KCj4gbmVlZCB0byBhZGhlcmUgdG8gc29tZSBjb21tb24gcHJpbmNpcGxlPyBJZiBzbywgSSBk b24ndCB0aGluayBJIGNhbiBhZ3JlZSB3aXRoIHlvdQo+IGhlcmUuCgpGdW5jdGlvbnMgd2l0aCBj b21tb24gdXNhZ2Ugc2hvdWxkIGFkaGVyZSB0byBjb21tb24gcHJpbmNpcGxlcy7CoApUaGVyZWZv cmUsIHBhbmljKCkgYW5kIHByaW50aygpIHNob3VsZCBiZSBjb25zaXN0ZW50IG9uIHdoZXRoZXIg dGhleQp0YWtlIGEgbmV3bGluZSBvciBub3QgaW4gdGhlaXIgZm9ybWF0IHN0cmluZy4KCkZ1cnRo ZXJtb3JlLCBBUElzIG9mIG91cnMgd2hpY2ggYXJlIG1vZGVsbGVkIGFmdGVyIGFuIGV4aXN0aW5n IEFQSSwgaW4KdGhpcyBjYXNlIHByaW50ZigpLCBzaG91bGQgaGF2ZSB0aGUgc2FtZSBleHBlY3Rh dGlvbnMsIGJlY2F1c2UgdGhhdCBpcwpob3cgcGVvcGxlIGxlYXJuIEMuwqAgVGhlcmVmb3JlLCBw cmludGsoKSBhbmQgcGFuaWMoKSBzaG91bGQgaGF2ZSBhCnRyYWlsaW5nIG5ld2xpbmUgaW4gdGhl IGZvcm1hdCBzdHJpbmcgaWYgYSBuZXdsaW5lIHdhbnRzIGVtaXR0aW5nIG9uIHRoZQpjb25zb2xl LgoKPj4gSU1PLCBzdWNoIGEgY2hhbmdlIHdvdWxkIGJlIGRldHJpbWVudGFsLCBiZWNhdXNlIGVp dGhlciB0aGUgY29kZSB3aWxsCj4+IGdldCBvdXQgb2Ygc3luYyBhZ2FpbiAobW9zdCBsaWtlbHkp LCBvciB0aGVyZSB3aWxsIGV4dHJhIHJldmlldwo+PiBhZ2dyYXZhdGlvbiBhcyBwZW9wbGUgc3Vi bWl0dGluZyBjb2RlIHRvIG5vcm1hbCBleHBlY3RhdGlvbnMgaGF2ZSB0aGVpcgo+PiBjb2RlIHJl amVjdGVkLgo+IFF1aXRlIGZyZXF1ZW50bHkgcGVvcGxlIGZvbGxvdyBleGlzdGluZyBwcmFjdGlj ZSB3aGVuIGFkZGluZyBuZXcKPiBjb2RlLiBJZiBhbGwgcGFuaWMoKSBpbnZvY2F0aW9ucyBvbWl0 dGVkIHRoZSBuZXdsaW5lLCBjaGFuY2VzIGFyZQo+IHByZXR0eSBnb29kIHRoYXQgbmV3IGluc3Rh bmNlcyB3b3VsZCBkbyBzbyBhcyB3ZWxsLgoKVGhpcyBwYXRjaCBpcyBhIDMgeWVhciBjYXNlIHN0 dWR5IGRlbW9uc3RyYXRpbmcgdGhlIGV4YWN0IG9wcG9zaXRlLgoKSSBtYWRlIHBhbmljKCkgY29u c2lzdGVudGx5IChub3QpIHRha2UgYSBcbiwgYW5kIDMgeWVhcnMgbGF0ZXIsIHdlIGhhdmUKc3Rp bGwgZ290IGJhY2sgdG8gYSA1MCUgfm1peC4KCj4gQ2hhbmNlcyBhcmUgZXZlbiBzbyBnb29kIHRo YXQgcGVvcGxlIHRlbmQgdG8gY29weSBhbmQgcGFzdGUgYnVnZ3kgY29kZQo+IHdpdGhvdXQgcGF5 aW5nIGF0dGVudGlvbi4KCldoZW4gZXZlcnlvbmUgaXMgc3VibWl0dGluZyBjb2RlIHdoaWNoIHNl ZW1zIHRvIHNsaXAgXG4gaW4gKGluY2x1ZGluZwp5b3UgLSBjL3MgNTc4NGRlMyB3aGljaCB3YXMg dGhlIFhQVEkgcGF0Y2gpLCBhbmQgbm9uZSBvZiB0aGUKcmV2aWV3ZXJzL2NvbW1pdHRlcnMgbm90 aWNlIGFuZCBmaXggaXQgdXAsIGl0IGlzIG9idmlvdXMgdGhhdCB0aGUKY3VycmVudCBleHBlY3Rh dGlvbnMgYXJlIHdyb25nLgoKW01lcmdpbmcgcGFydCBvZiB0aGUgbGF0ZXIgY29udmVyc2lvbl0K ClJlZHVjaW5nIHRoZSBudW1iZXIgb2YgbGluZXMgcHJpbnRlZCBmcm9tIGEgcGFuaWMvYmFja3Ry YWNlIG1heSBiZSBhCmdvb2QgdGhpbmcsIGJ1dCBwbGVhc2UgY2FuIHdlIG5vdCBjb25mbGF0ZSBp dCB3aXRoIHRoaXMgd2hpY2ggaXMgZml4IGFuCkFQSSBpbmNvbnNpc3RlbmN5LgoKfkFuZHJldwoK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKaHR0cHM6Ly9saXN0 cy54ZW5wcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL3hlbi1kZXZlbA==