From: Olaf Hering <olaf@aepfle.de>
To: xen-devel@lists.xensource.com
Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>
Subject: [PATCH 13 of 18] tools/xenpaging: fix build errors caused by -Werror
Date: Mon, 02 Apr 2012 22:15:36 +0200 [thread overview]
Message-ID: <1a0b5c53a3da2a47a98e.1333397736@probook.site> (raw)
In-Reply-To: <patchbomb.1333397723@probook.site>
# HG changeset patch
# User Olaf Hering <olaf@aepfle.de>
# Date 1333397571 -7200
# Node ID 1a0b5c53a3da2a47a98ec093b296616c4b22d810
# Parent 5d89ebdf878b8b0647a688d0ef938bb933772d86
tools/xenpaging: fix build errors caused by -Werror
-O2 -Wall -Werror triggers these warnings:
xenpaging.c: In function 'xenpaging_init':
xenpaging.c:284: warning: unused variable 'p'
xenpaging.c: In function 'xenpaging_evict_page':
xenpaging.c:606: warning: unused variable 'domctl'
xenpaging.c: In function 'resume_pages':
xenpaging.c:742: warning: unused variable 'xch'
xenpaging.c: In function 'evict_pages':
xenpaging.c:820: warning: unused variable 'xch'
Remove the offending local variables.
Signed-off-by: Olaf Hering <olaf@aepfle.de>
Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
diff -r 5d89ebdf878b -r 1a0b5c53a3da tools/xenpaging/xenpaging.c
--- a/tools/xenpaging/xenpaging.c
+++ b/tools/xenpaging/xenpaging.c
@@ -279,7 +279,6 @@ static struct xenpaging *xenpaging_init(
xc_domaininfo_t domain_info;
xc_interface *xch = NULL;
xentoollog_logger *dbg = NULL;
- char *p;
int rc;
unsigned long ring_pfn, mmap_pfn;
@@ -601,8 +600,6 @@ static int xenpaging_evict_page(struct x
xen_pfn_t victim = gfn;
int ret;
- DECLARE_DOMCTL;
-
/* Nominate page */
ret = xc_mem_paging_nominate(xch, paging->mem_event.domain_id, gfn);
if ( ret < 0 )
@@ -737,7 +734,6 @@ static int xenpaging_populate_page(struc
/* Trigger a page-in for a batch of pages */
static void resume_pages(struct xenpaging *paging, int num_pages)
{
- xc_interface *xch = paging->xc_handle;
int i, num = 0;
for ( i = 0; i < paging->max_pages && num < num_pages; i++ )
@@ -815,7 +811,6 @@ static int evict_victim(struct xenpaging
*/
static int evict_pages(struct xenpaging *paging, int num_pages)
{
- xc_interface *xch = paging->xc_handle;
int rc, slot, num = 0;
/* Reuse known free slots */
next prev parent reply other threads:[~2012-04-02 20:15 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-02 20:15 [PATCH 00 of 18] [v2] tools: fix bugs and build errors triggered by -O2 -Wall -Werror Olaf Hering
2012-04-02 20:15 ` [PATCH 01 of 18] tools/blktap: remove unneeded pointer dereferencing in convert_dev_name_to_num Olaf Hering
2012-04-02 20:15 ` [PATCH 02 of 18] tools/blktap: constify string arrays " Olaf Hering
2012-04-02 20:15 ` [PATCH 03 of 18] tools/blktap: fix params and physical-device parsing Olaf Hering
2012-04-02 20:15 ` [PATCH 04 of 18] tools/blktap: remove unneeded pointer dereferencing from img2qcow.c Olaf Hering
2012-04-02 20:15 ` [PATCH 05 of 18] tools/blktap: remove unneeded pointer dereferencing from qcow2raw.c Olaf Hering
2012-04-02 20:15 ` [PATCH 06 of 18] tools/blktap2: fix build errors caused by Werror in vhd_journal_write_entry Olaf Hering
2012-04-02 20:15 ` [PATCH 07 of 18] tools/blktap2: fix out of bounds access in block-log.c Olaf Hering
2012-04-02 20:15 ` [PATCH 08 of 18] tools/blktap2: fix build errors caused by Werror in tdqcow_get_parent_id Olaf Hering
2012-04-02 20:15 ` [PATCH 09 of 18] tools/blktap2: remove unneeded pointer dereferencing from img2qcow.c Olaf Hering
2012-04-02 20:15 ` [PATCH 10 of 18] tools/blktap2: remove unneeded pointer dereferencing from qcow2raw.c Olaf Hering
2012-04-02 20:15 ` [PATCH 11 of 18] tools/libvchan: fix function prototypes in node-select.c Olaf Hering
2012-04-02 20:15 ` [PATCH 12 of 18] tools/memshr: fix build errors caused by Werror Olaf Hering
2012-04-02 20:15 ` Olaf Hering [this message]
2012-04-02 20:15 ` [PATCH 14 of 18] tools/libvchan: fix build errors caused by Werror in io.c Olaf Hering
2012-04-03 10:25 ` Ian Jackson
2012-04-03 10:50 ` Ian Campbell
2012-04-03 15:04 ` Olaf Hering
2012-04-03 16:39 ` Ian Campbell
2012-04-02 20:15 ` [PATCH 15 of 18] tools/blktap2: remove static string table from header file Olaf Hering
2012-04-02 20:15 ` [PATCH 16 of 18] tools/blktap2: fix build errors caused by Werror, remove blkif_op_name Olaf Hering
2012-04-02 20:15 ` [PATCH 17 of 18] tools/blktap2: remove unused labels Olaf Hering
2012-04-02 20:15 ` [PATCH 18 of 18] tools/blktap+blktap2: fix build errors caused by Werror, remove unused variables Olaf Hering
2012-04-03 13:21 ` Ian Jackson
-- strict thread matches above, loose matches on Subject: below --
2012-03-30 8:25 [PATCH 00 of 18] tools: fix bugs and build errors triggered by -O2 -Wall -Werror Olaf Hering
2012-03-30 8:25 ` [PATCH 13 of 18] tools/xenpaging: fix build errors caused by -Werror Olaf Hering
2012-04-02 14:01 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1a0b5c53a3da2a47a98e.1333397736@probook.site \
--to=olaf@aepfle.de \
--cc=Ian.Jackson@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).