From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Wei Liu <wei.liu2@citrix.com>,
Xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [XTF PATCH] Makefile: introduce gtags target
Date: Tue, 27 Sep 2016 17:45:32 +0100 [thread overview]
Message-ID: <1a1328fc-54ed-a221-cab8-9f2348bccb1c@citrix.com> (raw)
In-Reply-To: <1474994355-6375-1-git-send-email-wei.liu2@citrix.com>
On 27/09/16 17:39, Wei Liu wrote:
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> ---
> .gitignore | 3 +++
> Makefile | 10 +++++++++-
> 2 files changed, 12 insertions(+), 1 deletion(-)
>
> diff --git a/.gitignore b/.gitignore
> index f69e7fc..28c7874 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -11,3 +11,6 @@
> /selftests/test-*
> /tests/*/test-*
> /tests/*/info.json
> +/GPATH
> +/GRTAGS
> +/GTAGS
> diff --git a/Makefile b/Makefile
> index 17d784e..6767f72 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -50,11 +50,19 @@ install:
> $(MAKE) -C $$D install; \
> done
>
> +define all_sources
> + ( find include/ arch/ common/ tests/ -name "*.[hcsS]" )
Why the subshell? It doesn't look necessary.
Otherwise, Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
> +endef
> +
> .PHONY: cscope
> cscope:
> - find include/ arch/ common/ tests/ -name "*.[hcsS]" > cscope.files
> + $(all_sources) > cscope.files
> cscope -b -q -k
>
> +.PHONY: gtags
> +gtags:
> + $(all_sources) | gtags -f -
> +
> .PHONY: clean
> clean:
> find . \( -name "*.o" -o -name "*.d" -o -name "*.lds" \) -delete
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
prev parent reply other threads:[~2016-09-27 16:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-27 16:39 [XTF PATCH] Makefile: introduce gtags target Wei Liu
2016-09-27 16:45 ` Andrew Cooper [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1a1328fc-54ed-a221-cab8-9f2348bccb1c@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).