From: "Håkon Alstadheim" <hakon@alstadheim.priv.no>
To: xen-devel@lists.xenproject.org
Subject: Re: [PATCH V1 1/1] Xen/libxl: Perform PCI reset using 'reset' SysFS attribute
Date: Wed, 20 Dec 2017 22:39:56 +0100 [thread overview]
Message-ID: <1a192ce9-9171-d127-d18a-b341bcbf2a46@alstadheim.priv.no> (raw)
In-Reply-To: <90c62b47-daae-747d-8fbf-c04402c63ae1@Oracle.COM>
Den 18. des. 2017 19:33, skrev Govinda Tatti:
>>>> Are you saying do_flr doesn't exist at all in any version of Linux,
>>>> and as such the line you're removing is currently pointless?
>>> Yes, that's correct. In other-words, it will not break any existing code
>>> or functionality.
>> Except for people, like me, running unofficial patches to linux. It
>> should be OK to assume they are watching this thread.
> Do we need to account for unofficial patches or usage of do_flr?. If yes,
> we need to maintainbackward compatibility for do_flr attribute.
When the final, official change to the linux backend driver goes in,
local patches will no longer apply.
The cause should be obvious to anybody dealing with patching the linux
sources on their own. Running newer kernels as dom0 on old Xen would
just mean those people would need a different (simpler) patch.
As a convenience, I'd like a heads up before the interface on the
xen/libxl side changes, so I can make sure to run a compatible dom0
kernel. An entry in changelog should suffice.
A wishlist item might be to have libxl error message be as fool-proof as
possible. "Failed to access pciback path %s" could perhaps be improved
upon. Perhaps add "make sure pciback version is compatible with libxl
version".
Adding backwards compatibility code just for this would be unnecessary
cruft as far as I can see.
I'll go back to lurking now.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
prev parent reply other threads:[~2017-12-20 21:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-07 22:26 [PATCH V1 0/1] Xen/Tools: PCI reset using 'reset' SysFS attribute Govinda Tatti
2017-12-07 22:26 ` [PATCH V1 1/1] Xen/libxl: Perform " Govinda Tatti
2017-12-13 1:11 ` Govinda Tatti
2017-12-13 14:01 ` George Dunlap
2017-12-13 21:05 ` Govinda Tatti
2017-12-14 10:31 ` George Dunlap
2017-12-14 20:22 ` Govinda Tatti
2017-12-14 21:31 ` Håkon Alstadheim
2017-12-18 18:33 ` Govinda Tatti
2017-12-20 21:39 ` Håkon Alstadheim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1a192ce9-9171-d127-d18a-b341bcbf2a46@alstadheim.priv.no \
--to=hakon@alstadheim.priv.no \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).