From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [RFC PATCH 01/10] ARM: vGIC: remove rank lock from IRQ routing functions Date: Thu, 4 May 2017 16:53:04 +0100 Message-ID: <1c11740c-d9f5-8ab7-2b43-6c76be81a6fb@arm.com> References: <20170504153123.1204-1-andre.przywara@arm.com> <20170504153123.1204-2-andre.przywara@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d6J40-00089R-Nb for xen-devel@lists.xenproject.org; Thu, 04 May 2017 15:53:08 +0000 In-Reply-To: <20170504153123.1204-2-andre.przywara@arm.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Andre Przywara , Stefano Stabellini Cc: xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org SGkgQW5kcmUsCgpPbiAwNC8wNS8xNyAxNjozMSwgQW5kcmUgUHJ6eXdhcmEgd3JvdGU6Cj4gZ2lj X3JvdXRlX2lycV90b19ndWVzdCgpIGFuZCBnaWNfcmVtb3ZlX2lycV9mcm9tX2d1ZXN0KCkgdGFr ZSB0aGUgcmFuawo+IGxvY2ssIGhvd2V2ZXIgbmV2ZXIgYWN0dWFsbHkgYWNjZXNzIHRoZSByYW5r IHN0cnVjdHVyZS4KPiBBdm9pZCB0YWtpbmcgdGhlIGxvY2sgaW4gdGhvc2UgdHdvIGZ1bmN0aW9u cyBhbmQgcmVtb3ZlIHNvbWUgbW9yZQo+IHVubmVlZGVkIGNvZGUgb24gdGhlIHdheS4KClRoZSBy YW5rIGlzIGhlcmUgdG8gcHJvdGVjdCBwLT5kZXNjIHdoZW4gY2hlY2tpbmcgdGhhdCB0aGUgdmly dHVhbCAKaW50ZXJydXB0IHdhcyBub3QgeWV0IHJvdXRlZCB0byBhbm90aGVyIHBoeXNpY2FsIGlu dGVycnVwdC4KCldpdGhvdXQgdGhpcyBsb2NraW5nLCB5b3UgY2FuIGhhdmUgdHdvIGNvbmN1cnJl bnQgY2FsbCBvZiAKZ2ljX3JvdXRlX2lycV90b19ndWVzdCB0aGF0IHdpbGwgdXBkYXRlIHRoZSBz YW1lIHZpcnR1YWwgaW50ZXJydXB0IGJ1dCAKd2l0aCBkaWZmZXJlbnQgcGh5c2ljYWwgaW50ZXJy dXB0cy4KCllvdSB3b3VsZCBoYXZlIHRvIHJlcGxhY2UgdGhlIHJhbmsgbG9jayBieSB0aGUgcGVy LXBlbmRpbmdfaXJxIGxvY2sgdG8gCmtlZXAgdGhlIGNvZGUgc2FmZS4KCkNoZWVycywKCj4KPiBT aWduZWQtb2ZmLWJ5OiBBbmRyZSBQcnp5d2FyYSA8YW5kcmUucHJ6eXdhcmFAYXJtLmNvbT4KPiAt LS0KPiAgeGVuL2FyY2gvYXJtL2dpYy5jIHwgMjggKysrKy0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LQo+ICAxIGZpbGUgY2hhbmdlZCwgNCBpbnNlcnRpb25zKCspLCAyNCBkZWxldGlvbnMoLSkKPgo+ IGRpZmYgLS1naXQgYS94ZW4vYXJjaC9hcm0vZ2ljLmMgYi94ZW4vYXJjaC9hcm0vZ2ljLmMKPiBp bmRleCBkYTE5MTMwLi5jNzM0ZjY2IDEwMDY0NAo+IC0tLSBhL3hlbi9hcmNoL2FybS9naWMuYwo+ ICsrKyBiL3hlbi9hcmNoL2FybS9naWMuYwo+IEBAIC0xMzYsMjUgKzEzNiwxOSBAQCB2b2lkIGdp Y19yb3V0ZV9pcnFfdG9feGVuKHN0cnVjdCBpcnFfZGVzYyAqZGVzYywgdW5zaWduZWQgaW50IHBy aW9yaXR5KQo+ICBpbnQgZ2ljX3JvdXRlX2lycV90b19ndWVzdChzdHJ1Y3QgZG9tYWluICpkLCB1 bnNpZ25lZCBpbnQgdmlycSwKPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgc3RydWN0IGly cV9kZXNjICpkZXNjLCB1bnNpZ25lZCBpbnQgcHJpb3JpdHkpCj4gIHsKPiAtICAgIHVuc2lnbmVk IGxvbmcgZmxhZ3M7Cj4gICAgICAvKiBVc2UgdmNwdTAgdG8gcmV0cmlldmUgdGhlIHBlbmRpbmdf aXJxIHN0cnVjdC4gR2l2ZW4gdGhhdCB3ZSBvbmx5Cj4gICAgICAgKiByb3V0ZSBTUElzIHRvIGd1 ZXN0cywgaXQgZG9lc24ndCBtYWtlIGFueSBkaWZmZXJlbmNlLiAqLwo+IC0gICAgc3RydWN0IHZj cHUgKnZfdGFyZ2V0ID0gdmdpY19nZXRfdGFyZ2V0X3ZjcHUoZC0+dmNwdVswXSwgdmlycSk7Cj4g LSAgICBzdHJ1Y3QgdmdpY19pcnFfcmFuayAqcmFuayA9IHZnaWNfcmFua19pcnEodl90YXJnZXQs IHZpcnEpOwo+IC0gICAgc3RydWN0IHBlbmRpbmdfaXJxICpwID0gaXJxX3RvX3BlbmRpbmcodl90 YXJnZXQsIHZpcnEpOwo+IC0gICAgaW50IHJlcyA9IC1FQlVTWTsKPiArICAgIHN0cnVjdCBwZW5k aW5nX2lycSAqcCA9IGlycV90b19wZW5kaW5nKGQtPnZjcHVbMF0sIHZpcnEpOwo+Cj4gICAgICBB U1NFUlQoc3Bpbl9pc19sb2NrZWQoJmRlc2MtPmxvY2spKTsKPiAgICAgIC8qIENhbGxlciBoYXMg YWxyZWFkeSBjaGVja2VkIHRoYXQgdGhlIElSUSBpcyBhbiBTUEkgKi8KPiAgICAgIEFTU0VSVCh2 aXJxID49IDMyKTsKPiAgICAgIEFTU0VSVCh2aXJxIDwgdmdpY19udW1faXJxcyhkKSk7Cj4KPiAt ICAgIHZnaWNfbG9ja19yYW5rKHZfdGFyZ2V0LCByYW5rLCBmbGFncyk7Cj4gLQo+ICAgICAgaWYg KCBwLT5kZXNjIHx8Cj4gICAgICAgICAgIC8qIFRoZSBWSVJRIHNob3VsZCBub3QgYmUgYWxyZWFk eSBlbmFibGVkIGJ5IHRoZSBndWVzdCAqLwo+ICAgICAgICAgICB0ZXN0X2JpdChHSUNfSVJRX0dV RVNUX0VOQUJMRUQsICZwLT5zdGF0dXMpICkKPiAtICAgICAgICBnb3RvIG91dDsKPiArICAgICAg ICByZXR1cm4gLUVCVVNZOwo+Cj4gICAgICBkZXNjLT5oYW5kbGVyID0gZ2ljX2h3X29wcy0+Z2lj X2d1ZXN0X2lycV90eXBlOwo+ICAgICAgc2V0X2JpdChfSVJRX0dVRVNULCAmZGVzYy0+c3RhdHVz KTsKPiBAQCAtMTY0LDI5ICsxNTgsMjAgQEAgaW50IGdpY19yb3V0ZV9pcnFfdG9fZ3Vlc3Qoc3Ry dWN0IGRvbWFpbiAqZCwgdW5zaWduZWQgaW50IHZpcnEsCj4gICAgICBnaWNfc2V0X2lycV9wcmlv cml0eShkZXNjLCBwcmlvcml0eSk7Cj4KPiAgICAgIHAtPmRlc2MgPSBkZXNjOwo+IC0gICAgcmVz ID0gMDsKPgo+IC1vdXQ6Cj4gLSAgICB2Z2ljX3VubG9ja19yYW5rKHZfdGFyZ2V0LCByYW5rLCBm bGFncyk7Cj4gLQo+IC0gICAgcmV0dXJuIHJlczsKPiArICAgIHJldHVybiAwOwo+ICB9Cj4KPiAg LyogVGhpcyBmdW5jdGlvbiBvbmx5IHdvcmtzIHdpdGggU1BJcyBmb3Igbm93ICovCj4gIGludCBn aWNfcmVtb3ZlX2lycV9mcm9tX2d1ZXN0KHN0cnVjdCBkb21haW4gKmQsIHVuc2lnbmVkIGludCB2 aXJxLAo+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBzdHJ1Y3QgaXJxX2Rlc2MgKmRl c2MpCj4gIHsKPiAtICAgIHN0cnVjdCB2Y3B1ICp2X3RhcmdldCA9IHZnaWNfZ2V0X3RhcmdldF92 Y3B1KGQtPnZjcHVbMF0sIHZpcnEpOwo+IC0gICAgc3RydWN0IHZnaWNfaXJxX3JhbmsgKnJhbmsg PSB2Z2ljX3JhbmtfaXJxKHZfdGFyZ2V0LCB2aXJxKTsKPiAtICAgIHN0cnVjdCBwZW5kaW5nX2ly cSAqcCA9IGlycV90b19wZW5kaW5nKHZfdGFyZ2V0LCB2aXJxKTsKPiAtICAgIHVuc2lnbmVkIGxv bmcgZmxhZ3M7Cj4gKyAgICBzdHJ1Y3QgcGVuZGluZ19pcnEgKnAgPSBpcnFfdG9fcGVuZGluZyhk LT52Y3B1WzBdLCB2aXJxKTsKPgo+ICAgICAgQVNTRVJUKHNwaW5faXNfbG9ja2VkKCZkZXNjLT5s b2NrKSk7Cj4gICAgICBBU1NFUlQodGVzdF9iaXQoX0lSUV9HVUVTVCwgJmRlc2MtPnN0YXR1cykp Owo+ICAgICAgQVNTRVJUKHAtPmRlc2MgPT0gZGVzYyk7Cj4KPiAtICAgIHZnaWNfbG9ja19yYW5r KHZfdGFyZ2V0LCByYW5rLCBmbGFncyk7Cj4gLQo+ICAgICAgaWYgKCBkLT5pc19keWluZyApCj4g ICAgICB7Cj4gICAgICAgICAgZGVzYy0+aGFuZGxlci0+c2h1dGRvd24oZGVzYyk7Cj4gQEAgLTIw NCwxMCArMTg5LDcgQEAgaW50IGdpY19yZW1vdmVfaXJxX2Zyb21fZ3Vlc3Qoc3RydWN0IGRvbWFp biAqZCwgdW5zaWduZWQgaW50IHZpcnEsCj4gICAgICAgICAgICovCj4gICAgICAgICAgaWYgKCB0 ZXN0X2JpdChfSVJRX0lOUFJPR1JFU1MsICZkZXNjLT5zdGF0dXMpIHx8Cj4gICAgICAgICAgICAg ICAhdGVzdF9iaXQoX0lSUV9ESVNBQkxFRCwgJmRlc2MtPnN0YXR1cykgKQo+IC0gICAgICAgIHsK PiAtICAgICAgICAgICAgdmdpY191bmxvY2tfcmFuayh2X3RhcmdldCwgcmFuaywgZmxhZ3MpOwo+ ICAgICAgICAgICAgICByZXR1cm4gLUVCVVNZOwo+IC0gICAgICAgIH0KPiAgICAgIH0KPgo+ICAg ICAgY2xlYXJfYml0KF9JUlFfR1VFU1QsICZkZXNjLT5zdGF0dXMpOwo+IEBAIC0yMTUsOCArMTk3 LDYgQEAgaW50IGdpY19yZW1vdmVfaXJxX2Zyb21fZ3Vlc3Qoc3RydWN0IGRvbWFpbiAqZCwgdW5z aWduZWQgaW50IHZpcnEsCj4KPiAgICAgIHAtPmRlc2MgPSBOVUxMOwo+Cj4gLSAgICB2Z2ljX3Vu bG9ja19yYW5rKHZfdGFyZ2V0LCByYW5rLCBmbGFncyk7Cj4gLQo+ICAgICAgcmV0dXJuIDA7Cj4g IH0KPgo+CgotLSAKSnVsaWVuIEdyYWxsCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpYZW4tZGV2ZWwgbWFpbGluZyBsaXN0Clhlbi1kZXZlbEBsaXN0cy54 ZW4ub3JnCmh0dHBzOi8vbGlzdHMueGVuLm9yZy94ZW4tZGV2ZWwK