From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH] x86/mmcfg: Fix initalisation of variables in pci_mmcfg_nvidia_mcp55()
Date: Wed, 3 Aug 2016 12:03:55 +0100 [thread overview]
Message-ID: <1d22b946-c892-c4bc-a3ff-0c34b87df66c@citrix.com> (raw)
In-Reply-To: <57A1E2910200007800102267@prv-mh.provo.novell.com>
On 03/08/16 11:24, Jan Beulich wrote:
>>>> On 03.08.16 at 11:51, <andrew.cooper3@citrix.com> wrote:
>> --- a/xen/arch/x86/x86_64/mmconfig-shared.c
>> +++ b/xen/arch/x86/x86_64/mmconfig-shared.c
>> @@ -182,10 +182,10 @@ static const char __init *pci_mmcfg_nvidia_mcp55(void)
>> int bus, i;
>>
>> static const u32 extcfg_regnum = 0x90;
>> - static const u32 extcfg_enable_mask = 1<<31;
>> - static const u32 extcfg_start_mask = 0xff<<16;
>> + static const u32 extcfg_enable_mask = 1u << 31;
> Aiui only this one change is really related to the patch subject; the
> other two I suppose you just alter for consistency? Anyway,
> Acked-by: Jan Beulich <jbeulich@suse.com>
Indeed.
~Andrew
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
prev parent reply other threads:[~2016-08-03 11:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-03 9:51 [PATCH] x86/mmcfg: Fix initalisation of variables in pci_mmcfg_nvidia_mcp55() Andrew Cooper
2016-08-03 10:24 ` Jan Beulich
2016-08-03 11:03 ` Andrew Cooper [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1d22b946-c892-c4bc-a3ff-0c34b87df66c@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=JBeulich@suse.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).