From: Paul Durrant <Paul.Durrant@citrix.com>
To: 'Jan Beulich' <JBeulich@suse.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
Andrew Cooper <Andrew.Cooper3@citrix.com>,
George Dunlap <George.Dunlap@citrix.com>,
Julien Grall <julien.grall@arm.com>,
Jun Nakajima <jun.nakajima@intel.com>,
xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v6 09/14] mm / iommu: include need_iommu() test in iommu_use_hap_pt()
Date: Tue, 11 Sep 2018 09:39:24 +0000 [thread overview]
Message-ID: <1ed1d6509b3043e89ccfe352a9b64ad4@AMSPEX02CL03.citrite.net> (raw)
In-Reply-To: <5B925EF202000078001E655B@prv1-mh.provo.novell.com>
> -----Original Message-----
> From: Jan Beulich [mailto:JBeulich@suse.com]
> Sent: 07 September 2018 12:20
> To: Paul Durrant <Paul.Durrant@citrix.com>
> Cc: Julien Grall <julien.grall@arm.com>; Andrew Cooper
> <Andrew.Cooper3@citrix.com>; George Dunlap
> <George.Dunlap@citrix.com>; Jun Nakajima <jun.nakajima@intel.com>;
> Stefano Stabellini <sstabellini@kernel.org>; xen-devel <xen-
> devel@lists.xenproject.org>
> Subject: Re: [PATCH v6 09/14] mm / iommu: include need_iommu() test in
> iommu_use_hap_pt()
>
> >>> On 23.08.18 at 11:47, <paul.durrant@citrix.com> wrote:
> > The name 'iommu_use_hap_pt' suggests that that P2M table is in use as
> the
> > domain's IOMMU pagetable which, prior to this patch, is not strictly true
> > since the macro did not test whether the domain actually has IOMMU
> > mappings.
>
> Hmm, I would never have implied "has IOMMU mappings" from this
> variable name. To me it has always been "use HAP page tables for
> IOMMU if an IOMMU is in use". The code change looks sane, but
> I'm not sure it is a clear improvement. Hence I wonder whether you
> have a need for this change in subsequent patches which goes
> beyond what you say above.
>
I could take it out but it would mean a non-trivial rebase, and to me - if true - the name sill implies the IOMMU is in use for the domain so I'd like to keep the change.
Paul
> Jan
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-09-11 9:39 UTC|newest]
Thread overview: 111+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-23 9:46 [PATCH v6 00/14] paravirtual IOMMU interface Paul Durrant
2018-08-23 9:46 ` [PATCH v6 01/14] iommu: introduce the concept of BFN Paul Durrant
2018-08-30 15:59 ` Jan Beulich
2018-09-03 8:23 ` Paul Durrant
2018-09-03 11:46 ` Jan Beulich
2018-09-04 6:48 ` Tian, Kevin
2018-09-04 8:32 ` Jan Beulich
2018-09-04 8:37 ` Tian, Kevin
2018-09-04 8:47 ` Jan Beulich
2018-09-04 8:49 ` Paul Durrant
2018-09-04 9:08 ` Jan Beulich
2018-09-05 0:42 ` Tian, Kevin
2018-09-05 6:48 ` Jan Beulich
2018-09-05 6:56 ` Tian, Kevin
2018-09-05 7:11 ` Jan Beulich
2018-09-05 9:13 ` Paul Durrant
2018-09-05 9:38 ` Jan Beulich
2018-09-06 10:36 ` Paul Durrant
2018-09-06 13:13 ` Jan Beulich
2018-09-06 14:54 ` Paul Durrant
2018-09-07 1:47 ` Tian, Kevin
2018-09-07 6:24 ` Jan Beulich
2018-09-07 8:13 ` Paul Durrant
2018-09-07 8:16 ` Tian, Kevin
2018-09-07 8:25 ` Paul Durrant
2018-08-23 9:46 ` [PATCH v6 02/14] iommu: make use of type-safe BFN and MFN in exported functions Paul Durrant
2018-09-04 10:29 ` Jan Beulich
2018-08-23 9:47 ` [PATCH v6 03/14] iommu: push use of type-safe BFN and MFN into iommu_ops Paul Durrant
2018-09-04 10:32 ` Jan Beulich
2018-08-23 9:47 ` [PATCH v6 04/14] iommu: don't domain_crash() inside iommu_map/unmap_page() Paul Durrant
2018-09-04 10:38 ` Jan Beulich
2018-09-04 10:39 ` Paul Durrant
2018-08-23 9:47 ` [PATCH v6 05/14] public / x86: introduce __HYPERCALL_iommu_op Paul Durrant
2018-09-04 11:50 ` Jan Beulich
2018-09-04 12:23 ` Paul Durrant
2018-09-04 12:55 ` Jan Beulich
2018-09-04 13:17 ` Paul Durrant
2018-09-07 10:52 ` Jan Beulich
2018-08-23 9:47 ` [PATCH v6 06/14] iommu: track reserved ranges using a rangeset Paul Durrant
2018-09-07 10:40 ` Jan Beulich
2018-09-11 9:28 ` Paul Durrant
2018-08-23 9:47 ` [PATCH v6 07/14] x86: add iommu_op to query reserved ranges Paul Durrant
2018-09-07 11:01 ` Jan Beulich
2018-09-11 9:34 ` Paul Durrant
2018-09-11 9:43 ` Jan Beulich
2018-09-13 6:11 ` Tian, Kevin
2018-08-23 9:47 ` [PATCH v6 08/14] vtd: add lookup_page method to iommu_ops Paul Durrant
2018-09-07 11:11 ` Jan Beulich
2018-09-07 12:36 ` Paul Durrant
2018-09-07 14:56 ` Jan Beulich
2018-09-07 15:24 ` Paul Durrant
2018-09-07 15:52 ` Jan Beulich
2018-09-12 8:31 ` Paul Durrant
2018-09-12 8:43 ` Jan Beulich
2018-09-12 8:45 ` Paul Durrant
2018-09-12 8:51 ` Paul Durrant
2018-09-12 8:53 ` Paul Durrant
2018-09-12 9:03 ` Jan Beulich
2018-09-12 9:05 ` Paul Durrant
2018-09-12 9:12 ` Jan Beulich
2018-09-12 9:15 ` Paul Durrant
2018-09-12 9:21 ` Jan Beulich
2018-09-12 9:30 ` Paul Durrant
2018-09-12 10:07 ` Jan Beulich
2018-09-12 10:09 ` Paul Durrant
2018-09-12 12:15 ` Jan Beulich
2018-09-12 12:22 ` Paul Durrant
2018-09-12 12:39 ` Jan Beulich
2018-09-12 12:53 ` Paul Durrant
2018-09-12 13:19 ` Jan Beulich
2018-09-12 13:25 ` Paul Durrant
2018-09-12 13:39 ` Jan Beulich
2018-09-12 13:43 ` Paul Durrant
2018-09-12 8:59 ` Jan Beulich
2018-08-23 9:47 ` [PATCH v6 09/14] mm / iommu: include need_iommu() test in iommu_use_hap_pt() Paul Durrant
2018-09-07 11:20 ` Jan Beulich
2018-09-11 9:39 ` Paul Durrant [this message]
2018-09-11 9:47 ` Jan Beulich
2018-09-13 6:23 ` Tian, Kevin
2018-09-13 8:34 ` Paul Durrant
2018-08-23 9:47 ` [PATCH v6 10/14] mm / iommu: split need_iommu() into has_iommu_pt() and need_iommu_pt_sync() Paul Durrant
2018-08-23 11:10 ` Razvan Cojocaru
2018-09-11 14:31 ` Jan Beulich
2018-09-11 15:40 ` Paul Durrant
2018-09-12 6:45 ` Jan Beulich
2018-09-12 8:07 ` Paul Durrant
2018-08-23 9:47 ` [PATCH v6 11/14] x86: add iommu_op to enable modification of IOMMU mappings Paul Durrant
2018-09-11 14:48 ` Jan Beulich
2018-09-11 15:52 ` Paul Durrant
2018-09-12 6:53 ` Jan Beulich
2018-09-12 8:04 ` Paul Durrant
2018-08-23 9:47 ` [PATCH v6 12/14] memory: add get_paged_gfn() as a wrapper Paul Durrant
2018-08-23 10:24 ` Julien Grall
2018-08-23 10:30 ` Paul Durrant
2018-09-11 14:56 ` Jan Beulich
2018-09-12 9:10 ` Paul Durrant
2018-09-12 9:15 ` Jan Beulich
2018-09-12 10:01 ` George Dunlap
2018-09-12 10:08 ` Paul Durrant
2018-09-12 10:10 ` Jan Beulich
2018-08-23 9:47 ` [PATCH v6 13/14] x86: add iommu_ops to modify and flush IOMMU mappings Paul Durrant
2018-09-11 15:15 ` Jan Beulich
2018-09-12 7:03 ` Jan Beulich
2018-09-12 8:02 ` Paul Durrant
2018-09-12 8:27 ` Jan Beulich
2018-09-13 6:41 ` Tian, Kevin
2018-09-13 8:32 ` Paul Durrant
2018-09-13 8:49 ` Jan Beulich
2018-08-23 9:47 ` [PATCH v6 14/14] x86: extend the map and unmap iommu_ops to support grant references Paul Durrant
2018-09-12 14:12 ` Jan Beulich
2018-09-12 16:28 ` Paul Durrant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1ed1d6509b3043e89ccfe352a9b64ad4@AMSPEX02CL03.citrite.net \
--to=paul.durrant@citrix.com \
--cc=Andrew.Cooper3@citrix.com \
--cc=George.Dunlap@citrix.com \
--cc=JBeulich@suse.com \
--cc=julien.grall@arm.com \
--cc=jun.nakajima@intel.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).