From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Blake Subject: Re: [Qemu-devel] [PATCH] Fix issues affecting Xen 9pfs discovered by Coverity Date: Mon, 8 May 2017 16:11:30 -0500 Message-ID: <1f0bf90b-a706-01c8-cad1-6dea6620deef@redhat.com> References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1923240293997672714==" Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Stefano Stabellini , anthony.perard@citrix.com Cc: groug@kaod.org, xen-devel@lists.xensource.com, aneesh.kumar@linux.vnet.ibm.com, qemu-devel@nongnu.org List-Id: xen-devel@lists.xenproject.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============1923240293997672714== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="0wrl2I62axX5rCCecxecReCHJVo05LHa1" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --0wrl2I62axX5rCCecxecReCHJVo05LHa1 Content-Type: multipart/mixed; boundary="4vvNBwRmNx7IQOxBOtD1BJ5CabJT7MkvS"; protected-headers="v1" From: Eric Blake To: Stefano Stabellini , anthony.perard@citrix.com Cc: xen-devel@lists.xensource.com, aneesh.kumar@linux.vnet.ibm.com, qemu-devel@nongnu.org, groug@kaod.org Message-ID: <1f0bf90b-a706-01c8-cad1-6dea6620deef@redhat.com> Subject: Re: [Qemu-devel] [PATCH] Fix issues affecting Xen 9pfs discovered by Coverity References: In-Reply-To: --4vvNBwRmNx7IQOxBOtD1BJ5CabJT7MkvS Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 05/08/2017 03:45 PM, Stefano Stabellini wrote: > Fix two resource leaks on error paths, discovered by Coverity. > Check for errors returned by fcntl, also found by Coverity. >=20 > CID:1374836 > CID:1374831 >=20 > @@ -378,7 +380,10 @@ static int xen_9pfs_connect(struct XenDevice *xend= ev) > if (xen_9pdev->rings[i].evtchndev =3D=3D NULL) { > goto out; > } > - fcntl(xenevtchn_fd(xen_9pdev->rings[i].evtchndev), F_SETFD, FD= _CLOEXEC); > + if (fcntl(xenevtchn_fd(xen_9pdev->rings[i].evtchndev), > + F_SETFD, FD_CLOEXEC) =3D=3D -1) { > + goto out; Directly calling fcntl(F_SETFD) without first reading fcntl(F_GETFD) is (theoretically) incorrect. Better might be using qemu_set_cloexec() instead of open-coding something. --=20 Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org --4vvNBwRmNx7IQOxBOtD1BJ5CabJT7MkvS-- --0wrl2I62axX5rCCecxecReCHJVo05LHa1 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJZEN8CAAoJEKeha0olJ0NqTB8H/1JgGZ2smxjJVtOdw0DQcMwG nlkechOKjB3urHR4uNnorZDTGsOgroswYzvWhubriVm5y49kasHoy8JHnVWiZTxT 3MQuSFargA4yQeDDk6ieYB/2PQ7uvdFL8x76W/QfKnroth7jPkDaILZHPo7Qf4in clrSO/KxsoIPKIluXM4pYXbp3gppmOd2wysPYS0qwCCXg5d/hbA79M/D37hs7ocu BQzhl3oKxTKPgAg2jcSB+TRxkDvAhBGxJd+JTXkbvQZSP1gzdl+NQQIEHmw8uDev QIisyxkxrxF9kSZWhtDwqstoCCMgTjobKhllOQEflaQIqi49tlOJ5mQ7Zi1wFCE= =7BsU -----END PGP SIGNATURE----- --0wrl2I62axX5rCCecxecReCHJVo05LHa1-- --===============1923240293997672714== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5v cmcveGVuLWRldmVsCg== --===============1923240293997672714==--