From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pascal Bouchareine Subject: cannot access memory beyond end of bootstrap direct-map area Date: Thu, 27 Aug 2009 19:28:17 +0200 Message-ID: <20090827172817.GA25165@bar> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=_bar-25733-1251394097-0001-2" Return-path: Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org This is a MIME-formatted message. If you see this text it means that your E-mail software does not support MIME-formatted messages. --=_bar-25733-1251394097-0001-2 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: inline Hi, Investigating the above message during xen 3.3 boot, found we left a wrong assumption [modules_length == (mod[n].end - mod[0].start)] in move_memory call, leading to an access above BOOTSTRAP_DIRECTMAP_END and this panic on x86_32. In my understanding Keir's patch 18630 was fixing this kind of problem and I'm wondering why this move_memory call didn't go away with it ? If this were ok, attached patch fixes the panic on my system. Cheers, Pascal -- \o/ Pascal Bouchareine - Gandi g 0170393757 15, place de la Nation - 75011 Paris --=_bar-25733-1251394097-0001-2 Content-Type: text/x-diff; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="xen-setup-remap-modules.patch" Signed-off-by: Pascal Bouchareine diff -r d9289e28e5e7 xen/arch/x86/setup.c --- a/xen/arch/x86/setup.c Thu Aug 06 13:29:39 2009 +0100 +++ b/xen/arch/x86/setup.c Thu Aug 27 18:53:08 2009 +0200 @@ -737,11 +737,6 @@ void __init __start_xen(unsigned long mb if ( !initial_images_start && (s < e) && ((e-s) >= modules_length) ) { initial_images_end = e; - e = (e - modules_length) & PAGE_MASK; - initial_images_start = e; - move_memory(initial_images_start, - mod[0].mod_start, mod[mbi->mods_count-1].mod_end); - e += modules_length; for ( j = mbi->mods_count-1; j >= 0; j-- ) { e -= mod[j].mod_end - mod[j].mod_start; @@ -749,6 +744,7 @@ void __init __start_xen(unsigned long mb mod[j].mod_end += e - mod[j].mod_start; mod[j].mod_start = e; } + initial_images_start = e; } if ( !kexec_crash_area.start && (s < e) && --=_bar-25733-1251394097-0001-2 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel --=_bar-25733-1251394097-0001-2--