From: Bastian Blank <bastian@waldi.eu.org>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: Xen-devel <xen-devel@lists.xensource.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@redhat.com>,
the arch/x86 maintainers <x86@kernel.org>,
Stable Kernel <stable@kernel.org>
Subject: Re: Re: [PATCH] xen: Disable stack protector for irq helper
Date: Tue, 6 Oct 2009 00:43:10 +0200 [thread overview]
Message-ID: <20091005224310.GA32144@wavehammer.waldi.eu.org> (raw)
In-Reply-To: <4ACA2AFD.4080305@goop.org>
On Mon, Oct 05, 2009 at 10:21:01AM -0700, Jeremy Fitzhardinge wrote:
> > Save all caller-saved registers on x86_32 for the paravirt callee saved
> > registers.
> That looks better, but it is still overkill. We only need to save the
> set of registers the ABI requires the callee to preserve. What
> additional register(s) gets clobbered by stack-protector that need to be
> saved?
Well, exactly the two, ecx and edx. eax is still clobbered by the return
value. Anyway, it works in praxis.
Bastian
--
Superior ability breeds superior ambition.
-- Spock, "Space Seed", stardate 3141.9
next prev parent reply other threads:[~2009-10-05 22:43 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-04 18:30 [PATCH] xen: Disable stack protector for irq helper Bastian Blank
2009-10-04 23:06 ` Jeremy Fitzhardinge
2009-10-05 1:35 ` Bastian Blank
2009-10-05 17:21 ` Jeremy Fitzhardinge
2009-10-05 22:43 ` Bastian Blank [this message]
2009-10-06 0:36 ` Jeremy Fitzhardinge
2009-10-06 3:30 ` Bastian Blank
2009-10-06 19:01 ` Jeremy Fitzhardinge
2009-10-07 16:35 ` Bastian Blank
2009-10-08 0:33 ` Jeremy Fitzhardinge
2009-10-12 20:52 ` Ingo Molnar
2009-10-12 21:12 ` Bastian Blank
2009-10-12 22:20 ` Jeremy Fitzhardinge
2009-10-12 23:32 ` Jeremy Fitzhardinge
2009-10-13 7:25 ` [tip:x86/urgent] x86/paravirt: Use normal calling sequences for irq enable/disable tip-bot for Jeremy Fitzhardinge
2009-10-05 1:52 ` [PATCH] xen: fbdev frontend needs xenbus frontend Bastian Blank
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091005224310.GA32144@wavehammer.waldi.eu.org \
--to=bastian@waldi.eu.org \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=stable@kernel.org \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).