From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Ronny.Hegewald@online.de
Cc: xen-devel@lists.xensource.com
Subject: Re: pvops dom0: no sound after boot; possibly caused by swiotlb
Date: Tue, 2 Feb 2010 20:26:24 -0500 [thread overview]
Message-ID: <20100203012624.GA30466@phenom.dumpdata.com> (raw)
In-Reply-To: <20100203003116.GA9888@phenom.dumpdata.com>
On Tue, Feb 02, 2010 at 07:31:16PM -0500, Konrad Rzeszutek Wilk wrote:
> > But thats not quite all whats dma_alloc_coherent does. As it only returns a 32-bit variable all coherent_dma_mask over 32-bit get casted down. This way bare-metal makes sure that the dma-mask is never over 32-bit.
>
> Ooooh. I completly failed to notice that your dom0 was 32-bit.
>
> But having that there would make the mask always be below
> 4GB, irregardless if the dom0 is 32 or 64-bit. Which is
<sigh> That is actually incorrect. Looking at the
dma_alloc_coherent_mask I missed the '!' and thought it would set it
irregardless of what the previous value was. That is not the case.
So your fix is good and it should be put in pv-ops. Thanks for tracking
down the problem and fixing it.
next prev parent reply other threads:[~2010-02-03 1:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-03 0:24 pvops dom0: no sound after boot; possibly caused by swiotlb Ronny.Hegewald
2010-02-03 0:31 ` Konrad Rzeszutek Wilk
2010-02-03 1:26 ` Konrad Rzeszutek Wilk [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-01-26 0:40 Ronny.Hegewald
2010-01-26 7:37 ` Keir Fraser
2010-01-26 15:05 ` Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100203012624.GA30466@phenom.dumpdata.com \
--to=konrad.wilk@oracle.com \
--cc=Ronny.Hegewald@online.de \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).