Re: remus build error

[Brendan Cully <brendan@cs.ubc.ca>]

[-- Attachment #1: Type: text/plain, Size: 955 bytes --]

On Friday, 05 February 2010 at 18:12, Christoph Egger wrote:
> On Friday 05 February 2010 18:08:20 Keir Fraser wrote:
> > On 05/02/2010 15:37, "Christoph Egger" <Christoph.Egger@amd.com> wrote:
> > > Hi!
> > >
> > > Build fails on Linux when no ebtables are installed:
> > >
> > > /xen/xen-unstable.hg/tools/remus/kmod/ebt_imq.c: In function
> > > Œebt_target_imq¹: /xen/xen-unstable.hg/tools/remus/kmod/ebt_imq.c:13:
> > > error: Œstruct sk_buff¹ has no member named Œimq_flags¹
> >
> > Brendan, can you send a fix?
> 
> I found a workaround: Enable CONFIG_IMQ in the dom0 kernel config. It is 'N' 
> by default. IMO, you should either document this new requirement or
> enable/disable this via autodetection.

Sorry, I was out of the country for a few days. It looks like Keir has
already made the module not build if IMQ is off. I've attached a
(untested) patch to linux-2.6.18-xen.hg to turn on IMQ by default for
Linux xen/xen0.

[-- Attachment #2: linux-imq-defconfig.patch --]
[-- Type: text/plain, Size: 2324 bytes --]

# HG changeset patch
# User Brendan Cully <brendan@cs.ubc.ca>
# Date 1265741893 28800
# Node ID 2ce70781e68fb4af933f75f4354e9e4cb8f106f4
# Parent  86d6c6417cf96cb018a35f300aa0b1709cf93d5c
Remus: turn on IMQ in xen/xen0 defconfig

This module is needed for Remus network buffering.

Signed-off-by: Brendan Cully <brendan@cs.ubc.ca>

diff --git a/buildconfigs/linux-defconfig_xen0_x86_32 b/buildconfigs/linux-defconfig_xen0_x86_32
--- a/buildconfigs/linux-defconfig_xen0_x86_32
+++ b/buildconfigs/linux-defconfig_xen0_x86_32
@@ -660,6 +660,12 @@
 # CONFIG_DUMMY is not set
 # CONFIG_BONDING is not set
 # CONFIG_EQUALIZER is not set
+CONFIG_IMQ=m
+# CONFIG_IMQ_BEHAVIOR_AA is not set
+CONFIG_IMQ_BEHAVIOR_AB=y
+# CONFIG_IMQ_BEHAVIOR_BA is not set
+# CONFIG_IMQ_BEHAVIOR_BB is not set
+CONFIG_IMQ_NUM_DEVS=2
 CONFIG_TUN=y
 # CONFIG_NET_SB1000 is not set
 
diff --git a/buildconfigs/linux-defconfig_xen0_x86_64 b/buildconfigs/linux-defconfig_xen0_x86_64
--- a/buildconfigs/linux-defconfig_xen0_x86_64
+++ b/buildconfigs/linux-defconfig_xen0_x86_64
@@ -612,6 +612,12 @@
 # CONFIG_DUMMY is not set
 # CONFIG_BONDING is not set
 # CONFIG_EQUALIZER is not set
+CONFIG_IMQ=m
+# CONFIG_IMQ_BEHAVIOR_AA is not set
+CONFIG_IMQ_BEHAVIOR_AB=y
+# CONFIG_IMQ_BEHAVIOR_BA is not set
+# CONFIG_IMQ_BEHAVIOR_BB is not set
+CONFIG_IMQ_NUM_DEVS=2
 CONFIG_TUN=y
 # CONFIG_NET_SB1000 is not set
 
diff --git a/buildconfigs/linux-defconfig_xen_x86_32 b/buildconfigs/linux-defconfig_xen_x86_32
--- a/buildconfigs/linux-defconfig_xen_x86_32
+++ b/buildconfigs/linux-defconfig_xen_x86_32
@@ -1292,6 +1292,12 @@
 CONFIG_DUMMY=m
 CONFIG_BONDING=m
 CONFIG_EQUALIZER=m
+CONFIG_IMQ=m
+# CONFIG_IMQ_BEHAVIOR_AA is not set
+CONFIG_IMQ_BEHAVIOR_AB=y
+# CONFIG_IMQ_BEHAVIOR_BA is not set
+# CONFIG_IMQ_BEHAVIOR_BB is not set
+CONFIG_IMQ_NUM_DEVS=2
 CONFIG_TUN=m
 CONFIG_NET_SB1000=m
 
diff --git a/buildconfigs/linux-defconfig_xen_x86_64 b/buildconfigs/linux-defconfig_xen_x86_64
--- a/buildconfigs/linux-defconfig_xen_x86_64
+++ b/buildconfigs/linux-defconfig_xen_x86_64
@@ -1235,6 +1235,12 @@
 CONFIG_DUMMY=m
 CONFIG_BONDING=m
 CONFIG_EQUALIZER=m
+CONFIG_IMQ=m
+# CONFIG_IMQ_BEHAVIOR_AA is not set
+CONFIG_IMQ_BEHAVIOR_AB=y
+# CONFIG_IMQ_BEHAVIOR_BA is not set
+# CONFIG_IMQ_BEHAVIOR_BB is not set
+CONFIG_IMQ_NUM_DEVS=2
 CONFIG_TUN=m
 CONFIG_NET_SB1000=m
 

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel