From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mukesh Rathor <mukesh.rathor@oracle.com>
Subject: Re: current not very current (vs curr_vcpu)
Date: Wed, 24 Feb 2010 17:06:18 -0800
Message-ID: <20100224170618.6d7c4608@mantra.us.oracle.com>
References: <20100223195506.0e260a58@mantra.us.oracle.com>
	<C7AAB3D0.B236%keir.fraser@eu.citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <C7AAB3D0.B236%keir.fraser@eu.citrix.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Keir Fraser <keir.fraser@eu.citrix.com>
Cc: "Xen-devel@lists.xensource.com" <Xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

On Wed, 24 Feb 2010 10:45:36 +0000
Keir Fraser <keir.fraser@eu.citrix.com> wrote:

> On 24/02/2010 03:55, "Mukesh Rathor" <mukesh.rathor@oracle.com> wrote:
.... 
> > Well, I'm afraid not. It breaks the debug code to debug the hang.
> > More importantly, it also breaks my debuggers, which some people
> > from outside oracle are also using. Most of our new high end
> > servers are accessed via virtual serial port, so if ns16550_poll()
> > call is related to it, then it'll only get worse. Moreover, anybody
> > reading and copying that code to do something similar will be
> > misled.
> 
> Okay, see how xen-unstable:20969 works for you.


Yup, better. Thanks a lot.

BTW, since debuggers only care about BUG and ASSERT, perhaps 
DEBUGGER_trap_entry could be moved after BUGFRAME_warn, next time
you are in do_invalid_op().

Mukesh