From mboxrd@z Thu Jan  1 00:00:00 1970
From: Sheng Yang <sheng@linux.intel.com>
Subject: Re: [PATCH][v5] PV extension of HVM(hybrid) in support
	in Xen
Date: Fri, 5 Mar 2010 10:01:11 +0800
Message-ID: <201003051001.11627.sheng@linux.intel.com>
References: <201003041737.14555.sheng@linux.intel.com>
	<20100304150431.GB25801@whitby.uk.xensource.com>
Mime-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <20100304150431.GB25801@whitby.uk.xensource.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Tim Deegan <Tim.Deegan@citrix.com>
Cc: Ian Campbell <Ian.Campbell@eu.citrix.com>, Ian Pratt <Ian.Pratt@eu.citrix.com>, xen-devel <xen-devel@lists.xensource.com>, Keir Fraser <Keir.Fraser@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

On Thursday 04 March 2010 23:04:31 Tim Deegan wrote:
> Hi,
> 
> Given that we now have a similar feature from Stefano I'd like to see
> them resolved into a single patchset.

I think Stefano's patch focused on pv_ops dom0? We are focused on upstream 
Linux as domU...

I think we can get dom0 approach step by step. 
> 
> At 09:37 +0000 on 04 Mar (1267695434), Sheng Yang wrote:
> > +	if (a.flags & HVM_PV_CLOCK) {
> > +		d->hvm_pv_enabled |= XEN_HVM_PV_CLOCK_ENABLED;
> > +		update_domain_wallclock_time(d);
> > +		/* Other vcpus are adjusted during the start-up */
> > +		hvm_funcs.set_tsc_offset(d->vcpu[0], 0);
> > +	}
> 
> This still makes no sense to me.  Either it should affect the calling
> vcpu (i.e., current) or it should affect all online vcpus.

Yeah... I would make it affect the calling vcpu.
> 
> Also, whatever the semantics, they should be documented in comments in
> the header file.

Sure.

-- 
regards
Yang, Sheng