From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: "Zhang, Xiantao" <xiantao.zhang@intel.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: [konrad.wilk@oracle.com: [PATCH 1 of 1] Intel VT-D: Don't turn x2APIC if there is a missing DRHD entry for the IOAPIC]
Date: Wed, 10 Mar 2010 10:38:23 -0500 [thread overview]
Message-ID: <20100310153823.GA5243@phenom.dumpdata.com> (raw)
In-Reply-To: <EB8593BCECAB3D40A8248BE0B6400A3846386B5D@shzsmsx502.ccr.corp.intel.com>
On Wed, Mar 10, 2010 at 04:42:19PM +0800, Zhang, Xiantao wrote:
> Jan Beulich wrote:
> >>>> Konrad Rzeszutek Wilk 03/09/10 6:34 PM >>>
> >>
> >> What are you guys feeling about this patch?
> >
> > My main question is whether just disabling x2apic in this case is
> > sufficient (i.e. whether instead we shouldn't disable iommu, or at
> > least interrupt remapping, altogether).
>
> iommu_enable is called after this point, and it also has sanity-check to determine whether enable or disable iommu and its related features. This early check is only used to determine whether to enable x2apic because it must be enabled at very early time if supported.
Exactly. So the x2APIC is turned off here and then later on the
Interrupt Remaping is turned off as well.
next prev parent reply other threads:[~2010-03-10 15:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-10 8:22 [konrad.wilk@oracle.com: [PATCH 1 of 1] Intel VT-D: Don't turn x2APIC if there is a missing DRHD entry for the IOAPIC] Jan Beulich
2010-03-10 8:42 ` Zhang, Xiantao
2010-03-10 15:38 ` Konrad Rzeszutek Wilk [this message]
2010-03-11 5:38 ` Cui, Dexuan
-- strict thread matches above, loose matches on Subject: below --
2010-03-09 17:17 Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100310153823.GA5243@phenom.dumpdata.com \
--to=konrad.wilk@oracle.com \
--cc=xen-devel@lists.xensource.com \
--cc=xiantao.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).