From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pasi =?iso-8859-1?Q?K=E4rkk=E4inen?= Subject: Re: [PATCH]: Support dynamic resizing of vbds Date: Mon, 22 Mar 2010 12:40:19 +0200 Message-ID: <20100322104019.GF1878@reaktio.net> References: <4BA23895020000300008184F@sinclair.provo.novell.com> <201003221015.14442.joost@antarean.org> <4BA7452D0200007800036243@vpn.id2.novell.com> <201003221042.48885.joost@antarean.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <201003221042.48885.joost@antarean.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: "J. Roeleveld" Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On Mon, Mar 22, 2010 at 10:42:48AM +0100, J. Roeleveld wrote: > On Monday 22 March 2010 10:23:41 Jan Beulich wrote: > > >>> "J. Roeleveld" 22.03.10 10:15 >>> > > > > > >On Monday 22 March 2010 09:47:40 Jan Beulich wrote: > > >> Based on the location of the file patched, it this would seem to be > > >> targeted at the 2.6.18 tree, but then 2.6.18 does not have a > > >> revalidate_disk() function (introduced only in .28). What's the deal > > >> here? Should this perhaps be carried out by open coding in blkfront > > >> what .28 does? > > >> > > >> Thanks, Jan > > > > > >Hi Jan, > > > > > >These patches are based on the Suse Xen-kernel, which are based on the > > > 2.6.30 kernel (or in that range) > > >This patch applies cleanly to the xen-kernel for Gentoo which is based on > > >2.6.29. > > > > I understand that. But if the original patch has an issue, fixed by the > > subsequently submitted one, then 2.6.18 (and other pre-.28 forward > > ported kernels that would make use of the original patch) supposedly > > also suffers from it, and hence also would need a respective fix. > > True, as this patch uses a function that wasn't introduced before 2.6.28, then > the patch would need to be applied to 2.6.28+ or one that has that function > back-ported. > RHEL5 2.6.18 kernels do have SCSI online resizing support. Redhat guys backported it for RHEL 5.3 (2.6.18-128). Grabbing the patches from the latest el5 kernel might help. -- Pasi